From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56876C5519F for ; Mon, 30 Nov 2020 07:08:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BC673206D8 for ; Mon, 30 Nov 2020 07:08:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC673206D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 265BD6B005D; Mon, 30 Nov 2020 02:08:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EF066B0068; Mon, 30 Nov 2020 02:08:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 091416B006C; Mon, 30 Nov 2020 02:08:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id E446F6B005D for ; Mon, 30 Nov 2020 02:07:59 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A36D8181AEF1A for ; Mon, 30 Nov 2020 07:07:59 +0000 (UTC) X-FDA: 77540205078.09.cloud81_0a08f86273a0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 87039180AD81A for ; Mon, 30 Nov 2020 07:07:59 +0000 (UTC) X-HE-Tag: cloud81_0a08f86273a0 X-Filterd-Recvd-Size: 2658 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Mon, 30 Nov 2020 07:07:58 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0A17FAC8F; Mon, 30 Nov 2020 07:07:58 +0000 (UTC) Subject: Re: [PATCH 07/45] loop: do not call set_blocksize To: Christoph Hellwig , Jens Axboe Cc: Tejun Heo , Josef Bacik , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Jan Kara , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20201128161510.347752-1-hch@lst.de> <20201128161510.347752-8-hch@lst.de> From: Hannes Reinecke Message-ID: <2b576021-844b-cdd9-a11d-f1f124707e65@suse.de> Date: Mon, 30 Nov 2020 08:07:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201128161510.347752-8-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/28/20 5:14 PM, Christoph Hellwig wrote: > set_blocksize is used by file systems to use their preferred buffer cac= he > block size. Block drivers should not set it. >=20 > Signed-off-by: Christoph Hellwig > Reviewed-by: Jan Kara > --- > drivers/block/loop.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index 9a27d4f1c08aac..b42c728620c9e4 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -1164,9 +1164,6 @@ static int loop_configure(struct loop_device *lo,= fmode_t mode, > size =3D get_loop_size(lo, file); > loop_set_size(lo, size); > =20 > - set_blocksize(bdev, S_ISBLK(inode->i_mode) ? > - block_size(inode->i_bdev) : PAGE_SIZE); > - > lo->lo_state =3D Lo_bound; > if (part_shift) > lo->lo_flags |=3D LO_FLAGS_PARTSCAN; >=20 Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg HRB 36809 (AG N=C3=BCrnberg), Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6= rffer