From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CD5C5321D for ; Mon, 26 Aug 2024 18:40:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 143FC6B0082; Mon, 26 Aug 2024 14:40:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CD746B0083; Mon, 26 Aug 2024 14:40:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E891C6B0085; Mon, 26 Aug 2024 14:40:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C686A6B0082 for ; Mon, 26 Aug 2024 14:40:02 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 45A32140C6C for ; Mon, 26 Aug 2024 18:40:02 +0000 (UTC) X-FDA: 82495261044.27.68625CE Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf20.hostedemail.com (Postfix) with ESMTP id D80121C0016 for ; Mon, 26 Aug 2024 18:39:59 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=OJ2tGOYE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Wipc4MzH; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ev51snqR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iDzFHaEA; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724697532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SE1TtmM95UJs6Qa7iuOcGm/QhTraIb2VVUXmj+syeFk=; b=XOo7kBJnIcBl+J1YCmv/aUMP62UebAV2p2uQnf8yqRHw/FLu6wUU7iQFnvWzLoQDQ4Kpjh 372ELKTMIGj4Tmv+WRgq/M6VcgtR+g7AsTz5LmaXmOWZ/VxXVnGFd0+nOoOyWV3Ndoy15J w4cIoQ8hHxuoEDS4rma5lonLK0Zqy1k= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=OJ2tGOYE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Wipc4MzH; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ev51snqR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iDzFHaEA; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724697532; a=rsa-sha256; cv=none; b=wvaM3vnPQ5FREJ8RXN7Qlo+VyoUKwoBLvIznDh6LG1bH4lDmRZj0kxCT9T87xHrdZZIcrI 9QkykRaYHQcqm7cqXpXIMmK2uc17u5iTe4GyHyJHhyBKUZpOiryZp2F1KO8oCb6DAsBK8J /ix/Zj+jUvp4qnVrtrts7Acv6iPBr+8= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B0E261F8AA; Mon, 26 Aug 2024 18:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724697598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SE1TtmM95UJs6Qa7iuOcGm/QhTraIb2VVUXmj+syeFk=; b=OJ2tGOYEnxYB2MPuLyOaWi3oSZP51FdZkykB+dvExabfeKS9e8adcGIiVgE20NofdNRtf3 dyxiPM2RyhvLkOJkeSCQkuwxv/EWht7smwAeR3bzjVOv6Ew1rLZt3s19EvXQfAYsGjGLLn 5FZdW6Wo8hOQQODHsRjEfHj0pwXejAY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724697598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SE1TtmM95UJs6Qa7iuOcGm/QhTraIb2VVUXmj+syeFk=; b=Wipc4MzHsYayMyIegCNyp2ia0Bvt5DaA5/NXc0lKA9ZaP5+x1/kQS2ngxQMzaz1Zt0Cwqu 5xs0p/wqssytumDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724697596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SE1TtmM95UJs6Qa7iuOcGm/QhTraIb2VVUXmj+syeFk=; b=Ev51snqRN2b2fv5gVjEirqVw660j6Hw95XtLVY3ujk1OyOdVgPKBFBNk9fC9wepJRPQzjB tKIPJeczVN3bwX+qsilOzyb296bRj5QYFGG28AGpgJHWy1bS3NAjTG5JBW7YexvLfCJTNS APiDUolxdXGwXDNjMGRxYQgFT+qTpz0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724697596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SE1TtmM95UJs6Qa7iuOcGm/QhTraIb2VVUXmj+syeFk=; b=iDzFHaEAi4+uXv3XJl01M4oloM8rC4qTnHSlk+ujjt8PAIw6OAoB/V4mduEw3o7ZvrSdlp FRsDMMTpJJevc+BQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9463513724; Mon, 26 Aug 2024 18:39:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id x74qI/zLzGZnJwAAD6G6ig (envelope-from ); Mon, 26 Aug 2024 18:39:56 +0000 Message-ID: <2b56938d-d999-4bad-a220-491aa29ef152@suse.cz> Date: Mon, 26 Aug 2024 20:39:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm, slub: print CPU id (and its node) on slab OOM Content-Language: en-US To: Axel Rasmussen , Andrew Morton , Christoph Lameter , David Rientjes , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joonsoo Kim , Pekka Enberg , Roman Gushchin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240814215037.1870645-1-axelrasmussen@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240814215037.1870645-1-axelrasmussen@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Stat-Signature: 1rizjuxdijffzmxqtr3jasq7mmx6kpag X-Rspam-User: X-Rspamd-Queue-Id: D80121C0016 X-Rspamd-Server: rspam02 X-HE-Tag: 1724697599-819842 X-HE-Meta: U2FsdGVkX1/tdPEQKdGqK06M4G58ZeR6Wwzp/lnjlbgATIIsSYwkBPAcUS6JOcrlcIbaVGxckqKUSIwmiekS8IM49kDRfDYj947JIN14yTQ1VA810inRNp2op0hfBQaHSZwchTf4L2vfFVqeYXUgKU6GJ5jU7JWc2jvHv2o3w3OWBrQZr0YWkzyxFPHT058KifjGh5qewuipJWYj5PmjPdnzKf3muz48rD8hbvMrgrvWbYxwEDW5Rt9/v7JLtFvZBQerj1eZ1IovLU8i4alEhE1IHGPvzKZgMW+ve8QUjUMNtiJZBQsvU8XQtjy/DYgSiKemJ2Y/TmLoe1LGWrWrFHkqWQlj2i2IZMPwRRakNLR9ouGTMI4ub5bxZJOvKxF8Z1EIG+LtrpMKxTlpMnuwu4xZKrlafPo0YWvutxPiomNmlx7QsssOQrt8B/97Fh+YptHQT+UZSU0amfnfMJ5Lf033YrHyDeyKvh9bTHQZWQFpeKVlfYPS2tbbTCrVWYLVTYVadvcORvPNyr3+nWeooXYKRD8s8uJ4nuiI1UBe4FYouDmi/03N9DShdPaLZ31d7hgteZ2ULYB2RlfGrRsHwm+USoBHxBuEiU+ZETtBFIMJAAnWH8ypIb6oz2pdC/7/Bin/VcXAixEi+x5OYEkA5NQwhCkc0rqn6Tv+60ovknvO+vqu6nf5RuIKHoYOk+1oa0pI5KRZ16HAvTNYJr6LYoKOUa9wgMAKiz9pA51rXkiJUAxz4pnh+zdFAMAMVd7cMvjbnyQLsXwjfMQgbMxQ2AMM8no5RGYSW8JCybejsw47lk6kfgdA9Nj9MX0sLr9gxQsfQXxQXgY3IyziO8U2IGenlFi/daa+nE/b1mVDG2WEiO71SMl44AgeHf1dJuMDlYL7I5vFmFR1qaVB9k/G3ULE5wZnEFu9613DER+v4Zo8KGX17Vqgxuj+zS8Th96i1WuoIfBg2nSA5vSa7ub k76pO6Jb +rGTEg9tflxOiEqH+pL7LTWmf7OYUk9ZsnoZR2LME2XSxsoJelOuVIrgqKo2JAF34bu1OW+xnhbR9SUvZOp4uLPFTFoYHy7334KDd3NmIOTil0MAQq926JndLe5xfmQK+DCHo8A3Ws2O6Ll4c/lOI7xuX+mdzVhDVqTh5oN1YMESnIgiNqZ+X77naVj/HeWvnDR6hUEWrWTRp3FNBAHki4M97VYzbhSEaTlnprC3DCGaf/ZuLfeqtD0eGRvhSAANGDFXvb29Ja44LWISa0SKQtKi0Zx+7UGIda7ooGXt+Jc87Q3SoETlIb30/ZSJitH84OpHmmDD9oqVwTn42fClt2IhZxrCx78fpAkhjukwoE0z94cE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/14/24 23:50, Axel Rasmussen wrote: > Depending on how remote_node_defrag_ratio is configured, allocations can > end up in this path as a result of the local node being OOM, despite the > allocation overall being unconstrained (node == -1). > > When we print a warning, printing the current CPU makes that situation > more clear (i.e., you can immediately see which node's OOM status > matters for the allocation at hand). > > Acked-by: David Rientjes > Signed-off-by: Axel Rasmussen Thanks, replaced v1 in the slab tree. > --- > mm/slub.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index c9d8a2497fd6..3088260bf75d 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3416,14 +3416,15 @@ slab_out_of_memory(struct kmem_cache *s, gfp_t gfpflags, int nid) > { > static DEFINE_RATELIMIT_STATE(slub_oom_rs, DEFAULT_RATELIMIT_INTERVAL, > DEFAULT_RATELIMIT_BURST); > + int cpu = raw_smp_processor_id(); > int node; > struct kmem_cache_node *n; > > if ((gfpflags & __GFP_NOWARN) || !__ratelimit(&slub_oom_rs)) > return; > > - pr_warn("SLUB: Unable to allocate memory on node %d, gfp=%#x(%pGg)\n", > - nid, gfpflags, &gfpflags); > + pr_warn("SLUB: Unable to allocate memory on CPU %u (of node %d) on node %d, gfp=%#x(%pGg)\n", > + cpu, cpu_to_node(cpu), nid, gfpflags, &gfpflags); > pr_warn(" cache: %s, object size: %u, buffer size: %u, default order: %u, min order: %u\n", > s->name, s->object_size, s->size, oo_order(s->oo), > oo_order(s->min));