Re: [PATCH] selftest/vm_util: remove unused variables

["David Hildenbrand (Red Hat)" <davidhildenbrandkernel@gmail.com>]

On 05.11.25 23:16, Lorenzo Stoakes wrote:
> Andrew - can we drop this from mm-new please? It's broken the build.
> 
> I get a splurge of linker errors building the mm selftests otherwise:
> 
> /usr/bin/ld: /tmp/ccA0DyGC.o: in function `__pagemap_scan_get_categories':
> vm_util.c:(.text+0x1e9): undefined reference to `__page_size'
> /usr/bin/ld: vm_util.c:(.text+0x2bd): undefined reference to `__page_size'
> /usr/bin/ld: /tmp/ccA0DyGC.o: in function `allocate_transhuge':
> vm_util.c:(.text+0xb90): undefined reference to `__page_shift'
> /usr/bin/ld: vm_util.c:(.text+0xbfe): undefined reference to `__page_shift'
> /usr/bin/ld: vm_util.c:(.text+0xc52): undefined reference to `__page_size'
> /usr/bin/ld: vm_util.c:(.text+0xc67): undefined reference to `__page_shift'
> /usr/bin/ld: vm_util.c:(.text+0xc72): undefined reference to `__page_size'
> /usr/bin/ld: vm_util.c:(.text+0xc87): undefined reference to `__page_shift'
> /usr/bin/ld: vm_util.c:(.text+0xc9c): undefined reference to `__page_size'
> /usr/bin/ld: vm_util.c:(.text+0xcc4): undefined reference to `__page_size'
> 
> etc.
> 
> The idea that nobody uses these variables is simply false, see vm_util.h in same
> directory:
> 
> extern unsigned int __page_size;
> extern unsigned int __page_shift;
> 
> static inline unsigned int psize(void)
> {
> 	if (!__page_size)
> 		__page_size = sysconf(_SC_PAGESIZE);
> 	return __page_size;
> }
> 
> static inline unsigned int pshift(void)
> {
> 	if (!__page_shift)
> 		__page_shift = (ffsl(psize()) - 1);
> 	return __page_shift;
> }
> 
> So this patch just seems to be completely broken?

Grml, I only skipped over the file and didn't think of the header. Nasty.

Note to myself to not trust anybody that they are even performing a 
basic compile test. Hard to believe that's not the case when wanting to 
contribute to the Linux kernel ...