From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F916C02181 for ; Wed, 22 Jan 2025 21:55:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6B5C6B007B; Wed, 22 Jan 2025 16:55:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A1B516B0082; Wed, 22 Jan 2025 16:55:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E37E6B0083; Wed, 22 Jan 2025 16:55:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6FCED6B007B for ; Wed, 22 Jan 2025 16:55:50 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 26919803C9 for ; Wed, 22 Jan 2025 21:55:50 +0000 (UTC) X-FDA: 83036445660.19.036D3F2 Received: from 009.lax.mailroute.net (009.lax.mailroute.net [199.89.1.12]) by imf24.hostedemail.com (Postfix) with ESMTP id F1229180016 for ; Wed, 22 Jan 2025 21:55:47 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=0ncwwt5w; spf=pass (imf24.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.12 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737582948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9vnubpaB1F9qLp8XdalPGwpyWtguqOJ2vRAN4zo/wWU=; b=cBhG+cogGkTnaRo8W7wRwnbEYxVGY9OiOE8Lk3CD0wW/yA/zCvxcJOzEgraYJX3WNXzeun BJCrV05+4ilKFHDaXDBV8T0AG0QmVBR4FpvDDLMhYCp9iqicQefsrYri5s585MXN11wEoT p2E9yubiuoTaXgYvOipHyeWLvXNgoCE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=0ncwwt5w; spf=pass (imf24.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.12 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737582948; a=rsa-sha256; cv=none; b=mP0/auP8aBTNgtzJ5M4Ad+rVq6PfqECwFLNaPc0C06hyOvAguzln//IDrZlKlEP7hljQgg j5Cv3SYNShB3fNIcDJLAiNHd6HzEZ+n7nzz8ePs8YAzzgudY1LxXNY2kRQaC2cLxOLOa9z 1GYkadANnebZDiC9dvutFcgfWUv0uZQ= Received: from localhost (localhost [127.0.0.1]) by 009.lax.mailroute.net (Postfix) with ESMTP id 4YddDf4JXHzlgT1M; Wed, 22 Jan 2025 21:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1737582940; x=1740174941; bh=9vnubpaB1F9qLp8XdalPGwpy WtguqOJ2vRAN4zo/wWU=; b=0ncwwt5wIexP3AJyxPwKkYLghHPfYa7LsjN1VeiY R4FlfKPmXqrV0YxRm5dDodlw8QuX/8XKtf1zUTDmxMnKZ8xtn3oTXU4wHbIT9sRC ZBKYMXuW7FFxnS9W45JEyO6GCWCQQ80OwDFOXEOYY0cRIjV02TAW4nxZ+vDFmYs+ UkQ/ytQx/V3Xmx0iLVS1TjfLQo4ubPqFBWp19ya3AsH4SunirnlA2rE3A84x6ZMv EeVwdd08Ua0iqY56Md96H5t0Y/d3b9xN8cKxEzIovtra5GN4w9JM3NzJN+0fsCw9 cq+T0pPvmv6jB3+DvwECiA1bUjmt44O3nQCyKj8boX8RLQ== X-Virus-Scanned: by MailRoute Received: from 009.lax.mailroute.net ([127.0.0.1]) by localhost (009.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id 0PLaFp1YPHfk; Wed, 22 Jan 2025 21:55:40 +0000 (UTC) Received: from [100.66.154.22] (unknown [104.135.204.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 009.lax.mailroute.net (Postfix) with ESMTPSA id 4YddDP6JgnzlgVnN; Wed, 22 Jan 2025 21:55:33 +0000 (UTC) Message-ID: <2b2dfbf2-7d17-4576-b0fe-2e13d563cf47@acm.org> Date: Wed, 22 Jan 2025 13:55:31 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmstat: Fix a W=1 clang compiler warning To: Ivan Shapovalov , Andrew Morton Cc: Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Pasha Tatashin , David Rientjes , David Hildenbrand , Vlastimil Babka , Joel Granados , Sourav Panda , Kaiyang Zhao , Johannes Weiner , Konstantin Khlebnikov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20241212182425.ad1f7894cd0f00b2e34bbaed@linux-foundation.org> <20250122015818.3308696-1-intelfx@intelfx.name> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20250122015818.3308696-1-intelfx@intelfx.name> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: F1229180016 X-Stat-Signature: fzixcu58twkhgjzk1emjbcjsuehrnw8u X-Rspam-User: X-HE-Tag: 1737582947-851448 X-HE-Meta: U2FsdGVkX1/2M8UmKHA3ElUGOyBk8FliaEcpxA7icUiigd1VV2iN/gGWTdoIH4+chVZQ7GKiE2CsDY+sjeytsRTGUpCTcRm8/ZCZLCMLClTZnfLZ/bPou7UgcIEpP7jtqFbeI8VhRCbFQYvuNYb2jwaPfwQmDE+djaMT0iffqBTV31F3/KUo5PSd7KjoD0G4mJ/W25JWUTZROJT0x03XfQeyTjEYo0TqYHt0OnexNS9uo/nnxsBatLH1giOHTYpkt0gMmY0bPcnDojux7eeEL7euw8W7dRciKcFzEWhhABZRWgfSgZb4NKXlz0deUGELfseEBJF6obOi9eGV0XN9ot3vnx2rP1N+RSrlGzXcjZYYCzSUXlH6glV8BNz9vAODHISoycKsKrUbJmx6baMqFVrJ9USxf1N1MugnoeU2hE2LWoVl/vp20w1Jy3Ua8YTt3xm7Yts4lQDx+LyS8wdZFsUyEavamhN3Ug4jkoMSrXoV66miDAU3g0PFmNoHIUJhc4q87W57MrJn5CrnyJ4s3v3DEIIKxzzR0ks1MMvK02FqzbGxGBTPa0fDwXDJMxC/RysOa6VMGo++7waJwMxcRtbjlMvfM2O5hBg030BO9LL7+hAjJ299zpjABnoKv5DEwJRydNpR1UyLv234mFD5PEojGUapoBxjOZWGU9JJUv8z1w0G4KoF3H8eIijAwTXn21TQL5O8N0xZjjKuz2xKndyo7Zo1FqhWa2d6B6fVemBPIP3YGLXRUf45V6tQkx0Ylq8D9LcVwu2J0ILG/8jL9P93qS6PhEfRnR1e2ztOJK7TLIykV8EiGbLz180V9b53T97wRsqjkT9PpqEJfwaW1t4mHdonlBkgVbld4JcLhWRxZYcFbsV149yirZqtvjZE7BclCvN5FMIdhcIh0O6L38C6ogxkU3Zl45ncL4cyAO+bSSVVPz81CrvBojb+YTvNy/qN36kfHAMfvNVCOw8 1sVqBG82 YB7UiHSxUHjjdD8TD1ElLo6iM4h7HqA137tHQoKPUvg9rj2fsvpsJD8SQt6nk3OUqFW/5wdUo6gEiuk1l84DQv/fMg5OKclLwl5Grxxjca7BcSuGGVV7E6KTzMfqkjwyNk1Ur4g82tmW2+J29Ruqk2Hpy6K7FyPG5woM/TRH470BG7wMRirAYF1WzNC6DqQfKXRutKVLOk5qLst2+LGe6jZuXrFsxQetmdcG4OSLb36hH6kQsj/r99SqKCDN/iIuscP7StCi1luyIFASWIz+znGIYs+H/7P2qwHMK2HxvUJPvvBczIxMatLJmpjO0cCeNG0xe6j/mPRY2Ang14b1qIc0Nj9rCAbQ5mW4kHr8ui3ysDuO57ueA1jZzRJilF4xSqXeMqpB5ocJ8ESBdY4eLNOSy4QoweC37KZqv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/21/25 5:57 PM, Ivan Shapovalov wrote: >> Spose so. One always suspects that adding a typecast is a sign that we >> screwed things up somehow. The relationship between enums lru_list and >> node_stat_item is foggy, and I'm unsure whether this is the place to >> make the transition it. Perhaps lru_list_name() should take an >> `unsigned int' arg instead. > > All of these *_name() functions do seem to expect arguments in range of > the corresponding enums, so perhaps keep those args typed as a form of > self-documenting code, and do this instead? > > [ ... ] Please take a look at https://lore.kernel.org/linux-mm/8640d744-d182-474b-9059-204bcea47d1a@acm.org/. I think the patch I posted on December 13 requires fewer changes and no type casts. Thanks, Bart.