From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 586DAC433FF for ; Wed, 14 Aug 2019 23:11:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 140F52064A for ; Wed, 14 Aug 2019 23:11:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="PuOPsYZx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 140F52064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 92F886B0003; Wed, 14 Aug 2019 19:11:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E0566B0005; Wed, 14 Aug 2019 19:11:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F5986B0007; Wed, 14 Aug 2019 19:11:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id 61B1A6B0003 for ; Wed, 14 Aug 2019 19:11:42 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 142E68248AA5 for ; Wed, 14 Aug 2019 23:11:42 +0000 (UTC) X-FDA: 75822582444.05.death98_2b98723644d0f X-HE-Tag: death98_2b98723644d0f X-Filterd-Recvd-Size: 5034 Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com [216.228.121.64]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Wed, 14 Aug 2019 23:11:39 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 14 Aug 2019 16:11:49 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 14 Aug 2019 16:11:37 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 14 Aug 2019 16:11:37 -0700 Received: from rcampbell-dev.nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 14 Aug 2019 23:11:37 +0000 Subject: Re: [PATCHv2] mm/migrate: clean up useless code in migrate_vma_collect_pmd() To: Pingfan Liu , CC: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Mel Gorman , Jan Kara , "Kirill A. Shutemov" , Michal Hocko , Mike Kravetz , Andrea Arcangeli , Matthew Wilcox , References: <20190807052858.GA9749@mypc> <1565167272-21453-1-git-send-email-kernelfans@gmail.com> X-Nvconfidentiality: public From: Ralph Campbell Message-ID: <2b208666-17b5-0f67-d425-b622c97d688d@nvidia.com> Date: Wed, 14 Aug 2019 16:11:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1565167272-21453-1-git-send-email-kernelfans@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1565824309; bh=LcX0xyfGgOmYGuz4B5wFSysH8VJd6mYYunA+2mz8sgU=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=PuOPsYZxCuhIerZWsb+K72kRksCiGtJ5O9QpOhbSYMQcta4yA6K5YNmt4zeugCORH wNWR6Fq9nU/oYgrqSfLeV6ZeN1WC0alAKtxmIz8h/yfUO+0zElW0tklqCOA7FQn8GM WfAACqLYC86kZe/u5Z0CT5in2Hz8WIruFeafZdtmHhIROO7VvJCezPvjqGq5s2V+n/ KxnKUHZkNZESHRTeI0TB8rFXVrRcb5ClxwfT9HQBddKn9LAIHz9bC2tKGrcOxq8lD2 latqICSK2HTzPoKIAnRIG/XO/62ojbQFM7Ha8wD1LA8nWAduC3/olbbFbCWtRwHWOx rDH6jGjTlXvSw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/7/19 1:41 AM, Pingfan Liu wrote: > Clean up useless 'pfn' variable. >=20 > Signed-off-by: Pingfan Liu > Cc: "J=C3=A9r=C3=B4me Glisse" > Cc: Andrew Morton > Cc: Mel Gorman > Cc: Jan Kara > Cc: "Kirill A. Shutemov" > Cc: Michal Hocko > Cc: Mike Kravetz > Cc: Andrea Arcangeli > Cc: Matthew Wilcox > To: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > --- > mm/migrate.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) >=20 > diff --git a/mm/migrate.c b/mm/migrate.c > index 8992741..d483a55 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2225,17 +2225,15 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > pte_t pte; > =20 > pte =3D *ptep; > - pfn =3D pte_pfn(pte); > =20 > if (pte_none(pte)) { > mpfn =3D MIGRATE_PFN_MIGRATE; > migrate->cpages++; > - pfn =3D 0; > goto next; > } > =20 > if (!pte_present(pte)) { > - mpfn =3D pfn =3D 0; > + mpfn =3D 0; > =20 > /* > * Only care about unaddressable device page special > @@ -2252,10 +2250,10 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > if (is_write_device_private_entry(entry)) > mpfn |=3D MIGRATE_PFN_WRITE; > } else { > + pfn =3D pte_pfn(pte); > if (is_zero_pfn(pfn)) { > mpfn =3D MIGRATE_PFN_MIGRATE; > migrate->cpages++; > - pfn =3D 0; > goto next; > } > page =3D vm_normal_page(migrate->vma, addr, pte); > @@ -2265,10 +2263,9 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, > =20 > /* FIXME support THP */ > if (!page || !page->mapping || PageTransCompound(page)) { > - mpfn =3D pfn =3D 0; > + mpfn =3D 0; > goto next; > } > - pfn =3D page_to_pfn(page); > =20 > /* > * By getting a reference on the page we pin it and that blocks >=20 Thanks, I was planning to do this too. Reviewed-by: Ralph Campbell