From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f200.google.com (mail-qk0-f200.google.com [209.85.220.200]) by kanga.kvack.org (Postfix) with ESMTP id C51E66B0038 for ; Fri, 3 Mar 2017 14:11:00 -0500 (EST) Received: by mail-qk0-f200.google.com with SMTP id a189so150778490qkc.4 for ; Fri, 03 Mar 2017 11:11:00 -0800 (PST) Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com. [209.85.220.181]) by mx.google.com with ESMTPS id h68si9982740qkh.329.2017.03.03.11.11.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Mar 2017 11:11:00 -0800 (PST) Received: by mail-qk0-f181.google.com with SMTP id v125so12126620qkh.2 for ; Fri, 03 Mar 2017 11:11:00 -0800 (PST) Subject: Re: [RFC PATCH 11/12] staging: android: ion: Make Ion heaps selectable References: <1488491084-17252-1-git-send-email-labbott@redhat.com> <1488491084-17252-12-git-send-email-labbott@redhat.com> <20170303103304.nxfn7zlccx24b3xq@phenom.ffwll.local> From: Laura Abbott Message-ID: <2b0c35ce-be88-526c-e0ab-1707c191260d@redhat.com> Date: Fri, 3 Mar 2017 11:10:55 -0800 MIME-Version: 1.0 In-Reply-To: <20170303103304.nxfn7zlccx24b3xq@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Sumit Semwal , Riley Andrews , arve@android.com, romlem@google.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Brian Starkey , Daniel Vetter , Mark Brown , Benjamin Gaignard , linux-mm@kvack.org On 03/03/2017 02:33 AM, Daniel Vetter wrote: > On Thu, Mar 02, 2017 at 01:44:43PM -0800, Laura Abbott wrote: >> >> Currently, all heaps are compiled in all the time. In switching to >> a better platform model, let's allow these to be compiled out for good >> measure. >> >> Signed-off-by: Laura Abbott > > I'm not the biggest fan of making everything Kconfig-selectable. And the > #ifdef stuff doesn't look all that pretty. If we'd also use this > opportunity to split each heap into their own file I think this patch here > would be a lot more useful. > > Anyway, no real opinion from me on this, just an idea. > -Daniel > My idea with the Kconfigs was that if platforms didn't want certain heap types (e.g. chunk heap) they could just be turned off. I do want to fully fix up the initialization better as well. Thanks, Laura -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org