From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5944CE77188 for ; Tue, 14 Jan 2025 13:50:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E14376B0085; Tue, 14 Jan 2025 08:50:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC4696B0088; Tue, 14 Jan 2025 08:50:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8C4E6B0089; Tue, 14 Jan 2025 08:50:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AA3D86B0085 for ; Tue, 14 Jan 2025 08:50:20 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 51FCE160A1E for ; Tue, 14 Jan 2025 13:50:20 +0000 (UTC) X-FDA: 83006191800.18.30301AB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id A861D1C001B for ; Tue, 14 Jan 2025 13:50:18 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B3WYSv8m; spf=pass (imf21.hostedemail.com: domain of joel.granados@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=joel.granados@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736862618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s1d85wir01mw0IeEKvAHM7amNeai/tfH3xUGISkfSwc=; b=hZ2RETMrE5MVPgIA+pK4jMRKGvOYbt4D9Dc0LKUXdIRfc7NjfwmyTikw1jfqmFN0184UFd 9/2tqSB7jn1Q/4KgaUIEUrJYjQEqjn5CTWvNvO0OndIgHU8D7mUmEPtPvr5utwoJt9hVUc mPi4gNfuKKP7/bvm5vJMFvov8ZWGgro= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B3WYSv8m; spf=pass (imf21.hostedemail.com: domain of joel.granados@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=joel.granados@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736862618; a=rsa-sha256; cv=none; b=cDiAHtZGnYtcE+MM+klfaC2wK8A5picAW7AgiKHaLRIWuZ3QwzJZ8b8hMQrIidQMqMa4WD 1i4IwdnbkAYy4+8GBUzB8HRS/VqnNi+PbxKAIFJxA8uOffXpmDUvVD89vs5xQpupb7p1n8 kAViGG8/HqugFd5NfA/gZDho0krHgSY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E010B5C5845; Tue, 14 Jan 2025 13:49:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6FC1C4CEDD; Tue, 14 Jan 2025 13:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736862617; bh=E9WCKWqZDdWrhuOJ8T3MRR+Wdu7159qHRnRM7zfR6Ps=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B3WYSv8m4sWSylXp9W3Sf17zPbMaNvU2ichDqWJ/pV+WhqBkiLI/x0mixcZekP/aV 7IPatKNy77Ep4aVGaq7/e5nrblpErKiiUZ0utc/rib3Bb7eqQylyqJOPn+a5aoJ7tS 9V3/DBK6XIWKUe4dkKp3i//29eH+tgB4F5QfCjIbsRhJjyAxbB1ba2DCm6IHk8nw2P biqr9P1Wy+gXBaNqjgJGV/r23EWsD8jZNVMdkIPnxyCBU1x/TMKREi0xDCXR0DRQIH PLualSGnHYpy1D1fcUUvDGZRtkr+MQKg+IlH4/HDClH4Ly4UOEfuXu0coYhf2di1Dr Kcz4QrkfD9Z0w== Date: Tue, 14 Jan 2025 14:50:12 +0100 From: Joel Granados To: Kaixiong Yu Cc: akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dhowells@redhat.com, haifeng.xu@shopee.com, baolin.wang@linux.alibaba.com, shikemeng@huaweicloud.com, dchinner@redhat.com, bfoster@redhat.com, souravpanda@google.com, hannes@cmpxchg.org, rientjes@google.com, pasha.tatashin@soleen.com, david@redhat.com, ryan.roberts@arm.com, ying.huang@intel.com, yang@os.amperecomputing.com, zev@bewilderbeest.net, serge@hallyn.com, vegard.nossum@oracle.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v5 -next 00/16] sysctl: move sysctls from vm_table into its own files Message-ID: <2asuqwd4rpml6ylxce7mpz2vpvlm2gpdtwpp4lwuf4mdlylig2@dxdj4a73x2sb> References: <20250111070751.2588654-1-yukaixiong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250111070751.2588654-1-yukaixiong@huawei.com> X-Rspamd-Server: rspam05 X-Stat-Signature: wh4osf4ukc5j43bfakm8cynhcrnt1hty X-Rspamd-Queue-Id: A861D1C001B X-Rspam-User: X-HE-Tag: 1736862618-265112 X-HE-Meta: U2FsdGVkX1+fTJcGmQbFYtsyF9ZcvBKOjyJQ4kcUyhD5EWKY+qb7YKITc9Y9SgIY/6QVTUmc1Tdazf+GMk+CxTNXqLU+R2i77fhqVsrnMScT6ld0mwOE37qNPzPO91v+1Hiy4pd1iZUponmW/Ca9s4DBzR1gvcKY0ihaiQgRbbEidRliYbWQtUBbxfR8jxsyipv8zllqo5uVs5HYW5h7GZeOQmyi6luC9oVzX+fZJh1JkSjrgn2WBuD/Njqsv6vpImIsiX2G8RIMSTfuI6oyWYnK1IiyhHX66bIyepVOOLYZtdYgJZAxnMW9sUirss9cvryQRw+86UKBgmgsdEGJOAZqIhvDK+9VwIWVpSgXtGaqfwkZF4sXiOlTeg3OlmMMCQXVjItdvKU0iwQDJ+iTBFfWmNZUcMioFqphptsWbmyEQmaBjpaxKwelZ7DtghU7Yqb2qDeUn82DU0JFbOR3UvNY4QEff6juwLToHsOFxd/Xh+jJRePoKwxsraeBEFg4JVjE/Zi/uZ4DaDI7wXhoSowVSjQkcToVSkVOX7r3EUQ7zJt1ZQuoLGpaGMAnRVivC65oNfjmHmJpvyoJYq/dELetMDKrShmq9JJAwsXxYjptRV9dTfYwq+UqZee9xBUjqIAY8vnbVnXBjQvunlPBdXrEIVG2i+fpqt7iYPFopwxAlvzvvwvNS2EWtsqcd5pvmysqsVOS3DWgaMa1EUNfvoPyTrCJPwrd6o863CjeUDHFCafJAOm7wjhoqtdQfRURNa634gGzud7j9IKLQFPheQ6lzfR0rnzdvV23PlzxaLThW75b4BNvu2u/sCU9XExuo5j1f+UINSgeI4CjJ1PEJWdwnIM6BjGbCDE9E5ouq1MHi19zFI3R2k1hXgZuzsXj3HCr+W2uM7MuXuK5o2KvOiCc9dEAXpTd4XnQ1YdKnV7ytsJ0Bb/8cqxuI9LCV2DXmt3ytnDbefRpJQ0J3mL BD16wzXO 2ziCvEg3BB5eRVEafeYyhQYSlIDxuI3w4wLn3kmKIFLFr8WoCToUsBp+iu9qRhMiY9dX4RtJ7q0WHEiOlCX4hih3DdfM60i6kfZQBlfwUqjedxMZLsCf9TBzw9B2mRE8z4ivYe1+nMucEnrkYc7e5kkAUTG9KJEq5/CvOX104+7greohtyY8pdSwx6bnQUwTw/bxJlUoHWjnn3n0xZgq6X9kFqQKdAwOo7Vexftk28Bc06kHu+jQI5lLPntFG6ktSC9Bd8FIL3Zd8pmJYqUbY7uWgH1KhnJ6jPek+UMWSDJ2ZUFY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jan 11, 2025 at 03:07:35PM +0800, Kaixiong Yu wrote: > This patch series moves sysctls of vm_table in kernel/sysctl.c to > places where they actually belong, and do some related code clean-ups. > After this patch series, all sysctls in vm_table have been moved into its > own files, meanwhile, delete vm_table. > > All the modifications of this patch series base on > linux-next(tags/next-20250110). To test this patch series, the code was > compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and > x86_64 architectures. After this patch series is applied, all files > under /proc/sys/vm can be read or written normally. It is looking good! Here is how I think we should move it upstream: 1. These should queued in for 6.15 instead of the next merge window. It is too late in the current cycle and if we put it in now, it will not properly tested in linux-next. 2. I am putting this in sysctl-testing with the expectation of pushing this up for the 6.15 merge window. Please tell me if you want this to go through some other tree. Thx for the contribution Best > > my test steps as below listed: > > Step 1: Set CONFIG_SYSCTL to 'n' and compile the Linux kernel on the > arm64 architecture. The kernel compiles successfully without any errors > or warnings. > ... > mm/swap.c | 16 ++- > mm/swap.h | 1 + > mm/util.c | 67 +++++++-- > mm/vmscan.c | 23 +++ > mm/vmstat.c | 44 +++++- > net/sunrpc/auth.c | 2 +- > security/min_addr.c | 11 ++ > 23 files changed, 336 insertions(+), 312 deletions(-) > > -- > 2.34.1 > -- Joel Granados