From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B49CDE00D for ; Thu, 26 Sep 2024 14:31:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E1586B0096; Thu, 26 Sep 2024 10:31:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 991506B0098; Thu, 26 Sep 2024 10:31:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8802F6B0099; Thu, 26 Sep 2024 10:31:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 67F166B0096 for ; Thu, 26 Sep 2024 10:31:44 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 076F81A1921 for ; Thu, 26 Sep 2024 14:31:44 +0000 (UTC) X-FDA: 82607128128.07.A249015 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf26.hostedemail.com (Postfix) with ESMTP id 1F739140022 for ; Thu, 26 Sep 2024 14:31:40 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="lilAc/f7"; spf=pass (imf26.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727361065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VVJYTxtSzWVpATahcYxmpuPOiL5PESMwLfpHvkuF5jE=; b=fCVjz2r4Vp3pZ/C3kZqpu6u4nQEBvbCyUN8gDG+CT4xZlfOIjIL3WACWQWg7EBTn5jTsFH gZmx0TX5LXodzRlQq6tSNfex6NwMFNtXCaxVT2iprX00erOS6flGAx1Ap/jid6aE0XDqPa b9BCzQU3JyJWSZQtlrkaT5L9kFRjj1A= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="lilAc/f7"; spf=pass (imf26.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727361065; a=rsa-sha256; cv=none; b=6mTMtYCKWjtJltDuVz8ffZ6zVHFON0GxXdObnIeAxAfeQzyVh2ltTCSHW/4Ssb/aQpLkLb 0JVnveZfrOjgb70UYZB/pBGy/FU/V1kGelBCAWrJkf6RIZ6jaWofWj2Mx/Zue1V2Lnd3z0 AODIXtIp3n8r2unWNQBeVkZLtsEyHq8= Date: Thu, 26 Sep 2024 07:31:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727361098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VVJYTxtSzWVpATahcYxmpuPOiL5PESMwLfpHvkuF5jE=; b=lilAc/f78KPE8VqVEex2SRH7+nDt3JBT2Fd4HxkiXSMWHxkpyBriXeve7BmLnNsKB+UpQe kxyrbqn4mQMe7liZ1ppMjvcpXgNJ2OP9VEzUJXvDmPtcWStv392oEuJEwCPr3Bc90mBZ9P GkzQmgnNtxvBu76NMgIP4zdycQ4d5T4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Waiman Long , Michal Hocko , Chengming Zhou , Qi Zheng , Muchun Song Subject: Re: [PATCH v2 1/6] mm/list_lru: don't pass unnecessary key parameters Message-ID: <2apdbfeghgmbrx2y75xadeu5exdfmphysbglnfy6kjclulk74x@lwi6btgbluip> References: <20240925171020.32142-1-ryncsn@gmail.com> <20240925171020.32142-2-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240925171020.32142-2-ryncsn@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: 3xxearqa7u78z8stzfq4gu4mz3fu17ns X-Rspamd-Queue-Id: 1F739140022 X-Rspamd-Server: rspam11 X-HE-Tag: 1727361100-81948 X-HE-Meta: U2FsdGVkX19cmfS/B1Ane4yLciW/UEe2zVlZdZGp/M/8b6smz6y5iQ/llBNs9mQn09TOu+UgYyqqor4CLox0Gr4wZptmgybMFWz7OLj7V5543vIiYmkK1auO192IzM5n6kihaIZmlIB47X7em92ZpYulX4uIrzL3Sd+MMOntF6HyCuqKRvi5fCtk36xdSUNpNg5olCpF2/P0hFRedVNvN3iLnVL1oApKuFDx64UcfpnJklh6WywkIMpehtVJOLRD2eFlx33QfZXuFQV/mWAx1CZ6k75wc2RD8eHQGvj7x8GcRcVTH+J8tcB5W34ijo5DbfCgusVRnkI0aCS7x8Tw0s2bG2rAyjjdfe0DIbyCNRX8wXwlZh07zwTD6q7qN5wzsgYTAWmW7i4dsYGpZOw5OGHySOXpcsffj09HfurqcZCa9vWqjmv1s0IfkoBV9J097RPkqAp1ROFADKb7G05Go1F6WmZ49OQerrg2xuthoZXREsUA3bCU1xl88p9QwVovyUoQyKdC3Dm37N4UhXtezYAatU+EhwHIjVgVMrKNb2N3n4Zj8NdTELkVdMjDYi4ofZMFfF6DfchLLUHNXzLIIeVoqov2pGOpoKCIgDbnre70M1wuddtKt0QzfhabwEyr5MeOgbr9n9SEXrx5NxX7O2BYggDTJ0i4gcdzFtdvlZTgr7+xsb097u2dlO4iH1h9lFOUVm3Mtx4BZFisARm8s7/WimBnfnn+HXXjO3aYsRHllQeklycqCcd5u/cKcbw3wMZ+fvwafsnDGJrK/WnfF9Z+MogILy5+BDl8FbX69S1tOilR09yt8XBuEGjXSjyRyMNVtaX7hHuADDqRZjQfsVUBMWypuCnEyMBM2jVUJNY8v0RpzvJ5FNys95ToBM6xkiXKDK8A1uysKzf3+YYLLDTXXl3/jp9QTFHdfpLrmEXTxrJ0V+DXivtBQw6A0nL+8ZUyVuqnx0jJl3TlIr1 yXiRQRsk kKo7JQtpzRrcewy2DgXGkD08vg/d6abZP4wSb3nc9K08eYwOvgOi44bhreizp11FMaEQebbG2/vTGqV3qUlUo5TaoIRx65YrafKB7oLPpSDn2Ppy+P5Ug52arXXFBk2ACQ/fYJ8O0i+/du6pWLtC6hFolfGan3P1sDEnK8elKASQlvkf75KtOLFeTiU9HHbTbGcl8p2RHTI7OnHAzWXisM/h3nQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 26, 2024 at 01:10:15AM GMT, Kairui Song wrote: > From: Kairui Song > > When LOCKDEP is not enabled, lock_class_key is an empty struct that > is never used. But the list_lru initialization function still takes > a placeholder pointer as parameter, and the compiler cannot optimize > it because the function is not static and exported. > > Remove this parameter and move it inside the list_lru struct. Only > use it when LOCKDEP is enabled. Kernel builds with LOCKDEP will be > slightly larger, while !LOCKDEP builds without it will be slightly > smaller (the common case). > > Signed-off-by: Kairui Song Acked-by: Shakeel Butt