From: Shakeel Butt <shakeel.butt@linux.dev>
To: Kairui Song <kasong@tencent.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Waiman Long <longman@redhat.com>, Michal Hocko <mhocko@suse.com>,
Chengming Zhou <zhouchengming@bytedance.com>,
Qi Zheng <zhengqi.arch@bytedance.com>,
Muchun Song <muchun.song@linux.dev>
Subject: Re: [PATCH v2 1/6] mm/list_lru: don't pass unnecessary key parameters
Date: Thu, 26 Sep 2024 07:31:31 -0700 [thread overview]
Message-ID: <2apdbfeghgmbrx2y75xadeu5exdfmphysbglnfy6kjclulk74x@lwi6btgbluip> (raw)
In-Reply-To: <20240925171020.32142-2-ryncsn@gmail.com>
On Thu, Sep 26, 2024 at 01:10:15AM GMT, Kairui Song wrote:
> From: Kairui Song <kasong@tencent.com>
>
> When LOCKDEP is not enabled, lock_class_key is an empty struct that
> is never used. But the list_lru initialization function still takes
> a placeholder pointer as parameter, and the compiler cannot optimize
> it because the function is not static and exported.
>
> Remove this parameter and move it inside the list_lru struct. Only
> use it when LOCKDEP is enabled. Kernel builds with LOCKDEP will be
> slightly larger, while !LOCKDEP builds without it will be slightly
> smaller (the common case).
>
> Signed-off-by: Kairui Song <kasong@tencent.com>
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
next prev parent reply other threads:[~2024-09-26 14:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 17:10 [PATCH v2 0/6] Split list_lru lock into per-cgroup scope Kairui Song
2024-09-25 17:10 ` [PATCH v2 1/6] mm/list_lru: don't pass unnecessary key parameters Kairui Song
2024-09-26 14:31 ` Shakeel Butt [this message]
2024-09-25 17:10 ` [PATCH v2 2/6] mm/list_lru: don't export list_lru_add Kairui Song
2024-09-26 14:32 ` Shakeel Butt
2024-09-25 17:10 ` [PATCH v2 3/6] mm/list_lru: code clean up for reparenting Kairui Song
2024-09-26 14:34 ` Shakeel Butt
2024-09-25 17:10 ` [PATCH v2 4/6] mm/list_lru: simplify reparenting and initial allocation Kairui Song
2024-09-25 17:10 ` [PATCH v2 5/6] mm/list_lru: split the lock to per-cgroup scope Kairui Song
2024-10-25 21:13 ` Usama Arif
2024-10-27 17:26 ` Kairui Song
2024-10-28 13:22 ` Usama Arif
2024-09-25 17:10 ` [PATCH v2 6/6] mm/list_lru: Simplify the list_lru walk callback function Kairui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2apdbfeghgmbrx2y75xadeu5exdfmphysbglnfy6kjclulk74x@lwi6btgbluip \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=willy@infradead.org \
--cc=zhengqi.arch@bytedance.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox