From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CCEFC47422 for ; Fri, 26 Jan 2024 09:37:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 990B46B00A0; Fri, 26 Jan 2024 04:37:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 91A6C6B00AC; Fri, 26 Jan 2024 04:37:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 795386B00A9; Fri, 26 Jan 2024 04:37:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 66B5D6B00C0 for ; Fri, 26 Jan 2024 04:37:01 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 38F94C0E9E for ; Fri, 26 Jan 2024 09:37:01 +0000 (UTC) X-FDA: 81720958242.07.6D21077 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf17.hostedemail.com (Postfix) with ESMTP id C464840019 for ; Fri, 26 Jan 2024 09:36:57 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf17.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=jirislaby@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706261817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XGLeS98hA2fBZzgTNbeCyAi11v+/7WOKbg0CpbQOuXc=; b=4bLqCa2TPd4xszzDGsxi3/u7R2MiEe95nL0cTSw7c6W1opkFhVmwvAWS3Yq+yr2NVcOpjX KLpugGYHCbsuBFoGUFQuketNgpqhMEPzEOv9kqgxzGhqcY8t8vPmDANPGdDSSLFEvg8xh3 zSUYa9vBIg80FCBiDpEggAnYaNZTMzk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf17.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=jirislaby@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706261817; a=rsa-sha256; cv=none; b=K5jGrzk8vTjCzXNxUWkTy6o/wOIlMHwwsT6l3Szms98zCNNX/UagrPRlPCqCNvZ8iCSavt UEU8Wzu4hWfQa42wMJKdwkHOeKvPIMLn/QyoiAttZzktPsmnoJZfcIPoZEdipIZXC8E58q YPelELsuyD9TbfAe9IDhoM0p6VPD2Ds= Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-50ea9daac4cso166724e87.3 for ; Fri, 26 Jan 2024 01:36:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706261816; x=1706866616; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XGLeS98hA2fBZzgTNbeCyAi11v+/7WOKbg0CpbQOuXc=; b=EEQBEaarxZgVlJhdqI8EvmWyIj9a4OuGZDIRehXxhbNhePVrTclkSsL/nOgBsMKbqf 9CEc+7mO3I6kh+qoxtpYAsjaEX9sAr8iTd9+VFtp8Kg74nMIPxVDU2oGhRr1sG81geZ0 oiNTa7DKhrtFEap0xvG+FBvhhnjJMMh/h2je08wcTEhB8LTR/V5D97wFyGG5nDs7I5Yk I1dXpQQwB3js4HzU7TI/mJybKbOE+kQk2UvfFWX4I911qYPdUKHj0r/kZf/CxEk7DAd6 dKHhbBcuqhuJ8HbIl+mZ/KTmRxss+bU2Yn1vHykfU5hI2wHFSyBJKv1P8bnkvgyZd4hg rD7Q== X-Gm-Message-State: AOJu0Yw3qv4TKyexx3CKFqii/hoCEs+9K8T+ShYXafwfkwxFt5AQzCkT /0b/YxhS4y25YDmySTFUAdiILWyNGJ0I/oOFo38X/ZSZ3pSo93/d X-Google-Smtp-Source: AGHT+IFeeZY5dYUyGRCCjaAx/k+3kGFWFkxW2HDq9HUe32iVA/kkbb4wjPwcGETQvCeY1HhWx471QQ== X-Received: by 2002:a2e:a36b:0:b0:2cf:429f:7fbb with SMTP id i11-20020a2ea36b000000b002cf429f7fbbmr538120ljn.72.1706261815777; Fri, 26 Jan 2024 01:36:55 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id o23-20020aa7dd57000000b0055c8a30152bsm405245edw.83.2024.01.26.01.36.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jan 2024 01:36:55 -0800 (PST) Message-ID: <2afa54e6-90db-4ae0-a21c-78e5051aa83c@kernel.org> Date: Fri, 26 Jan 2024 10:36:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit Content-Language: en-US To: akpm@linux-foundation.org Cc: surenb@google.com, riel@surriel.com, willy@infradead.org, cl@linux.com, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Bernhard M. Wiedemann" , Michal Hocko , Yang Shi References: <20240118133504.2910955-1-shy828301@gmail.com> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C464840019 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: k9b3jkibgt6tiqsd1czaohsj79tcysdg X-HE-Tag: 1706261817-389185 X-HE-Meta: U2FsdGVkX19slZYN9Y5lmUzOunaSDW3aWa6hdbvhTO0/eVSsz9E0GKtD2vPBDC2rkEt18uYuILc9HDunrJhTCDdLCBfm9go5/7JmhZwhU1mWUHcoCm0Lw5YfCYiyBU/q/HaiPJE1w0Hym5nYj0U5ywghMac1/vEiZBAZyn2UCCv8USxtins1+b4+wqehR/H/9WI1bE4Gv4q4fzpB+NfTeFRfZhs1r8wFVn/pFdM60AykqptDHdMQR7M4Tb0pilcrUDnqPsWWWpkRj3dBrkzUTgcx69ou6/AVEFf1QyWaI6Of+27snqopQJYf+sBEVzCxNvurgiQGx9pAoj6U0QOrInWZRKZKL/NsqgKwMmrrtfQyN9yAtEOSOl9A1JiG4Wj2ljqHMciVmUvG3VkzRjPbiLwbDBDTRL+NBclqe8LGeD6uSKZetowL898YInfgDsAGIhTlLfZtDgeXcHOsGEH3vNb9xQE3dh/h8/ldc9BReH7n7ittFS4GeSXjV+5Y3JFlUGhYkli2zMYGHy1kjp4xnDiDniDIn13XmIRGOytajdT5DH8jg3h/LPgAvPK/m6ESQxIFEKV4qLeBqd0FSr2AXAFr7nojZWrdsducS+puOsG87HU2mP4lO5UF1BdmVGVlErdfTrgdQYCqmNLx6FXHNYCZCZXbF+PRoO5Vu/JUarJVou6MB4uVZQ64nlH1CNaYenp+aKayLut8RHhDQfybWnUX2WCIWqBgAhmIzlkD4K+kXaWgazMmIqySAC4XkbdYafpYzCJh90VTkh6Xd4pXZXenweE5XKKI7cgNZLlZV62eZjr8lyefjzjnrup6+CtD8o7mJL07tWC14eByv7/s9wU2bqh5WXpTR0w+u4k24Es5cgk1alQcLvTlXEkFQSnCt3dL1xf7wj79jV9KWxA+yl7okpzEKH+1Jvimj4e6VJyvAXW0zaIFonRtHJJ8dqBpxHdaSW92YJ9atHHWnfb NrQM6q/y OJewziJdel/a/l5kTb/kE9pmmoq4mkM5FZAHtNfziJpCO7cTO851MKyn41Aj190s8/1I4dfk2gbF7B/PnAeS+8XjwwtSkIK4aMmKhg1dpqhel/JqDB70kI8wRgsr6cqijsD89GvRtbpzBtTBDr6al6e8dQa4NcfSNvelCwvYFmqQtK2CB2VafT8ni6ee+/la6tsaFI0wNP7om1wB09q7HYQf5nw06N2Y+NnfySmKjMKdpfOeR+uB9XL3bgRLUxpbDIGvRdOwzvWtVNkJ8mkqu7+zPqAKdimFKx9Mps+qWqxQeVoj3zXCayHwbZkJH79p34RvYWBsTPY0vvYpC29lZpKmIIcF2iMMQXqkszvlFkcr9/JZIOwCwPjx7DGDx6O1+1Hw2EhsViVee15BfcY1w7Dhd9zK9JpUgZp5itGZk9Ah4/yRdlVMYNXiqWLl5HcHV9n597iwJp3K37KBMQUnW1uIh4TJpaprRPm5bOC+mx2sTtPrmme7DAK6RR6A/kKb7krFalMw5/dPNMKtS9rtdvY4RwxZaEZyFMVuLeADhPbinZz6o8e6v04kfofVBmJ4oNTt6Kh7w5MkH7XVKQdZHEZ0dXtW9/kWxpKVVhxsb5m4wJ5G/50VMrwfFN9jnkgopm8gMMr+Z1XL0imZ+OXXwuVY3BBhAPOf9W+VGRGHbQoghXq4N7VrK9k8kc9aMHqDPRtA8u6SPI4ZhZO4AnWgSJlMr2ZfEA0UvHyPo3wjKkrDCb+gM2dUVGMgtyTg/+e+5afRi5fEPAxhdO7EcELIy3H06adYAQBoVWIwfDWc9DteHqg5q9JDqZ9HoXzId7nFkiBh43eFRT6WmFluppJNpIlHcKAT81LGzwq+aNltAsCuESuuiIcHqseDypvxIr9QsX5kWZzUl+56/Y1eKJ2ymkslngrMMXKa8/jtUSsooGhbdOdo2oydsSxTNpJFBErpP6IWW6+bainrxnN9acpCXL96j9kTw 6zMZD6LW OqCcPEzojYOzsSWq6/a6JY/jCxZ9aVv1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25. 01. 24, 9:53, Michal Hocko wrote: > On Thu 18-01-24 05:35:04, Yang Shi wrote: >> From: Yang Shi >> >> The commit efa7df3e3bb5 ("mm: align larger anonymous mappings on THP >> boundaries") caused two issues [1] [2] reported on 32 bit system or compat >> userspace. >> >> It doesn't make too much sense to force huge page alignment on 32 bit >> system due to the constrained virtual address space. >> >> [1] https://lore.kernel.org/linux-mm/CAHbLzkqa1SCBA10yjWTtA2mKCsoK5+M1BthSDL8ROvUq2XxZMw@mail.gmail.com/T/#mf211643a0427f8d6495b5b53f8132f453d60ab95 >> [2] https://lore.kernel.org/linux-mm/CAHbLzkqa1SCBA10yjWTtA2mKCsoK5+M1BthSDL8ROvUq2XxZMw@mail.gmail.com/T/#me93dff2ccbd9902c3e395e1c022fb454e48ecb1d >> >> Fixes: efa7df3e3bb5 ("mm: align larger anonymous mappings on THP boundaries") >> Reported-by: Jiri Slaby >> Reported-by: Suren Baghdasaryan >> Tested-by: Jiri Slaby >> Tested-by: Suren Baghdasaryan >> Cc: Rik van Riel >> Cc: Matthew Wilcox >> Cc: Christopher Lameter >> Signed-off-by: Yang Shi > > Acked-by: Michal Hocko > > Thanks! > >> --- >> mm/huge_memory.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index 94ef5c02b459..e9fbaccbe0c0 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -37,6 +37,7 @@ >> #include >> #include >> #include >> +#include >> >> #include >> #include >> @@ -811,6 +812,14 @@ static unsigned long __thp_get_unmapped_area(struct file *filp, >> loff_t off_align = round_up(off, size); >> unsigned long len_pad, ret; >> >> + /* >> + * It doesn't make too much sense to froce huge page alignment on >> + * 32 bit system or compat userspace due to the contrained virtual >> + * address space and address entropy. >> + */ FWIW, Bernhard noticed that "froce" and "contrained", could you fix that before applying the patch? thanks, -- js suse labs