From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Christoph Hellwig <hch@infradead.org>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] f2fs: do not support mmap write for large folio
Date: Wed, 8 Apr 2026 16:07:35 +0200 [thread overview]
Message-ID: <2aee26dd-703b-47c4-9210-f70ffa6faf09@kernel.org> (raw)
In-Reply-To: <adXhq-eEjJji1rcc@infradead.org>
On 4/8/26 07:03, Christoph Hellwig wrote:
> On Tue, Apr 07, 2026 at 10:58:11PM +0000, Jaegeuk Kim wrote:
>> On 04/06, Christoph Hellwig wrote:
>>>
>>> Why? And how is this not breaking applications?
>>
>> Since we only support the large folio on the read case.
>
> In general spelling such basic out in the commit log, and even comments
> is really helpful. I'm curious how this works, though - by the time
> you read a large folio you don't know if it will ever be written to.
Why are only large folios supported for read?
Where is that allocation logic and how can that path even be triggered?
Also, usually we check for large folios by testing the actual folio, not
whether the mapping supports them?
--
Cheers,
David
next prev parent reply other threads:[~2026-04-08 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260406154940.2407853-1-jaegeuk@kernel.org>
2026-04-07 5:17 ` Christoph Hellwig
2026-04-07 22:58 ` Jaegeuk Kim
2026-04-08 5:03 ` Christoph Hellwig
2026-04-08 14:07 ` David Hildenbrand (Arm) [this message]
2026-04-08 18:08 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2aee26dd-703b-47c4-9210-f70ffa6faf09@kernel.org \
--to=david@kernel.org \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox