From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BAB0E77188 for ; Sun, 12 Jan 2025 14:12:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77FDE6B0092; Sun, 12 Jan 2025 09:12:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72E076B0098; Sun, 12 Jan 2025 09:12:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61CDD6B0099; Sun, 12 Jan 2025 09:12:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 445346B0092 for ; Sun, 12 Jan 2025 09:12:15 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 93C661A0981 for ; Sun, 12 Jan 2025 14:12:14 +0000 (UTC) X-FDA: 82998989388.19.51470B0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 8C80BC0011 for ; Sun, 12 Jan 2025 14:12:12 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736691133; a=rsa-sha256; cv=none; b=XuPmsQHRstfJtqq+UhJwsZvbywimnBHvo8HpC8YJJYMh/g+B+g5r2mnwlojkdRrbaYlmOz IU8Xm29fYBn0d4WnSAM3e9ST8YaqmP77fQfgMIQvIXoETBNXu/orL+Gx5Mv3lMxjB213z7 co+SW2meuGJyvCV1kvvC9ds0dY9gjYU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736691133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rF71JgQzKwCZuOkW0PA0Qa/16qWDg4g6anJKQ14ihDM=; b=dDOAiORnpZcUpJCUOp4sQspUiI9tssDJts7dsswWUNzZBWEuGQ7p6k1XNbR4xosW4COIw/ bN+8Cf3tkDxhwHW/ri35OQz0IM5dQeJBjYd3EMVwmU9lZnU1d3BPTZnp1xSj68B0g1VFw1 +feFoeSYGIzvQ0PxzLvFTRrXjbnhrYw= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C3E23106F; Sun, 12 Jan 2025 06:12:39 -0800 (PST) Received: from [10.163.85.40] (unknown [10.163.85.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 644CE3F59E; Sun, 12 Jan 2025 06:11:59 -0800 (PST) Message-ID: <2aed36e5-740e-45bc-ae29-cfc11be780cf@arm.com> Date: Sun, 12 Jan 2025 19:41:56 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 00/11] khugepaged: mTHP support To: Nico Pache Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, willy@infradead.org, kirill.shutemov@linux.intel.com, david@redhat.com, aarcange@redhat.com, raquini@redhat.com, sunnanyong@huawei.com, usamaarif642@gmail.com, audra@redhat.com, akpm@linux-foundation.org References: <20250108233128.14484-1-npache@redhat.com> <3e3252c2-65fc-45aa-99a1-ed66c31aba12@arm.com> <4ab296ec-5dd2-4d1f-a823-29396cade93e@arm.com> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8C80BC0011 X-Stat-Signature: m7irdfzquew8hda7zi6z13g7au6ufnee X-HE-Tag: 1736691132-223776 X-HE-Meta: U2FsdGVkX1/nPTB55AsJ5saaL56xgOtY9KeAsxvWYGb67OVgh2TYuIwGXagd5SWWTB7dP5DjWwCGx7afNXSVBOvh8Yvb1BLq4bdtrNwvNOycviC0kkv8U5IKhZlEjaqj/WkuD2qnZsqpp0GlFmU3XXuN2pRYielmWfyXGKQ2SDuVumebK199BeLA/08JMlLEW5pWkQx66hGo+8k3uXjaiLRKhq1k+fAjZpLBuE4zKJPhs35RUf97kuf+2TN6mRm7oUqG7SlRivVdc+FFa3rDumEc6ByLxleK8N9k9Da5XnvQdv8PwO5zx/TYU273lWdQ0SHXSzof+G268pU7ZNkfACu2sTlOZAd+Vnz4A/p82PRiyYYO7IRKw+bdUcU6mV9/tLLyuUlTFws40MRTjE2YC6UEgFRlUEWiCgoACcIbbMdKEEX5+12pxMVoSquS3i/zx6xIPDKM5JmqNpps47bUbjbyeuzuxmmXVTGlbZmok3hXXI0McQhWJPx3Pdi2BNO7skmrAiSD0UAZl7ZiHWUAnjn7XmKunfKdZ8l9qfNZpCJ+lrhe9ecTJnP5fEdIFADrPYl9bFh/6A/Vxa166nI7BFDcFoB0ZGptDLPmdElfxlahABw+2cGa4thR607jPVGRJ+05XuNjCAfu+YiLyT01JlGyd3EE9wwDJ2t439a8zf9FMhGMkRu9Lj0uxZrJxEWinjcS+Ea+40Ds9n/8emAe4A7fnsEkDDh+op5BpWHO+9D1ePgZe2U4/zTtx+octU5vtBS2eOvQtD61jT0KLLevka7pLCdcSt3x40HKpWYr+2BRRpb/apcUxXMoMzNOeKbX6YrpXx13+3ruLria5RTNSXWVDqz4Vi6U0pv/ueUQm0s7r4QNM1YPg1/VDLcfASlwHYc3xI5BPYlBsNz0a5G1SRVM0UyFyefZ14hCl7pZ6OJ9BRaynjbvDD34Wo2BA9H1/jGIrwRjN7y5wi4oEHZ IHkR4G2s 7f5JIoIx4e/+rZpSqXqWkg2+LJR31c04pjUFeiZGQjXG4roWf49PxGSNnDBqGKLx5vaL5gLTy+kCgAXFbbCSX7/XRbV+PZOqMkx0J2ln+YBTT7xaVU/FsQnUGqIT7edN3LK/IvRTM3WIS2kG6x4sGFoTaDFEWnaGCHoRza9OI0X0f/JmmaToguR/JA40aeZaC2Kq7tz7I4BJtytPK4oYyQJ8XO+zsR9g3eYGQwaqSmCqpQhcmRyxityyDCv6NasTCoV2K40BMGhOy9yLMckQDqVakfbwIGbVXL+Lp9VZy+xF937rWMprdknPZPKBBAZlvfo9WrWHt8mhpNlBDzRZAFNqf7ibLRZsblO5A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/01/25 3:31 am, Nico Pache wrote: > On Thu, Jan 9, 2025 at 9:56 PM Dev Jain wrote: >> >> >> >> On 10/01/25 7:57 am, Nico Pache wrote: >>> On Wed, Jan 8, 2025 at 11:22 PM Dev Jain wrote: >>>> >>>> >>>> On 09/01/25 5:01 am, Nico Pache wrote: >>>>> The following series provides khugepaged and madvise collapse with the >>>>> capability to collapse regions to mTHPs. >>>>> >>>>> To achieve this we generalize the khugepaged functions to no longer depend >>>>> on PMD_ORDER. Then during the PMD scan, we keep track of chunks of pages >>>>> (defined by MTHP_MIN_ORDER) that are fully utilized. This info is tracked >>>>> using a bitmap. After the PMD scan is done, we do binary recursion on the >>>>> bitmap to find the optimal mTHP sizes for the PMD range. The restriction >>>>> on max_ptes_none is removed during the scan, to make sure we account for >>>>> the whole PMD range. max_ptes_none is mapped to a 0-100 range to >>>>> determine how full a mTHP order needs to be before collapsing it. >>>>> >>>>> Some design choices to note: >>>>> - bitmap structures are allocated dynamically because on some arch's >>>>> (like PowerPC) the value of MTHP_BITMAP_SIZE cannot be computed at >>>>> compile time leading to warnings. >>>>> - The recursion is masked through a stack structure. >>>>> - A MTHP_MIN_ORDER was added to compress the bitmap, and ensure it was >>>>> 64bit on x86. This provides some optimization on the bitmap operations. >>>>> if other arches/configs that have larger than 512 PTEs per PMD want to >>>>> compress their bitmap further we can change this value per arch. >>>>> >>>>> Patch 1-2: Some refactoring to combine madvise_collapse and khugepaged >>>>> Patch 3: A minor "fix"/optimization >>>>> Patch 4: Refactor/rename hpage_collapse >>>>> Patch 5-7: Generalize khugepaged functions for arbitrary orders >>>>> Patch 8-11: The mTHP patches >>>>> >>>>> This series acts as an alternative to Dev Jain's approach [1]. The two >>>>> series differ in a few ways: >>>>> - My approach uses a bitmap to store the state of the linear scan_pmd to >>>>> then determine potential mTHP batches. Devs incorporates his directly >>>>> into the scan, and will try each available order. >>>>> - Dev is attempting to optimize the locking, while my approach keeps the >>>>> locking changes to a minimum. I believe his changes are not safe for >>>>> uffd. >>>>> - Dev's changes only work for khugepaged not madvise_collapse (although >>>>> i think that was by choice and it could easily support madvise) >>>>> - Dev scales all khugepaged sysfs tunables by order, while im removing >>>>> the restriction of max_ptes_none and converting it to a scale to >>>>> determine a (m)THP threshold. >>>>> - Dev turns on khugepaged if any order is available while mine still >>>>> only runs if PMDs are enabled. I like Dev's approach and will most >>>>> likely do the same in my PATCH posting. >>>>> - mTHPs need their ref count updated to 1<>>>> >>>>> Patch 11 was inspired by one of Dev's changes. >>>>> >>>>> [1] https://lore.kernel.org/lkml/20241216165105.56185-1-dev.jain@arm.com/ >>>>> >>>>> Nico Pache (11): >>>>> introduce khugepaged_collapse_single_pmd to collapse a single pmd >>>>> khugepaged: refactor madvise_collapse and khugepaged_scan_mm_slot >>>>> khugepaged: Don't allocate khugepaged mm_slot early >>>>> khugepaged: rename hpage_collapse_* to khugepaged_* >>>>> khugepaged: generalize hugepage_vma_revalidate for mTHP support >>>>> khugepaged: generalize alloc_charge_folio for mTHP support >>>>> khugepaged: generalize __collapse_huge_page_* for mTHP support >>>>> khugepaged: introduce khugepaged_scan_bitmap for mTHP support >>>>> khugepaged: add mTHP support >>>>> khugepaged: remove max_ptes_none restriction on the pmd scan >>>>> khugepaged: skip collapsing mTHP to smaller orders >>>>> >>>>> include/linux/khugepaged.h | 4 +- >>>>> mm/huge_memory.c | 3 +- >>>>> mm/khugepaged.c | 436 +++++++++++++++++++++++++------------ >>>>> 3 files changed, 306 insertions(+), 137 deletions(-) >>>> >>>> Before I take a proper look at your series, can you please include any testing >>>> you may have done? >>> >>> I Built these changes for the following arches: x86_64, arm64, >>> arm64-64k, ppc64le, s390x >>> >>> x86 testing: >>> - Selftests mm >>> - some stress-ng tests >>> - compile kernel >>> - I did some tests with my defer [1] set on top. This pushes all the >>> work to khugepaged, which removes the noise of all the PF allocations. >>> >>> I recently got an ARM64 machine and did some simple sanity tests (on >>> both 4k and 64k) like selftests, stress-ng, and playing around with >>> the tunables, etc. >>> >>> I will also be running all the builds through our CI, and perf testing >>> environments before posting. >>> >>> [1] https://lore.kernel.org/lkml/20240729222727.64319-1-npache@redhat.com/ >>> >>>> >>> >> I tested your series with the program I was using and it is not working; >> can you please confirm it. > > Yes, this is expected because you are not fully filling any 32K chunk > (MIN_MTHP_ORDER) so no bit is ever set. That is weird, because if this is the case, then PMD-collapse should have also failed, but that succeeded. Do you have some userspace program I can test with?