From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29192E77188 for ; Fri, 3 Jan 2025 10:31:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F6EC6B0082; Fri, 3 Jan 2025 05:31:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A66B6B0083; Fri, 3 Jan 2025 05:31:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66E316B0088; Fri, 3 Jan 2025 05:31:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 478A96B0082 for ; Fri, 3 Jan 2025 05:31:32 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E22F04374E for ; Fri, 3 Jan 2025 10:31:31 +0000 (UTC) X-FDA: 82965771588.08.51758AB Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by imf06.hostedemail.com (Postfix) with ESMTP id 7DCDB180005 for ; Fri, 3 Jan 2025 10:30:53 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.198 as permitted sender) smtp.mailfrom=alex@ghiti.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735900266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AdVk9JooAiUWjK4jTUHIpLmf4pHDaMVdTZ9VuXI895c=; b=APPJeXPZb+PotpQbJDNQdMqIFM6Xqqf6yEJHyuVpHrw0V0imhYt0At26kZixAPMgU8JBEh /Zn0ZF67GO9mVkhiXVjh3jWeG7GQ9T4BKwPfl8/xiW2XFguFCq1IR0N/bNpUdumdnGO7xV l6gO7ynFNvX/I1H7WRDWDb1SGka67Vc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735900266; a=rsa-sha256; cv=none; b=v7vWVOuWnRTACjySo89n12lcxJbJzNeYgcijLGwdq4LxCCxwIoh7yqenbddEKZgz1DasEd dvybi0c7BHP/wEWWZnbHoXerrVCREQhpcw+E/x3czh0vwKKBBD1xRx2egwgFJBtzLXN5Tz QeIxaAVgR+AQHQc3t2Tc3mf1tmg8g4M= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf06.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.198 as permitted sender) smtp.mailfrom=alex@ghiti.fr Received: by mail.gandi.net (Postfix) with ESMTPSA id 3A9C3C0007; Fri, 3 Jan 2025 10:31:20 +0000 (UTC) Message-ID: <2aed338a-97a4-40e3-8a95-99458756ca28@ghiti.fr> Date: Fri, 3 Jan 2025 11:31:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/10] riscv: mm: Skip pgtable level check in {pud,p4d}_alloc_one To: Kevin Brodsky , linux-mm@kvack.org Cc: Andrew Morton , Catalin Marinas , Dave Hansen , Linus Walleij , Andy Lutomirski , Peter Zijlstra , "Mike Rapoport (IBM)" , Ryan Roberts , Thomas Gleixner , Will Deacon , Matthew Wilcox , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, loongarch@lists.linux.dev, x86@kernel.org References: <20241219164425.2277022-1-kevin.brodsky@arm.com> <20241219164425.2277022-6-kevin.brodsky@arm.com> Content-Language: en-US From: Alexandre Ghiti In-Reply-To: <20241219164425.2277022-6-kevin.brodsky@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-GND-Sasl: alex@ghiti.fr X-Stat-Signature: ee3w96zegys9xtyct8rx5zwhqwzx64qh X-Rspamd-Queue-Id: 7DCDB180005 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1735900253-619169 X-HE-Meta: U2FsdGVkX18NZD5NnTbESpvSgq5xN3nY5OGJ1iIEcb4cOTB01mEg5ahRav4/6EBUc1Wj2gPAVxS5z+WBGAkzo+6A+NQXHx1Mfdd7cGfRxrdG8dKIR/RrWDOtQpmnZpZa+UOGEFUJgv79YOZCNVusbKUj3DV5giCy/0p0/Il8zXj15pCdoa5sAIuTsSKDSnKVBaEezD8w7SnaIKbFqlhtSfuvZabPH0oYIYdpMdnYqMLfQyY5UqYvAlAMeVW2/OolhsoVZQpf4dE1axPI6PBemf+T3XJ1T/CBO/GX5pTOD9yhm8Ca8CaUdXNU5VU/Bv7jhWZcSeJusY6crBpBIIDsnznbMfMMtxH8sqPY6q7I9IPCifRC/4/C72NsfveKi6EBwWLh9BlgyKMT1MtqzSu+0FEV5oxF63TcQC0rz+lDz9QVsAs5K8pOEakcKJxrW8vJRylL9hzru4f55HSsSBap3f03svWIREJmzR8HFnfLNyBN8+E7YM9D9V/YcS+s4jIKYUuff+U4IIyCKHNi3AM9ZKBLd/vOp/+2lztmHHj02Iq97dVeV4BZFckDIeAXKAKaScqyAWli7KIjy0ndgpg3zEPnvnKW0POi0adePi1wTO4Fo0D0TV5bB497O2pmlEgeop6opQNVzB0iMKzby5wX2oJsLIK1BatGUGLjS80Eq6BMu0187vPE07Ut3+cklFP1kYcXTWoN0aLDKOWv3BGAPwMZ+V2SOfgTc0iSjjdoeXqg7ax9LanTy1wvc3pBpES8h03GcaQAEvSTuMs2zSta0coy3SMBemYJmHV/bxXTHCo9qimcsJKuaH3fxBtq7HW6ilQp6I57Po0YdLohL8ICnqWfwWYAUlqh0eXd/UxSQgTSJQO7c6elwIXhAHFmL01cMAybEC04tL2s2f14ArbvitwGvgesOf3o4oKbszNxCU0h4bbYs1COvQwEE7KNrL5i35tMsdwT7G53x+fxnm5 P91tcZNk AYGuPU6v/LIAjdX8H+UOd0BWh7TVV5hYM+4cIU4JTpqfugNuhIsY1IbCD7Hrq2UbiOeFMEDZ+tiDF5g2lIJHCCeX5K4vAO8JkvOQXD4KlFjyPrvNaGG8TohHvGCp/ompAzHZY3IcU8vCJxuoWHZz2pAm9J9mXMT9yLuy8nmqXOKOO0bZgVXJcVmqUEgiuovIerRCIveZvF4jY9cqxsRyHl+hx1eZnEktIyr2ro4tdAf5aw0ZIO7+k7e0C18fPvWtQP8zN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kevin, On 19/12/2024 17:44, Kevin Brodsky wrote: > {pmd,pud,p4d}_alloc_one() is never called if the corresponding page > table level is folded, as {pmd,pud,p4d}_alloc() already does the > required check. We can therefore remove the runtime page table level > checks in {pud,p4d}_alloc_one. The PUD helper becomes equivalent to > the generic version, so we remove it altogether. > > This is consistent with the way arm64 and x86 handle this situation > (runtime check in p4d_free() only). > > Signed-off-by: Kevin Brodsky > --- > arch/riscv/include/asm/pgalloc.h | 22 ++++------------------ > 1 file changed, 4 insertions(+), 18 deletions(-) > > diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h > index f52264304f77..8ad0bbe838a2 100644 > --- a/arch/riscv/include/asm/pgalloc.h > +++ b/arch/riscv/include/asm/pgalloc.h > @@ -12,7 +12,6 @@ > #include > > #ifdef CONFIG_MMU > -#define __HAVE_ARCH_PUD_ALLOC_ONE > #define __HAVE_ARCH_PUD_FREE > #include > > @@ -88,15 +87,6 @@ static inline void pgd_populate_safe(struct mm_struct *mm, pgd_t *pgd, > } > } > > -#define pud_alloc_one pud_alloc_one > -static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long addr) > -{ > - if (pgtable_l4_enabled) > - return __pud_alloc_one(mm, addr); > - > - return NULL; > -} > - > #define pud_free pud_free > static inline void pud_free(struct mm_struct *mm, pud_t *pud) > { > @@ -118,15 +108,11 @@ static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud, > #define p4d_alloc_one p4d_alloc_one > static inline p4d_t *p4d_alloc_one(struct mm_struct *mm, unsigned long addr) > { > - if (pgtable_l5_enabled) { > - gfp_t gfp = GFP_PGTABLE_USER; > - > - if (mm == &init_mm) > - gfp = GFP_PGTABLE_KERNEL; > - return (p4d_t *)get_zeroed_page(gfp); > - } > + gfp_t gfp = GFP_PGTABLE_USER; > > - return NULL; > + if (mm == &init_mm) > + gfp = GFP_PGTABLE_KERNEL; > + return (p4d_t *)get_zeroed_page(gfp); > } > > static inline void __p4d_free(struct mm_struct *mm, p4d_t *p4d) Reviewed-by: Alexandre Ghiti Thanks, Alex