From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22F7C47DD3 for ; Fri, 19 Jan 2024 14:54:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 287586B007B; Fri, 19 Jan 2024 09:54:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 237C86B007E; Fri, 19 Jan 2024 09:54:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FFEC6B0080; Fri, 19 Jan 2024 09:54:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F41DB6B007B for ; Fri, 19 Jan 2024 09:54:31 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A250A4077B for ; Fri, 19 Jan 2024 14:54:31 +0000 (UTC) X-FDA: 81696356742.22.2F0D0E5 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf23.hostedemail.com (Postfix) with ESMTP id BD3CD140022 for ; Fri, 19 Jan 2024 14:54:28 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=jeT5TYDa; spf=pass (imf23.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705676068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FqsslxIEMoApitxXr/jCsu5JyE/pWRxqwJQndEwBNxg=; b=hJ9gDArpcdDX570Ik3BKlbnZMhzyJbTRA4Sqiuv0mBaRzBQ9oIjDR//bFFzVtnm1M4kMqK JzwLern9ns05KGC6tJLDyzCUw+cjc0BAivMw9BdVlaQLKHil3UMkL97cNTsqbUNtO02gmj xgEiJ5nVUzQA24oqs3HtENariGiKO4k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705676068; a=rsa-sha256; cv=none; b=09vvBiwOvruxM2uqNoam+zQOs7BGVdbVBRjNElLWS3WO/WojN68E2EB5mHFQbQvm09RmFz mUO7ipSwyV4wTdlTePV/9u0W+v3VltXKB8Z6V/wpZsuhjvBL/XM1Wlvw+xOnmy0ab5VOEp x39pKtjkilfNhzrh+MJU0nbdOIGQ8jE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=jeT5TYDa; spf=pass (imf23.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: <2aeb7d61-5080-4089-b789-765399db74c8@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705676067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FqsslxIEMoApitxXr/jCsu5JyE/pWRxqwJQndEwBNxg=; b=jeT5TYDa4WRfHh4yMTzZwdLf9kbdfdoaPY3/aBxVXcCzn7dnwo3nKeiLIdGzNtfFhxj0rW aDY8uIJ1DGD3sIk20xaJ/bcYDK0pqdyxogfoVfzIsCnrl/GsdgXa/S4BST+KayxUfywkkd cac3sPvodXoskwFwLcwlphMTcBZewbA= Date: Fri, 19 Jan 2024 23:04:08 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v4 3/7] padata: dispatch works on different nodes Content-Language: en-US To: Muchun Song Cc: linux-mm@kvack.org, David Hildenbrand , David Rientjes , Mike Kravetz , Andrew Morton , Tim Chen , linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com References: <20240118123911.88833-1-gang.li@linux.dev> <20240118123911.88833-4-gang.li@linux.dev> <10f26c5c-760d-4f1b-abdc-8508971236ed@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gang Li In-Reply-To: <10f26c5c-760d-4f1b-abdc-8508971236ed@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Stat-Signature: dkrh3qrpfgyshnyn68cpc3gsufpobiz9 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BD3CD140022 X-Rspam-User: X-HE-Tag: 1705676068-857493 X-HE-Meta: U2FsdGVkX1+AxuD0Xc2ZO0XyfQ208fH76iOcOj/V2mFbDcjGkFU2LM/qsXNTnD4oLmNF2mRUovQW26LMs05V+evf71FjgPhySzhAy98SbOVaIlhHTrk+n+UDQtsyU+1GvU7dnLo4KcP0+UY6VceHjmaib1fR77dBT3UDRXIdrUZmvnAgha1R8gJ7AZNZDM0vIW6pw51d+YqqYUnutlIdskIR/NxCkZ9CNkpDRJfcQ1075g0IDwJLQ+pFkkZbaY46q4CCMEdlPg36cx7Vk4K2awDcGmkW6/fLRmszHckhVjTkfrCyRKTyXa46edq7gIrLTKmUvZS9shTxcwcr3vmCZRG/dD3nY6+QoGmiY0UtBGrqQeSjV9Nm8ii/MTb0dWgecwDurmAIOmRfkoNk9f6dqjFbuJIiucrlli2D9Mxk8CY3NDcC6iLq05JivlZ+FmnEcgs2OXceCx01uevmmGnDbfI6XkUcB+cAprXDa3VypXW+Qm6SdH3bUfyI5doJd8BDaOvc5euLpfv6RkcpNP2EoPmWbeVp/wVifuan8SiAxMAJf9w4UIglkEoVNXWcWq0QvS0CrFMV6VOvEG6RjyitYGp/5xDK+o1HS9RYrN1asvSYCKpctOM8Fp4tw0lp38FO/heWUP2qCX3v85CZZJwbjH/DvspqeIci8lVSM5gS+pCNIjUhSImVSEmzYMXZMRfL1Vh1MT4hBP3VGMbDdO8SULAoFYxyMf8twjLGXHrm4O0KLdIx+FeaqiaroNFVFEED9Ehd9tM6Vltz2P6mzoyv6AidAZCwKN6fG9MsLIsbTFyBoO7Xugf1co+A5hjxXjpZ8l+FmJC4aWKRQ1yMm6i7RVGxuiRvhJzE9FL8sLsBZAkHevJAc+bpnJABGlzqWDn9Pt4nwfvMk3qOHd53W9XDagmalYsJSiicbfB9iz54jzk276uNRluSRvOs2Qg6qsdWxVskMaKC2TGboqvYejp s0c/F5G4 gLkpRnmSEWoeZP/s4OhBSRdeHSQk2G6FH81/zir9Grb3iFpB7erhz9xEwOUw+cIJafHZVihNQX4j0zzAy8n3MV8E8YQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/19 10:59, Muchun Song wrote: > On 2024/1/18 20:39, Gang Li wrote: >> --- a/kernel/padata.c >> +++ b/kernel/padata.c >> @@ -485,7 +485,8 @@ void __init padata_do_multithreaded(struct >> padata_mt_job *job) >>       struct padata_work my_work, *pw; >>       struct padata_mt_job_state ps; >>       LIST_HEAD(works); >> -    int nworks; >> +    int nworks, nid; >> +    static atomic_t last_used_nid = ATOMIC_INIT(0); > last_used_nid is only used during boot time so it could be > __init_data. Otherwise, LGTM. > > Reviewed-by: Muchun Song > OK, thanks.