From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74B3FC3DA49 for ; Fri, 26 Jul 2024 14:46:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1CE56B009C; Fri, 26 Jul 2024 10:46:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCCD66B009E; Fri, 26 Jul 2024 10:46:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B45AC6B00A4; Fri, 26 Jul 2024 10:46:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 969DB6B009C for ; Fri, 26 Jul 2024 10:46:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 40F97C194A for ; Fri, 26 Jul 2024 14:46:03 +0000 (UTC) X-FDA: 82382178606.05.96C08FC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id DEC1B140019 for ; Fri, 26 Jul 2024 14:45:59 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EfESSFSh; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722005109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JYTUGDCfTZNE/l3lPsvI7+Ma8ppBanJPr1boNuvZBmI=; b=1ESW4ikSv8ubXky1GVAiUFrjLHOJDXHs//qCVn5IKMOo4nBij6lUdLcz6SFwQ83xJvKqqd SDsnBwKTXr/Y+taoqqY73i2/FIX0OvN8aCvWSDGgaO5G6dXMYZgshOFnOlEQWIF9b2szXp KzucFdG1yuk5CUGjqmB07xEFUAH1yWs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722005109; a=rsa-sha256; cv=none; b=k9y2eIAmRTJJiaTf8NPkOsX3i7V/gKGo+9OlEj+SdGt7VOENngmKaWC9DU4tEaulbWv0hN HwUaUPBueDYGDECYMjdp+91XMNu+Aq8WmMpLmMvzg1R5qC6VnTQ1/YSGSSpFaeWneTFD1j OzFkHzqh0edjqcs4v50rvrLxmtRyXZ0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EfESSFSh; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722005159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JYTUGDCfTZNE/l3lPsvI7+Ma8ppBanJPr1boNuvZBmI=; b=EfESSFShnHLYiXJ/AAruF74AaHj5kfMeOGI1bFh9hlzm/vF2JUSjGWXhsfZ932N72KUkm6 rHH7lfZ1LWVmNDjYO0329DVuZfqoXk9ENTGfspYbKWytM2sY7+61lEEWkstIUAEwEjAJxL absYBGRfVqS2gAAuWVQfxdMVBQv56QQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-mbLzpwVBM1WXIHZPyS_acg-1; Fri, 26 Jul 2024 10:45:57 -0400 X-MC-Unique: mbLzpwVBM1WXIHZPyS_acg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3686d709f6dso1407644f8f.0 for ; Fri, 26 Jul 2024 07:45:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722005156; x=1722609956; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JYTUGDCfTZNE/l3lPsvI7+Ma8ppBanJPr1boNuvZBmI=; b=Nui92kTdQMDnYlM6w6EiWo9N5mgWf8TdFO7IPeztFHem/BdzwA2SpB+DhGvX6tgK/1 MdI4Q6x7/pcHLQyEms4XypRI3mlolrQSs6CRpjq3xrVC8qc7SYBFqlLOi3+Fp37TxWhI SHe5IRGh+PIB9eut4pW1EULwD+a1mg4+l095lN+JhAnIcWTeCbKmN61H+HqagJPM41qX lAw4T8F2Y+OP+dbQOt+tUi3isQsOaloCo3WDnR5iaV2ExMj4wDw8t6YJlgXMmmLEvy0C xb67jmpVS+u1dW6F2LDwSMou2d6w/ayhjN3jReDBf5S2PS89gRCB95aqzJqe13Hpg1Xq CANw== X-Forwarded-Encrypted: i=1; AJvYcCUPOpF4S2T68jkKKyrEakqGNir/LOlNfinCp8rVGlJVtNfNlQQQFI79uGefg2DDgRDs34uuO9+2YN1T1R7dI/uas74= X-Gm-Message-State: AOJu0YzsgwmLLCih+nTNxuu+BUfnut7GomgSoJQqUsNND5JfvPeLDfM1 vKGbApt4pF6HHrfW3FDBEBk+bT1n7Vp6G+qDmCExJzPbOAmrn57OsEGLpyWNQAVQhdFX089tVky r5gqQQFWEUNGEXnLpbv6ZAsxV1TmAU2ZQ1DoNJm9jrXvh3UHa X-Received: by 2002:a5d:49c2:0:b0:367:83e9:b4a5 with SMTP id ffacd0b85a97d-36b31a79ff7mr4100496f8f.49.1722005155812; Fri, 26 Jul 2024 07:45:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhezjviW41dh3V5Qq+AOstwGWnEQSINQFbO25+t0TgirVWiiVljW2qh4OfNvFlWfd95I5XeA== X-Received: by 2002:a5d:49c2:0:b0:367:83e9:b4a5 with SMTP id ffacd0b85a97d-36b31a79ff7mr4100477f8f.49.1722005155261; Fri, 26 Jul 2024 07:45:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c713:a600:7ca0:23b3:d48a:97c7? (p200300cbc713a6007ca023b3d48a97c7.dip0.t-ipconnect.de. [2003:cb:c713:a600:7ca0:23b3:d48a:97c7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367d989asm5339437f8f.29.2024.07.26.07.45.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jul 2024 07:45:54 -0700 (PDT) Message-ID: <2ae8be1f-7b07-4967-b40c-2e4a85080639@redhat.com> Date: Fri, 26 Jul 2024 16:45:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/2] mm/hugetlb: fix hugetlb vs. core-mm PT locking From: David Hildenbrand To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Muchun Song , Peter Xu , Oscar Salvador References: <20240725183955.2268884-1-david@redhat.com> <20240725134129.fc9165ac6413c4f774b786c1@linux-foundation.org> <7d88ac63-46b9-4b2e-a46b-c78d8d1d9f0e@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <7d88ac63-46b9-4b2e-a46b-c78d8d1d9f0e@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DEC1B140019 X-Stat-Signature: terc8kfxwgq3qeo8udncf1gb5zi7numt X-HE-Tag: 1722005159-894935 X-HE-Meta: U2FsdGVkX184Ti7C0HjK3b3gLTiyA39nVHM1x4MJWpWhU9Vc5T52quDtG1BH8zHKZv30YG8Hm9SyrW5HQwVVPtaLuIqLAjFCZvGvvkm8ewEW/i7DQ6FZf9jdKW1y9Iaafv4djU5G6qFm2CW4Azh0z9yDE5p7QoHE+JVPW05QJ/ARSto1L1HaN0VMYmQsabVYPgURISj1F4OjXsLpA3YyreIQLxqZiLRIeNh+BYU7JtbLzIPj1sZm6cDUjFYjgTHfQsAxCaamMFqthmQz41n0c9onzeE0i+fvsFoFzcPS5JPOMrznE+7jslx8FtN43utM6qQZvX/MED+RQLmbfAx4dUy/FNvU9u364vMlVPxnQs1Ls9RXVjHXn0F4kNTgpxvh0SLI9tQK9hC4sPrwplOlAKuwVTXfTtWSYhDm6z07k9vqXFA4Veu06wOlJXU1XYkKcXH+P7cMpSGmn0QLwMtzR0LukqOgAO2t3Vz09yDWnh5ZBm1j4sf+Axckzb7k8gwZ9IYHI3zPjdX8cw44whPwVSDszZVXgaSKRd3ESTlQapyHW1IFclLbk5H7I/wnaB6MDQig4e8+xTka8vWyTIMCMl1JtAacqdaAW1nxGfk1nTJK8nw1wwEplkdn1oSaaDld3GfN/f+I2G9gqPTcHTq9SVpilEC6N1rng/gNmc6FHZ9t/KDAkPd0S4nmECdg2OqCiYqSju1CKJ1zPrVgJEaMLcwDY6kXoGCsLX1HbRZP0rXhkkE28mOmztUrOoWb/9B1kOV+dgQJUZ9XSuUH4vqOfrsXCQUKzoIwptV5yva9zQXutrlKxnqa9FnUp15JtbhOk4e4zr1knzXckJUlWamUCcIAM0NjMEQ/5b4nvMUWIJZxIVM/x5uIMCGNMeyY936Jql1YStIlm87ZEyIklTPU7ioypXqN8o4Nye2HdngZGA6/WSFlR/ZfviTs/UTBjkyG6rNaXVRVTkC+8vD179X o7JGHr7V c621XlkwzF4ZQqfG+/4E9dygBYV/SVIYhQjdyviKnlikB/3t5xT5yc6oARJPyRTiYGWf2P3eFa+nnU6+5J6PMh7KWMrW1v6cUx9QQmrkviJNLALeBC71LOuQEXtjzkKHO79I9OWsFU3wwws56jVu2XrGbmjw9c3IERDZwGS2QCM0ltPFF7ZkNrBK6inwwwR6YOSNUumiTVzEMeNJC80weQqafIxIgtYvSYH7Wx4rcTns2PfzE1+OKBWgnl/r05Zytu/9+j7PbDUT4otLDTe3A1EgiwmbvmmsqHKxEsn2khIjVz68A4NT2UosR/hN5ARWcqPRulUjWi+Q75SDdJQqzWrBxQlGQJPljRqnX5oludQWwOa+7evbHFuFEmmwr8RWRYx3iHYKf7OSgXtmm4dS6TZ9XIrHJWKvkNat/MV0eewRdnjkoKaRcn1LMHpGrfgANnhdzy6aqt1DswO/VKTqwxGTDE1Qz7hdhJ+GarehxBmyrVdE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.07.24 11:19, David Hildenbrand wrote: > On 25.07.24 22:41, Andrew Morton wrote: >> On Thu, 25 Jul 2024 20:39:53 +0200 David Hildenbrand wrote: >> >>> Working on another generic page table walker that tries to avoid >>> special-casing hugetlb, I found a page table locking issue with hugetlb >>> folios that are not mapped using a single PMD/PUD. >>> >>> For some hugetlb folio sizes, GUP will take different page table locks >>> when walking the page tables than hugetlb when modifying the page tables. >>> >>> I did not actually try reproducing an issue, but looking at >>> follow_pmd_mask() where we might be rereading a PMD value multiple times >>> it's rather clear that concurrent modifications are rather unpleasant. >>> >>> In follow_page_pte() we might be better in that regard -- ptep_get() does >>> a READ_ONCE() -- but who knows what else could happen concurrently in >>> some weird corner cases (e.g., hugetlb folio getting unmapped and freed). >>> >>> Did some basic sanity testing with various hugetlb sizes on x86-64 and >>> arm64. Maybe I'll find some time to actually write a simple reproducer in >>> the common weeks, so this wouldn't have to be all-theoretical for now. >> >> When can we be confident that this change is merge-worthy? > > I'm convinced that it is the right thing to do, but I don't think we > have to rush this. > > As Baolin notes, we fixed the same issue in the past, unfortunately also > without a reproducer IIUC, so I'll try to reproduce the race, but I'm > not 100% sure if I'll manage to do so.. Okay, so running this series against the reproducer I pulled out of my magic hat, this series seems to properly fix it. -- Cheers, David / dhildenb