From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2363C432C3 for ; Tue, 19 Nov 2019 16:11:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 75D1222384 for ; Tue, 19 Nov 2019 16:11:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="oGIJW8Hf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75D1222384 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 05F936B0005; Tue, 19 Nov 2019 11:11:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 037366B0006; Tue, 19 Nov 2019 11:11:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E685C6B0007; Tue, 19 Nov 2019 11:10:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id D004C6B0005 for ; Tue, 19 Nov 2019 11:10:59 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 8823B3CE9 for ; Tue, 19 Nov 2019 16:10:59 +0000 (UTC) X-FDA: 76173515838.20.swing54_7cfec805e9216 X-HE-Tag: swing54_7cfec805e9216 X-Filterd-Recvd-Size: 5233 Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 Nov 2019 16:10:58 +0000 (UTC) Received: by mail-io1-f68.google.com with SMTP id j20so12774170ioo.11 for ; Tue, 19 Nov 2019 08:10:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yxTg9Jz6CUPbj7hb+zClDPA6shnTNr7Uh8vLjm12KTA=; b=oGIJW8HfkgkobB0o2Qa1NbNfnl9mEqSGpPEO2LkogyZvOuMJQ7TF55da86qlugqMCd 338Wge2YPFXsoEIf9RGDawq7jpCCeV3jwC0W058T6wHLBemhZJS3koszJqUTfQULDiaX 2B6RyRY6HS9AE+8hVENsQBKSpUdhkmyAKNXz0Nm/Cxj0QFJRN/CWS+DE/OAhOnYHg0xk tK1FlPGkzCpUU1kARsuIumFoSGAGKhbP5ourqDXhrP7e5xrJzr7bWyrrGYocI1tJI7bI UgAaDI7OLq1bomHv0lR8zAsfor6M3fEsHwxDtlUp7bVspKwb2e69Lw3GuCnkI9VLqTxF /QFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yxTg9Jz6CUPbj7hb+zClDPA6shnTNr7Uh8vLjm12KTA=; b=lBflwDjvbpcZbaQcFbGDnK4jLCPVQDUh8E0TMCVUk3TqtU05sQWNLFNgqVa0RgBod5 8D7URaVrxNe8cV4y2OiD6YKvPMuf90G2H6sVom0Jy31f3zMlVrrZUiy09uKVd/bZYtQs KMV+4lFxRNSwPyKcw6Q+VcQnelGo1gR2w2ETbxO8kqQSpelFxK3EGhvI6ruydDoaYgPs aaiQiQr+RsGP6M4aa69pir1aPrhyWCRglnmtQyG4a/ozXrfv7IvLqNETAO4ynXfQ1ake N1HGPD2flDKI+hHivHU0PaVnL/SnWXygDdvjL+ocoEQGJ/CvtQExpdhGsCSmMHLs2IQL TZMg== X-Gm-Message-State: APjAAAUnskllEnpRkHR3xsNOyUCFj5JnFWpn50Tmou36WTkhxJ5qJW5r mC64D4HKEsRHoCgodEVcPxvPGA== X-Google-Smtp-Source: APXvYqw/6l4rejQYc8a+bdmv6/89DOI3Ir5+fK0WCl1y9yQpIdn8Kiz4M9g4FLh+4h0UiHB53RA+ow== X-Received: by 2002:a02:140a:: with SMTP id 10mr18915165jag.72.1574179857938; Tue, 19 Nov 2019 08:10:57 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id u6sm5616560ilm.22.2019.11.19.08.10.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Nov 2019 08:10:56 -0800 (PST) Subject: Re: [PATCH v6 15/24] fs/io_uring: set FOLL_PIN via pin_user_pages() To: John Hubbard , Andrew Morton Cc: Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jonathan Corbet , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , bpf@vger.kernel.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-mm@kvack.org, LKML References: <20191119081643.1866232-1-jhubbard@nvidia.com> <20191119081643.1866232-16-jhubbard@nvidia.com> From: Jens Axboe Message-ID: <2ae65d1b-a3eb-74ed-afce-c493de5bbfd3@kernel.dk> Date: Tue, 19 Nov 2019 09:10:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191119081643.1866232-16-jhubbard@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/19/19 1:16 AM, John Hubbard wrote: > Convert fs/io_uring to use the new pin_user_pages() call, which sets > FOLL_PIN. Setting FOLL_PIN is now required for code that requires > tracking of pinned pages, and therefore for any code that calls > put_user_page(). > > In partial anticipation of this work, the io_uring code was already > calling put_user_page() instead of put_page(). Therefore, in order to > convert from the get_user_pages()/put_page() model, to the > pin_user_pages()/put_user_page() model, the only change required > here is to change get_user_pages() to pin_user_pages(). > > Reviewed-by: Jan Kara > Signed-off-by: John Hubbard You dropped my reviewed-by now... Given the file, you'd probably want to keep that. -- Jens Axboe