From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E1C5E7719A for ; Thu, 9 Jan 2025 05:29:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CCAD6B0085; Thu, 9 Jan 2025 00:29:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 27C4A6B0089; Thu, 9 Jan 2025 00:29:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11D886B0088; Thu, 9 Jan 2025 00:29:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E858A6B0099 for ; Thu, 9 Jan 2025 00:29:29 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5954EAF1D7 for ; Thu, 9 Jan 2025 05:29:29 +0000 (UTC) X-FDA: 82986785658.15.8DA7499 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf08.hostedemail.com (Postfix) with ESMTP id 52143160016 for ; Thu, 9 Jan 2025 05:29:27 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=daynix-com.20230601.gappssmtp.com header.s=20230601 header.b="gTD6eC/c"; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akihiko.odaki@daynix.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=akihiko.odaki@daynix.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736400567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XMJt/YhwUnBzvs59wX/sgUOAGddtx1maXOTnOv1QH5s=; b=nerPup6olqDNcYGes/r9sB8z8YdymL7kRhpFQxZ0qgUnWGp9Uw2fvXFRxB8H+mZ296GqeY +H1/q/ku2HB6YyI8oICX96lJYk3ilWTQikEKDTVNhBRu3meHL9AgOwgEsL4zH4+aqm93lg saOLiSensxvWCDK9VOQdkFh+5iyoxtc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736400567; a=rsa-sha256; cv=none; b=j/1CkJ8vU9O8PWabdSGuLsKOy2AJqNumISxdb5G5dP56stqMOQm9O9/euhms+PQDDDGJcW aPrYb1q19oz8Ur3wTlo8XAqCnF2RI1DOe5FMUhZUpZuPWe4eAG4yNBZsI1aZt250MFVa59 REKBPTG+wF/ZxPhAWbOSV5+B42BMmY8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=daynix-com.20230601.gappssmtp.com header.s=20230601 header.b="gTD6eC/c"; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akihiko.odaki@daynix.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=akihiko.odaki@daynix.com Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2165448243fso7981445ad.1 for ; Wed, 08 Jan 2025 21:29:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1736400566; x=1737005366; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XMJt/YhwUnBzvs59wX/sgUOAGddtx1maXOTnOv1QH5s=; b=gTD6eC/cVTD1kLqJXr7MDXRKPiNLGPfQk9QwN1pGwHYwVP5LsxpN+FsiXeVnFmdCVV TcIySkmwrOlKRJXFniCVbuSzRbjag7t3GlsxAbHFuE1PIqqX5ETkG5AwqPWekGC1ymMY QPX1bxiwfax00wh+XBdk9AlvtuUwFrKTioY/kzwQxEHOX1JNjTP22B4SzeWBvlqltXDC ekum9LlsVS0bte0LX+lZ56FHhB+IVMfsE03JRmXwGbaCytW0YwN8oXIpXq9rT91SBWIE oHK9iFr4gnisYUWydUEdVpNV9Z9cFu+o4BxCK9n1nzv/N9hjg/p89zzUOvTZDdcUTMHR 4PDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736400566; x=1737005366; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XMJt/YhwUnBzvs59wX/sgUOAGddtx1maXOTnOv1QH5s=; b=Ywj5Qm3gchfo1oPjzokD4r1f2xqOyUVysyNynhiK5ZPiUyGyyjXLPmFfsBmLjuudrl bpMCN17gZE1mNQ7bPJYDO5GhkMrkfKQYg23Xz2zU+VerluQY7dL3/YXiUqVDkQzJ4rhA ZcLVSJgg2ywQMRfbUceNqkA/VVBjRiFu+xlFLRUyLFERAdOizUpPMzBULjTWJnBQqTEU JeBkhEA2kI/hJPwqflBhLIDf1kX38uRkbWTKxgjdKVwsfb/YX67T+zzxO+mHe0ogGvgP nNOyqAJpZgzcrGDt1yX1iHpUBfPdglRmH2BuPTxHt1U09k9lbBy6evzrWIPfPjA7NNz7 Ge1g== X-Forwarded-Encrypted: i=1; AJvYcCUgMLFX3krHLpVHVdmGgpK0ItdZPxPeB8YKdSQp6KZL45p8EOOytfmMkRaVjkI4dr/J8dzX/XRRXA==@kvack.org X-Gm-Message-State: AOJu0Yw+Y5mpa5Oejdr+ia/TG5k7glYcQ3oNcTBn6ff/cx+wFg0NUvdI Mv/T+wIP13N3de394mAGkravogyu5NMS9J9ZcTC6LCLh1Elhms0mkZBeieIxmqM= X-Gm-Gg: ASbGnctOBL2V9WJDp7LGzYFlkLHNAbw8Ft2RV78DGtfqyqpqhwqe/3Qnde7KsNPNZ4g W0QFMgJkqNQuaK45nMNa/TCUUxUjsMIGyVYU0O7wHggeLobg6P6h6SujVHytZWZDM1CiGk4hRc3 v7zP0aFoq+2z1nTQ2BQ0WwrTN6TIzFrerjlLK1zbPw9xq6pYzPF4iCnEzB4DpmEOdYYOapoIOa5 qebAtv3bd7OtoGuWeOzf55UjMn8VtBtBZteI2qp6ZSyiDVJUbcCrRxzLO3Pcx6tDpM= X-Google-Smtp-Source: AGHT+IHb0FVyvp1dm7B/1h/x9uzjYQ//zMkoJ4qWj36+ahLI4sk0W30C74Z9uJRWuq6gqr8rh892HA== X-Received: by 2002:a17:902:f681:b0:215:e98c:c5bc with SMTP id d9443c01a7336-21a840094b7mr86342285ad.48.1736400565988; Wed, 08 Jan 2025 21:29:25 -0800 (PST) Received: from [157.82.203.37] ([157.82.203.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a91744580sm3702405ad.84.2025.01.08.21.29.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 21:29:25 -0800 (PST) Message-ID: <2ad7234d-bfc5-49e3-abe6-7a85d992329d@daynix.com> Date: Thu, 9 Jan 2025 14:29:19 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] s390/crash: Use note name macros To: Dave Martin Cc: Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Eric Biederman , Kees Cook , Catalin Marinas , Mark Brown , Baoquan He , Vivek Goyal , Dave Young , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org, binutils@sourceware.org, devel@daynix.com References: <20250107-elf-v3-0-99cb505b1ab2@daynix.com> <20250107-elf-v3-5-99cb505b1ab2@daynix.com> <965b73e7-d0a3-4fae-b0ec-70b5497cb6c4@daynix.com> Content-Language: en-US From: Akihiko Odaki In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ow71ra44p9hizw5ybr1fpue15yrhdkrx X-Rspamd-Queue-Id: 52143160016 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736400567-115604 X-HE-Meta: U2FsdGVkX19EWGBWwNJvF30zIlP92f+Q7JV2i/dfTQl/BPf1ljK7I7mYM0gz0Vzp0Qbzr7PdwxWDzbmTCfziDac9/BXeqJxFvofBAiD2+q8lBecqzaQMu6XHAnqiQS9PsN/IKetYduKoKVZOIzb70w0qkqlVXtMV+lWh2S8VVhCXjWZ0MZmHBl0YDCoIe70gGoFrVMkY4Q7HMjoYB359mlgVe/sF7nEcPHXmeqHO0cB5d5rvZ7d8VvozkSEq9inUSyF2tXV2/eP1PzkzlLXQmDGUElreomJE61ut9o9x/ztjlacBt838c+YPNMmHrpDjajLpnRf4TnqcvSmtWwlq58r2C5uNIantGELMznyS4k1yTYyWDfGVfD/SeR+/QBLhvEwLeCJHvjBp/ULn615aVn+RHZ1gSZVpt3YIQkj02eF+ONsfHPVBbzAo0+jBqcMTMn3jpcDQQGFinloL5na4uUUjf0OUvz5vl5BcM2WKzktVaVcEt0J8rOhV4JkshewnYjMNKAuiDHwKkJpsF0zWatRZukJzZsnPbUq/bGvTVK+ql/exa3V4AGblKo3aN1sKg2nwTB2ikwIgdaZF6L1Neq5lhGXrR4ZTpsam0OXwrwgI0KaxyTOseB7y+052ZNrHFcTAIQPD7fOyaGVcHAWJSPDhEiCfUafOm7TLdtjfL5EWuXuv6UvNeKz6fPUZVWjmTbT1lcEGaGVE8+ZwasTL4Z/Egpq2d9ag3nIfBZ47xbrpttzvPfihjnfO29uURgNuEbkgyRlOxtKi9QF+7vLoNRiXVk9P/2uiLRqfKXlhSJiufsrYCLfKpG92+Kj0coFVdmeRhkFbOOozblY/90942UsjsCg6C7biOqBCcOxPceMXdCsGHbvSRXw5yVBhLPSuRUSNVByIBnvtpRA3ftRQMtL/zb+2svT9Z0JPIMfu1cfN1SeonHonp6UpZdNVTH8kbnceWQ5kzSQR+0npDHo wznG6tMV tSrj+2G6+2aNIy5PWeDugrdpE61f/+0pGKKf0FxtDZOKY6vvYRLBgeQr3AftnERJQNfP6jbWRLjjKyh6ZHZBmDTFG9aennZHtgyFsXV6UfzuoZ1AadMIuaVZArx9EAE9pRKyiQA/u1TMxlEl6RG/kGEWFyFdHS0UfPzfZOo1V9Te3KOOmk5743/t/ffxgzMZR8w0AeLG6ubMAufvkI0UXi5ES7byyGeAKMjMfUO9XgzLqDNZYNTZ0IbtUiIW3LPyAqy5fYgi53woM1Cs5kzgbUD9wXGYHThufTrpjYPzvqh4F024m92d94v5Za6CDiF6TEPLqBQW+w1VWLPz5wVGX3X1j6k7yT5pEj0D/9IxNIxFs5TO6a10HzwHwzLRhKlq9tyx5ah+WsoBauJ0Bf0NiWui3uwRr+J0bDI99 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/01/08 22:50, Dave Martin wrote: > On Wed, Jan 08, 2025 at 01:53:51PM +0900, Akihiko Odaki wrote: >> On 2025/01/08 1:17, Dave Martin wrote: >>> Hi, >>> >>> On Tue, Jan 07, 2025 at 09:45:56PM +0900, Akihiko Odaki wrote: >>>> Use note name macros to match with the userspace's expectation. >>>> >>>> Signed-off-by: Akihiko Odaki >>>> --- >>>> arch/s390/kernel/crash_dump.c | 62 ++++++++++++++++--------------------------- >>>> 1 file changed, 23 insertions(+), 39 deletions(-) >>>> >>>> diff --git a/arch/s390/kernel/crash_dump.c b/arch/s390/kernel/crash_dump.c >>> >>> [...] > >>>> +#define NT_INIT(buf, type, desc) \ >>>> + (nt_init_name((buf), NT_ ## type, &(desc), sizeof(desc), NN_ ## type)) > > [...] > >>> (Note also, the outer parentheses and the parentheses around (buf) >>> appear redundant -- although harmless?) >> >> They only make a difference in trivial corner cases and may look needlessly >> verbose. > > (In case there was a misunderstanding here, I meant that some > parentheses can be removed without affecting correctness: > > #define NT_INIT(buf, type, desc) \ > nt_init_name(buf, NT_ ## type, &(desc), sizeof(desc), NN_ ## type)) > > It still doesn't matter though -- and some people do prefer to be > defensive anyway and err on the side of having too many parentheses > rather than too few.) Well, being very pedantic, there are some cases where these parentheses have some effect. If you omit the outer parentheses, the following code will have different consequences: a->NT_INIT(buf, PRSTATUS, desc) The parentheses around buf will make difference for the following code: #define COMMA , NT_INIT(NULL COMMA buf, PRSTATUS, desc) But nobody will write such code. Regards, Akihiko Odaki