From: Vlastimil Babka <vbabka@suse.cz>
To: Mike Kravetz <mike.kravetz@oracle.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Michal Hocko <mhocko@kernel.org>
Subject: Re: question: should_compact_retry limit
Date: Wed, 5 Jun 2019 18:33:45 +0200 [thread overview]
Message-ID: <2ab55bf9-96f0-9616-555a-b7e3a399522b@suse.cz> (raw)
In-Reply-To: <3bc00340-1e81-4f08-37f8-28388b7fba3b@oracle.com>
On 6/5/19 6:05 PM, Mike Kravetz wrote:
> On 6/5/19 12:58 AM, Vlastimil Babka wrote:
>> On 6/5/19 1:30 AM, Mike Kravetz wrote:
>> Hmm I guess we didn't expect compaction_withdrawn() to be so
>> consistently returned. Do you know what value of compact_result is there
>> in your test?
>
> Added some instrumentation to record values and ran test,
>
> 557904 Total
>
> 549186 COMPACT_DEFERRED
Retrying mindlessly with compaction deferred sounds definitely wrong,
I'll try to look at it. Thanks.
> 8718 COMPACT_PARTIAL_SKIPPED
>
> Do note that this is not my biggest problem with these allocations. That is
> should_continue_reclaim returning true more often that in should. Still
> trying to get more info on that. This was just something curious I also
> discovered.
>
prev parent reply other threads:[~2019-06-05 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 23:30 Mike Kravetz
2019-06-05 7:58 ` Vlastimil Babka
2019-06-05 16:05 ` Mike Kravetz
2019-06-05 16:33 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ab55bf9-96f0-9616-555a-b7e3a399522b@suse.cz \
--to=vbabka@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox