From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7C76C77B7F for ; Mon, 8 May 2023 07:27:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B28A6B0078; Mon, 8 May 2023 03:27:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 262656B007D; Mon, 8 May 2023 03:27:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 151EA6B007E; Mon, 8 May 2023 03:27:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 035C66B0078 for ; Mon, 8 May 2023 03:27:53 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C24EE1A0225 for ; Mon, 8 May 2023 07:27:52 +0000 (UTC) X-FDA: 80766258384.20.260B793 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf22.hostedemail.com (Postfix) with ESMTP id 833EDC0005 for ; Mon, 8 May 2023 07:27:48 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683530869; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S0rFeBKz7kIsu/c/LWWdJNx8c3ZFemTF0PeFHj4o5ks=; b=NwjxSVayCecp/VR0lMn2qRNMTcG+vzqS1cZ9XgT1mqKxgyEzZ+pOQK5GBDJZYdsb75hDyT I3IJuutSepfu4F7CKQhQ5Sw0f8exXsxVGt/gypWKBcXdeguDv/TOhECOFachry13FKol0u y1Nxu7MVTjAyts4WeJV6TyBPfkwkmqA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683530869; a=rsa-sha256; cv=none; b=51lHVMwUmZenTU+JD0osf3WsI9MhJSuKICHHx9WeTmdKVJlfgvcxNNSaqJLAgrWkhP4II7 YVw5VwJWW01UnEJ3t03O3xNcdqNfQ6Rh7HVkbeaVAYG2nrzrP6MSZnWXt8QQisbmdVIb3n KxIQn9SVFssxDcZlryXvVjhTadg1pBY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QFCSl1kRQz18LGH; Mon, 8 May 2023 15:23:35 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 8 May 2023 15:27:42 +0800 Message-ID: <2ab0ddbb-f9a4-8963-b066-d9a93b5f01b3@huawei.com> Date: Mon, 8 May 2023 15:27:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 03/12] mm: page_alloc: move set_zone_contiguous() into mm_init.c Content-Language: en-US To: "Huang, Ying" CC: Andrew Morton , Mike Rapoport , , David Hildenbrand , Oscar Salvador , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Luis Chamberlain , Kees Cook , Iurii Zaikin , , , References: <20230508071200.123962-1-wangkefeng.wang@huawei.com> <20230508071200.123962-4-wangkefeng.wang@huawei.com> <87jzxj9u0n.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Kefeng Wang In-Reply-To: <87jzxj9u0n.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 833EDC0005 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: 75u9kiw9mfny668q3tfki3dpxpfmesyo X-HE-Tag: 1683530868-42843 X-HE-Meta: U2FsdGVkX199OXb+lt+fDKPavopOD/Ai0V3DoyVX1+PyUiSE2iXZrRGbt4Zb2Iu3If31xr3r2ktaNkPOKMDX7LjJS7c4I+3wGvNtKbGEQEYeGHp4sD6VyloRU8cshN7gOGXxJ1ypWhH2yy2F/RQawHj+G44DFeIqOJzaHbPYO1MJcLDEM9B1c6BrQ22EfyS3saFDbvZaLEb3+pMo0U5FDiXLch1BCM66t1ET16kLKNcW7/TQp0bHm2ZWMN72YWSGjzvbMgcms2up7E/4EpqsML4svevFmxQDuNeYLle+KO1fLeVLO0oPYnRCGOQ2tKY40ukrxeuIh/YXjJxot/uXGNYReMNaxvfx0CxB2Mgft4Mjtn4qNH/hCG5RkK0bPY5WF6XC7jOFbAkRdBsDwtqVVHjS24jSctqizPf06tZhAhuS5btewOWGlei2kjDop58De/xzzqn8damrcTa9tYXSlqBFzuxJGSWBStgOuUB1nZfNiS1P6TGVk3nCDCFXsUFB/p4+5ksc6YbGnIr6UosHn4l3GG/oJKTAX1Jo0JPGX8ESx+cqWpTpzGkXXqYpg38ptgShM4JYjmwZ8H2SXWPNbWn5+Pr606CDlqXRmLpZIgT0OnAnqvLHh5IDhG1s5lIzT84sV0ofIQQcXnftdVLgDQ5kRrUFzlkYhqmZEG/eAF9IMOKq0x3JYTg8WV2t1Ph5biC5Vq4AK9tsqSuyfT4M7uFVfkERQo5EziDstXTXsHJfX7MoKTe3Asj9Q2NXSLvrcA9YKqp4lqWbMpF9ngMnwTQZGu9bZqA/UvPFhw2DcxhkpfM1tf7d8w5i/jB5DFKkWMJyjVyDZ8mEj6axLh3uZyk6rIIe2786jWERUvYdwqur9Fb+uuWxm2acLpHmL6qi1No4sLyziFX9fRnxPJmxSJzNqSz7TrGmboBPwc/DSYCSOtfRH8IqvIZ6FbglBSit170n+8JppMwfjZIUMfn d8bgBoaz RDu/mS5E9ZGJRf53P1A7G4mOpRUnaAbBCGiCx/NzoachuGyHOrMlg+MYXoGB04TzP/DrOQZ59CMuxM5e4ergMQbE1tJrPwe8MxMupJVE0InwGJ56X1vciYyQn37wysdKSix0isndYKawezrA1yrT8JDXcQYnIob3JlUkTHX9Zci1HMLx5YWMac5c7kP7vY8qlUPlENSwsfiadAGk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/5/8 15:12, Huang, Ying wrote: > Kefeng Wang writes: > >> set_zone_contiguous() is only used in mm init/hotplug, and >> clear_zone_contiguous() only used in hotplug, move them from >> page_alloc.c to the more appropriate file. >> >> Signed-off-by: Kefeng Wang >> --- >> include/linux/memory_hotplug.h | 3 -- >> mm/internal.h | 7 +++ >> mm/mm_init.c | 74 +++++++++++++++++++++++++++++++ >> mm/page_alloc.c | 79 ---------------------------------- >> 4 files changed, 81 insertions(+), 82 deletions(-) >> ... >> >> +/* >> + * Check that the whole (or subset of) a pageblock given by the interval of >> + * [start_pfn, end_pfn) is valid and within the same zone, before scanning it >> + * with the migration of free compaction scanner. >> + * >> + * Return struct page pointer of start_pfn, or NULL if checks were not passed. >> + * >> + * It's possible on some configurations to have a setup like node0 node1 node0 >> + * i.e. it's possible that all pages within a zones range of pages do not >> + * belong to a single zone. We assume that a border between node0 and node1 >> + * can occur within a single pageblock, but not a node0 node1 node0 >> + * interleaving within a single pageblock. It is therefore sufficient to check >> + * the first and last page of a pageblock and avoid checking each individual >> + * page in a pageblock. >> + * >> + * Note: the function may return non-NULL struct page even for a page block >> + * which contains a memory hole (i.e. there is no physical memory for a subset >> + * of the pfn range). For example, if the pageblock order is MAX_ORDER, which >> + * will fall into 2 sub-sections, and the end pfn of the pageblock may be hole >> + * even though the start pfn is online and valid. This should be safe most of >> + * the time because struct pages are still initialized via init_unavailable_range() >> + * and pfn walkers shouldn't touch any physical memory range for which they do >> + * not recognize any specific metadata in struct pages. >> + */ >> +struct page *__pageblock_pfn_to_page(unsigned long start_pfn, >> + unsigned long end_pfn, struct zone *zone) > > __pageblock_pfn_to_page() is also called by compaction code too (e.g., > isolate_freepages_range() -> pageblock_pfn_to_page() -> > __pageblock_pfn_to_page()). > > So, it is used not only by initialization and hotplug? > I should drop the move of this function, thanks for your reminder. > Best Regards, > Huang, Ying