From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5415C25B76 for ; Wed, 5 Jun 2024 07:53:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AAC96B0095; Wed, 5 Jun 2024 03:53:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65B096B0096; Wed, 5 Jun 2024 03:53:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D5636B0098; Wed, 5 Jun 2024 03:53:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2FCEE6B0095 for ; Wed, 5 Jun 2024 03:53:29 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D70378115B for ; Wed, 5 Jun 2024 07:53:28 +0000 (UTC) X-FDA: 82196070096.11.167FF28 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id BAC7F14001C for ; Wed, 5 Jun 2024 07:53:26 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SS84kne5; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717574006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9EYpepA/fN+ldosWhJbgAllKaScF88wlJmj8k+gnXHY=; b=511UW2k/rztZU40G5eqV13RfF5rNZ50iS74az4AcLgzdu9e521HKBnGTQC9YhoRQMnafTh rhmg4gM2SxA1pQ4R/Wme98EC4lH9btNUR1rGoxIBdSr9bpytdp10nVAWK46Aiq85WyJhYf sxwH1wdoMUeR3qbmlBB1Oa2xQKSs6RQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SS84kne5; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717574006; a=rsa-sha256; cv=none; b=CL9w7wN4MafABejdhShDOpw+o/Xl3hqpjFK8v4L1XfhAgA8fiIOzOZFUoSIDJ+y/KVGhMe lir3dKzBpj+gCGT0TLsQNi9vugV2IqolE1Ijs0x9YlXlQJpJdZ0ANV3gm7ZAxMVHAotzRP whK0hnFVs4O/OYZkrtq4/VR+OWdA5FQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717574006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9EYpepA/fN+ldosWhJbgAllKaScF88wlJmj8k+gnXHY=; b=SS84kne5i1hA1KzPPtNgQAuscHlZZU1vv5auRK1Cck+FAPnGvQ5uAfDEnTFAa2cNzVnn2Y jOlnFfkfdAh5xMsHcKdK3pxl1Q/fgEiBVNyxV1SQj7Fd9flf+vcxJeaBDOCLw8fh0BaD2O bJJUCmHVYHjwhZwilDJ3YEDUvwX/2A4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-1mKVlmpmO3qCVcI416ST_g-1; Wed, 05 Jun 2024 03:53:24 -0400 X-MC-Unique: 1mKVlmpmO3qCVcI416ST_g-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-35dc02b991eso3734878f8f.0 for ; Wed, 05 Jun 2024 00:53:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717574003; x=1718178803; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9EYpepA/fN+ldosWhJbgAllKaScF88wlJmj8k+gnXHY=; b=l/s+YJdwoCZ8SPs2kUUMrUB2APsF4hdaJYURJf2ABvbrP3i7la+XP02umT8WUZgAsE jVyaOPOr7DDIx3jpxBy+3vo0goYB2oWXJSHOl0CQzy6mcnpttZPp7c5m0L80XuEdJco5 AI1tOlurdn5qauEAW7d/zFHtYaiKl/AEQzV2ukP5DdDSqalbdcB3cC+bzCtooSiwGqkq cb0FiFToecUXCZMdLTfEu0PTYMdy+Bib4QCCt5MtArBEhL1ubjE02zpLSqXCrGNfvPxj z41/6dJbVvQOAXCqdgBdhCbPI1VHAwIjyXoJICyBejS3ohZwU5Etz0x7AdRTaeZi2Ggc oEKQ== X-Forwarded-Encrypted: i=1; AJvYcCV7w4bLhZQ76KnWcM1k3uQp/opKDqV2EYTQS2MzCT9aLNWwWy3hrSPG5ktMCsb8q6pctPzshXBDyf1vtXMG89OlbNE= X-Gm-Message-State: AOJu0YzgAxG3HTnLgHSNGuVColj4pVTtu7p7Rgh1wSGCqsK8guaxCi2a E5D0nmGArIUuJDLYHgmTfSUjNPLk7b1y0XeIk0K9vk70XOG7mnQXMgi4h6kOBPGRA1MiqLC0jLw MjcpuOLSyNB8kEZrYMDWmVk9geJMlTfUc0nPPbNBJ9dvcaVzu X-Received: by 2002:a05:6000:154c:b0:354:f7a4:5d9e with SMTP id ffacd0b85a97d-35e8ef964dfmr1450042f8f.69.1717574002969; Wed, 05 Jun 2024 00:53:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6epRicufGIhCPhgs4QBIN9wfjrrukLYcaWa9Wz6Moo7K55Q/nkkbnSEzGt5WOgIZaxrjacA== X-Received: by 2002:a05:6000:154c:b0:354:f7a4:5d9e with SMTP id ffacd0b85a97d-35e8ef964dfmr1450023f8f.69.1717574002533; Wed, 05 Jun 2024 00:53:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:3100:19a8:d898:8e69:6aff? (p200300cbc706310019a8d8988e696aff.dip0.t-ipconnect.de. [2003:cb:c706:3100:19a8:d898:8e69:6aff]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35ed8b574e3sm1264073f8f.79.2024.06.05.00.53.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 00:53:22 -0700 (PDT) Message-ID: <2a9c760e-c5cb-4ca5-8651-cc870a63ddbd@redhat.com> Date: Wed, 5 Jun 2024 09:53:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/10] mm/ksm: calc_checksum for folio To: Alex Shi , alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, izik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com References: <20240604042454.2012091-1-alexs@kernel.org> <20240604042454.2012091-10-alexs@kernel.org> <0a6603c4-ac05-460c-8bad-66813570b426@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <0a6603c4-ac05-460c-8bad-66813570b426@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BAC7F14001C X-Stat-Signature: 8sz9f6s43wjro51yjfizp33nft8tczty X-HE-Tag: 1717574006-671706 X-HE-Meta: U2FsdGVkX183IedG0B3oFukBYMUYOjkM87opOvfFmL+atRkc6MKDAo4vPcBgraHa0FrcE/mfNiSFVBTrUx+p2oNtBPMgno6cpq0dwbjUWlHsYB5bBRjhBeFwEmxWXCyHGjbW02IuvGCnf1ng5kxj88yoGwmM9yhDP86vgMk1+KJBRaMKNa8P9eSe1fFfBbaBFMyL3y0ONVQVYP96SwDi6E/0SIEBWbing8Hki44bRp1C6kJz8tgr6gjnpp5f7iBi6Was+Vmbkg/A9DSbP8cEM+NmokvdfTrEX4204iagr+A0+WUF+SicDrORcGzWu1krOnmVsJZ39v/pIxxf15yV3DtUnMNcadd87yF6TvgRPCHRXl4RBdPLKEzxdjXNZQmlSwHgHmUU0XY86r135BwGs7x6aGNql8svAUk/kMHonHR9oALy5/1Yw0WjlWpYUN2M9OQuSAA+OwOP1jtd9+3Qk4GayDP3kuAE2OQoGxx+076FGnPLel81XLUqOcQ2N69hXQMlCoULxdhRV4pFXPr7oLMi387RYYN39CR8RkSQD2dQJ3EVtZmX38q4c+XZYX1zgVE11mwMCNahhPuCh+ht5C+CsAySyx2Rws0TG9VWFSZx8JQuwj3/oBwhBoO814h9Rzmi2D+RIUFfl8ZtmzgVk04J92uYNNbVF4cCR5EzFQWaNbz5RDZk/PuN1mO/tTxzSWxWidqFE2JTr32Qabi5XW7yC/zBn2IehzzMa0Z6wo2q6vbpHuRkvrFzqNvOKP0zqeZVGlDfANz1ZA1n41KCMLqFlgdr9CEfU1LPC0sCisYVSUyYlz2V8GGCxLFUYwD0veAYEtuYTecXGWsdMCV7ZwioBmTxVfF0yevaEKxs2S5CMyP2rpXADBeqHIvWVMsNlPfo4LFLlHz99oUDzJnGTRacJlE2fDvNbl+gqY3TN/eInVYuGH8HeAPUtHWRaE05w6GohQJAgDaazT+Vsrz MzAvMGkv QnEBHIQ6cMs4qCXJlC33+m+9cM62QUeRJeQQkM01dYtXk/Ayo+W3NiPyLApW3O46ccX4MyaJ0CB32+VJ9Mf3RuF+vm0AMGwZXYeDswJaHWk5OAO22KXIrysAvUqwPuFMY24WS7Pt+fiovXXOg/d7BcjcIt68imzZk0l7lK7X0celjVq1PGHnfCfO+qJnPv5lRuJ4nmqwI5lyMX+jjbx03i5SdvDIWBEwM+6fQkgd2ZOt9faroVm26UbhOmoJxA9gK491zRlXn2LWtSsCpXoxDZ9piMmE6RxM3bz+K1mtw8KycnQrvSUYPGxGjZKAa2UShG2s63+MjL8+MYs011cAEgnz68vaRk4GcVdAvtm/TxL3lzqEvKG7vLsZnzW4D6+kywPCZfKe4VIr1LoFJm3/MZFO0IXL5mMlekWhCsUHrv3tp5LXOJKgp1KOSuh6RpLqBIIUX5oJXF2aEIeN99uvyD7wH/zTRaxIJ1xJslx5Q72JSWCxd9OZ6jvq3DWEAMcjnbUzC9nwQYQ1KalqiFbWsnb1dmACfBA/ICwBcgQFUO4ejfJcqj2Ol3K9V7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000287, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.06.24 05:44, Alex Shi wrote: > > > On 6/4/24 9:18 PM, David Hildenbrand wrote: >>> @@ -2369,7 +2371,7 @@ static void cmp_and_merge_page(struct page *page, struct ksm_rmap_item *rmap_ite >>>        * don't want to insert it in the unstable tree, and we don't want >>>        * to waste our time searching for something identical to it there. >>>        */ >>> -    checksum = calc_checksum(page); >>> +    checksum = calc_checksum(folio); >> >> So for a large folio you suddenly checksum more than a single page? That's wrong. >> >> Or am I missing something? > > I am not sure if this change are good too, anyway, comparing the whole folio may have it advantages on efficiency, but more splitting do save more pages. Calculating the checksum of something that could be a large folio when you might want to deduplicate subpages of the folio (and decide if you might want to split it) sound very wrong. Please pay more attention to the details how the current code works and how it all works with tail pages. -- Cheers, David / dhildenb