From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 167CCC3ABAC for ; Tue, 6 May 2025 10:05:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 675A16B0085; Tue, 6 May 2025 06:05:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FE5A6B0089; Tue, 6 May 2025 06:05:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C6596B008C; Tue, 6 May 2025 06:05:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2E52C6B0085 for ; Tue, 6 May 2025 06:05:39 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F0E8A1C975C for ; Tue, 6 May 2025 10:05:40 +0000 (UTC) X-FDA: 83412051240.16.6C5EECC Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id 2F876A0013 for ; Tue, 6 May 2025 10:05:39 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf25.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746525939; a=rsa-sha256; cv=none; b=7sMooq6j7mHmL2OZX3BycgjR62zf1VtnAffbhipw8xTKmtGw4hRIaWI4mfGbJoqYfIWZ23 ziDsvWtilhj4skPaGU+nhtqEZ65vMw+Pl9acspr+eIQpa044gX6WHX+EufRXY5BRbdr5xV fKAeORRpypZT+eaJVpDuROi0jc+f1rM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf25.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746525939; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O93la1WGyI+VnhBtkGgEAAHk/pmN1JFxqNXja/4wWOg=; b=Nn+Qs0e8E8mhSvFvpvzIwpqSHw5LbS4PFn4fn/3UNAsYUnUh4VmwInhyLg5xuoWM78nh/y JIEKjfxj5ls7XxKGuFA+pwpYcZcS9mM91Eo5BGYtbkydK6KZMAEVuS6gmoJojr2kkS29WR oZIAHO3JqrsWfpqJ7sAmsUIRNfO8MJ0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B1D0B113E; Tue, 6 May 2025 03:05:28 -0700 (PDT) Received: from [10.57.93.118] (unknown [10.57.93.118]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 158083F5A1; Tue, 6 May 2025 03:05:35 -0700 (PDT) Message-ID: <2a90ec6c-1725-4c32-8819-c46e8c0e4630@arm.com> Date: Tue, 6 May 2025 11:05:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v4 0/5] Readahead tweaks for larger folios Content-Language: en-GB To: Andrew Morton , "Matthew Wilcox (Oracle)" , Alexander Viro , Christian Brauner , Jan Kara , David Hildenbrand , Dave Chinner , Catalin Marinas , Will Deacon , Kalesh Singh , Zi Yan Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20250430145920.3748738-1-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: <20250430145920.3748738-1-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2F876A0013 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 1jfs37fz9czh6fcrmus8sxoz7sj1k9dc X-HE-Tag: 1746525939-984734 X-HE-Meta: U2FsdGVkX1+h1RAjymuO7WBbm09W+sqxMXafGnrr+WvQQ+5aEqdMeM7239Jhch48LKt2ZD3cT+O+3IzmUvuWXolfJe1Z6kxrhUj1jybSljsV5JGPppWwifwp1UGfS0CdHu7hI81I/a5ZhGon+2XPS/oziy9aTB9ElPWzdxlF51D96MTVXCWKWyCjdhWigO8ce8Td5iD5EtvCIHdmttFqvEl1C14LTmqaVb7dPwlm7hcs+Fh8QYVIhvdXrapJxdTWPCMvvrT2oXRpKecWq02HxL1475DPbv7BZ7xcGfo3FFthHpCXAhF5YQJW3j1pFWIsHYitD8LG6F/cHMyayxINqlzCf9yBumGEIAdDNgGkYV3g68sPykqREL6fyfRTY9SeeS1buinf3S1oO3S3fsgFtXa71H5sDDoFFfSzyJG/b1/uWQH5fjVJukV5bm1R6HzETlJDV5p5yCY3Aw5lyTcy9bDKeDkF67OwNjc5EsDeHT+XXdJ9MdtfzwER48836kiP0cC+0NCCVe9oq+xWNYXUHo4FB7yx5ee952P3vKOC188HDwKVdP8NsU1mxuuHCBqB1qDKU0cMYl/7NW8k1Zx1RnOdYFU6NsbHvYnextP8m/xIuXCCXMZk4H0wlV6JGFF/QImV+MnnPQ2ZqwEyEDxjWAO04QZR7kwTAtXyM0XJBadenuo8ipLR4ZTaAb/Uo9ySahTf8SCxraqwrZHhOA8h7XSaG9fD2px8M6CUKEbDABdSSKiGeM6WeipngM0vUK4aO1TaRHCtC0qq+7WJde5f5NcoCCbhnZTmTedRoVuFIcMOxyW7ucYTcAlKEHrTbDrZ6m05ubq1abfepgwX8/ZhH6fzsnOnl9fgfng5IkfiFE3FFFXdMbDhOmGQwX3Hgt1O7z9AT3usQLh8MjG8Jm2MUgXTb5BysM3LdoKfZENb+vqaW77Cv7STnTl3gAp0PjLNvuYv5c12nll7sQNq7G7 A9hsWYIi ob05zkpnEEU/UTdDNsnJ4xcg564JHP3qfuors4FHJvABizYRexPOV8htXKHVkxMlMNsrqGW7zSouFeEw7LtR2kktmdXlBENCIaCzCkABtsUJGmX6K3NFasSpDm72bvKk3wJcZ2922BtqTi9zqaI+nAA7ucjmqMOh2R7Y+Hiye2JRDZZpo7qBH6/b0suSJ5bVXLGCUB4yi+didFKrXNMajNDeZ8XftC6oef0FL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30/04/2025 15:59, Ryan Roberts wrote: > Hi All, > > This RFC series adds some tweaks to readahead so that it does a better job of > ramping up folio sizes as readahead extends further into the file. And it > additionally special-cases executable mappings to allow the arch to request a > preferred folio size for text. > > Previous versions of the series focussed on the latter part only (large folios > for text). See [3]. But after discussion with Matthew Wilcox last week, we > decided that we should really be fixing some of the unintended behaviours in how > a folio size is selected in general before special-casing for text. As a result > patches 1-4 make folio size selection behave more sanely, then patch 5 > introduces large folios for text. Patch 5 depends on patch 1, but does not > depend on patches 2-4. > > --- > > I'm leaving this marked as RFC for now as I intend to do more testing, and > haven't yet updated the benchmark results in patch 5 (although I expect them to > be similar). Thanks Jan, David and Anshuman for the reviews! I'll do the suggested changes and complete my testing, then aim to post again against -rc1, to hopefully get it into linux-next. Thanks, Ryan > > Applies on top of Monday's mm-unstable (b18dec6a6ad3) and passes all mm > kselftests. > > Changes since v3 [3] > ==================== > > - Added patchs 1-4 to do better job of ramping up folio order > - In patch 5: > - Confine readahead blocks to vma boundaries (per Kalesh) > - Rename arch_exec_folio_order() to exec_folio_order() (per Matthew) > - exec_folio_order() now returns unsigned int and defaults to order-0 > (per Matthew) > - readahead size is honoured (including when disabled) > > Changes since v2 [2] > ==================== > > - Rename arch_wants_exec_folio_order() to arch_exec_folio_order() (per Andrew) > - Fixed some typos (per Andrew) > > Changes since v1 [1] > ==================== > > - Remove "void" from arch_wants_exec_folio_order() macro args list > > [1] https://lore.kernel.org/linux-mm/20240111154106.3692206-1-ryan.roberts@arm.com/ > [2] https://lore.kernel.org/all/20240215154059.2863126-1-ryan.roberts@arm.com/ > [3] https://lore.kernel.org/linux-mm/20250327160700.1147155-1-ryan.roberts@arm.com/ > > Thanks, > Ryan > > Ryan Roberts (5): > mm/readahead: Honour new_order in page_cache_ra_order() > mm/readahead: Terminate async readahead on natural boundary > mm/readahead: Make space in struct file_ra_state > mm/readahead: Store folio order in struct file_ra_state > mm/filemap: Allow arch to request folio size for exec memory > > arch/arm64/include/asm/pgtable.h | 8 +++++ > include/linux/fs.h | 4 ++- > include/linux/pgtable.h | 11 +++++++ > mm/filemap.c | 55 ++++++++++++++++++++++++-------- > mm/internal.h | 3 +- > mm/readahead.c | 27 +++++++++------- > 6 files changed, 81 insertions(+), 27 deletions(-) > > -- > 2.43.0 >