From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B7D4C77B7C for ; Thu, 3 Jul 2025 11:12:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85F65940008; Thu, 3 Jul 2025 07:12:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 836E1940007; Thu, 3 Jul 2025 07:12:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74CFF940008; Thu, 3 Jul 2025 07:12:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 61AB5940007 for ; Thu, 3 Jul 2025 07:12:52 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C556016012F for ; Thu, 3 Jul 2025 11:12:51 +0000 (UTC) X-FDA: 83622690942.26.3335C4B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 4DF031C0004 for ; Thu, 3 Jul 2025 11:12:49 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LUSrjte3; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751541169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DJULFj6wqOcrY+vDTEpJn97vOwi/Y1SVapHFqg9QnZs=; b=FM6hDeE8TDn4GLzeqqvufXLu0PoSjZHpL+vaQKkLMEZZmyzoNbC9p4Tf2oGe9EIQB/5Cjt quLoxqML5zblr1SgAA1UtYeg0XySP17pR7BdYUcZth4QyrBB4WLNIcUfHlbuYUocrTMHdP /Jajoa+XCkm1ULVxvXK5RLoUn9FW7L8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LUSrjte3; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751541169; a=rsa-sha256; cv=none; b=Bn6SU2AMLrnjhkxuSvmUgn9VuiGlg4LJE0ThT9c1o0mrhS6e1hSCRlhTbGr6NXuyoiwWT/ VmYXPcMypcWma7UMmhM0iTHmmGVS+iSSmJ1A4iBMIsgwslrYeJVdiu67PQDu9wXGrt1GD8 CbK8LqxBdw9sB044lpF7gTQd+VCNFf0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751541168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DJULFj6wqOcrY+vDTEpJn97vOwi/Y1SVapHFqg9QnZs=; b=LUSrjte3m6LWVQSe2wR2VEzp9bYJ22ytevWrKTAsrzDb5Y/iy1xS63b+JSmmrDnD5URtBU t05BINy4zQHbvL3CwD1pHD//18DuuydGU//6IxAgsdIzL5hhPtEfkwcw2kkaO7ia4pFT+U uexkScNjP2VOYk8IthWFBTQIO34PsJE= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-UyDYnyzIP6mVFaCyr3lpmA-1; Thu, 03 Jul 2025 07:12:47 -0400 X-MC-Unique: UyDYnyzIP6mVFaCyr3lpmA-1 X-Mimecast-MFC-AGG-ID: UyDYnyzIP6mVFaCyr3lpmA_1751541166 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-60c4f7964c4so3978146a12.1 for ; Thu, 03 Jul 2025 04:12:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751541166; x=1752145966; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DJULFj6wqOcrY+vDTEpJn97vOwi/Y1SVapHFqg9QnZs=; b=EMGt8u3XfTN4nX6zS1uKBH548k6Y9Rzdqfo8EyckLV4MkYhbzkKG4unZJFusp400U9 jlkf1kqKs4BG09B0Oc4p0D6ozOIpx7IE4rfTKnibknn8oEOnWSAgnChGpkGy894FQGol N81qiWzj/YBMtPQ9p00CvB73r25FRmWYUK+0w5yuwnszxu496S1Ddbsh0nVekrKyN6eI thbb7zsLZ6X7LDpgv4u1UqQ433tGm9uKcIIKNxB3YGo1X3Fxlr2jcFqRe3EWyZq/9y4A JwjYGiHzmG0Bq5apLImEvx9bE68DaOOXN3asCkqZr0nFV2SLJQ1Hak09Z1s9kHTaUNXE XL5Q== X-Forwarded-Encrypted: i=1; AJvYcCX8IpcE+4krlELynP+EdKJky/fBwMJb0iVV+km9eu1rfgmApAI1cu6uE+zirfCDbvyKS6iYJkVJfA==@kvack.org X-Gm-Message-State: AOJu0YxIMk40jTCHDhoQsOx20gnOao0IpGZozdY0D53sIil2jSfEN6N7 StB+bkxc5PKWA9fcuAhGFWU6ZfLjjP4C2VSb/fk/7vklJhyNYy/Kfeuc1KGnXCjxI2BHRprXJxc x8GSchytYPQZf9QTUIzkMF0HEHnU79Vl1jsFqVHpjsWj3zTqM5V1B X-Gm-Gg: ASbGncve+SxCwbi+y2y42tN8r+IOh6nKyFuzk3XimL3pZ0TyCnAsTkoVrBxbJdXicm9 FdgWrRNAfHruJxoUtBSryOK3dbSHkS9+VNcvM+8eHkPg1C1Wcglb0JLKvhf8bcHZKeWzyZzvAom s14WBIePPuFa1VoJm29lA/0YzOHzZ3zE5NOk2wXe+VJ7qZTQCasNZi9CVIJ8s/W5G73+/etaS8w OD9PE19EhKX9q9oIDO962s970xi9unc6tjxVR2htJZ8q8Q8FwwJPnF73TtT0WFjeLaaWVu5RBiG B7T8V4TXMw82Zv99U3HyahOMZ3EwVNe6cDj55jaVBCPX X-Received: by 2002:a05:6402:51c7:b0:60e:e4b:b8e1 with SMTP id 4fb4d7f45d1cf-60e53619aa3mr6146124a12.34.1751541166121; Thu, 03 Jul 2025 04:12:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmkbrOy4GJgynfnWcYtqY/OCsyVeNZLRBi2bFK6slD2Wi4/tuG6coxBbIpbqSdQR5k1e++2A== X-Received: by 2002:a05:6402:51c7:b0:60e:e4b:b8e1 with SMTP id 4fb4d7f45d1cf-60e53619aa3mr6146094a12.34.1751541165673; Thu, 03 Jul 2025 04:12:45 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60e22a7b726sm4819126a12.80.2025.07.03.04.12.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 04:12:45 -0700 (PDT) Message-ID: <2a86fe49-6583-43c3-b4ff-1f2ce2de1630@redhat.com> Date: Thu, 3 Jul 2025 13:12:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] cma: split resrvation of fixed area into a helper function To: Mike Rapoport , Andrew Morton Cc: Alexandre Ghiti , Oscar Salvador , Pratyush Yadav , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250702173605.2198924-1-rppt@kernel.org> <20250702173605.2198924-3-rppt@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250702173605.2198924-3-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aAcq3nUu5ywxJo4kFwveyrd8LE2EGyTQ2jPliB0jP8M_1751541166 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4DF031C0004 X-Stat-Signature: gdropfhwqrqrx6fpk9ehxz14cf7af5ed X-HE-Tag: 1751541169-308585 X-HE-Meta: U2FsdGVkX1/MU5Ao/UCplO5gp1JUFXxBT8u9H3Jq0f6FOs30H2XO8O7UTozWq9SpcgCZBoW4VA+zFzRXiowJGtLeha4IXY3oQIy8TRpQL8yh0gSDwYI7MC927CL/UGqmyYdvmMXtb/dkaq7SmYoUcn15jz9nGK+ueYCm4quNGtySH8Rx/jDJA7sFC3LYZF8O2bb70bLXwxqT8h7EQ7jmQZtvscmh0EanPmzudZUhj6Z/NVN7+hbRcf6mXNuJ8PusU7hljnZHE5Y5mlNjS+LgzrD0N0LhnVMvnsT7lQ0d+/NANoAqkNc1m2a5AZtFqncSHToku76kRh7EpNg5FQRDU2blrJRxLgNtTiQczt3XRBQg3+e4zWMYmqK0RhHlOOVQVtMax8eG55ocT2ICuj51qgA2OGDRt87/fISD1CMPVmLpaoPwSmwi0J8GzAEo5/V/FAPihP4+TYU+tow2+dBanU0TXlFWxq5qFpNw118OCQbj7kbKsaw3k8jNLKRZ48wdCLH5mk/LhAyxBM5+HYe9CKwua4x3VnE9k/fWZGUGE4XcPjReNn/BL3twwWBvRK66A1xfE6vnXcrS0+ARnwulJsPpOcu4QfZFI1r05kR/RQSKCM83l9/VXbsmJLOK7Um7Y1aTA961cqtPujfQ0SHH5YciyzVDMKvNSXzYC7/nQmu/yd3eFRTHpGJ49Yz84spPNzGFZi8qda01sKbkUuhK+1hh9uI8KjcYlBCR0+tEBKswTdGl0yVhJMSUPknTNpXDFE/wH3nQBlJGdfV2AgY8u4MmGqj0nEDC9fmOIGSXrJrWIPZIxKcazrjLXup6/1B394fCPN1NMsxq+eQGR2laHFCYddBwdiupThkEg25W1Hwi3hEaCcnGULlNQV+WhW1V728WgnK+sEdeXvUtvPNTUBkKcWvFw1tNYyUwjrWlw9VBUeTs/I6IKeZ7LNRqX7FfSST9/eYZEEeWOjqhIUD S9mmQztT ASUfudkfeAw0X+eSipFN2tgGyey8WU9v/5F5lJrWV6Wi7BqfFAJ9n3tuHVPQWcP/rbceNdxQw0nv0/y8z6y3OCMwweKEPONEkm8C7ou7Y9bDil8VswH0PtGliJZ2DoaX9ivKbdUrOyPcJiMsoD3E1O2C+/9Yk3u/CiAJ76QHfTAIP7rcS7cq38t1U80CaE5rSRh37WfFdybD+u3qccsaqtdt7ztOckBkbaO1iOQfn9bgzYQIBtIfaDhJTjMsskZLGm2sdApmGNrgQDliLE+mycd4X3T60ZrDsDWqEBek+ZNH9S6nJpCF07ZoJpjowHT/mZ5h1f8uezu16etHpLA+msPaZZUbtYkgjPCS2c6fTs1X8b3Me76Rq3j1O8o93UFgMV5oiZyn2aWz0+YudyHp5tOHilwXmWfvN7TbZ+VAdl+jwrgX0t5EHBYnq+/iVgr8Tk6fU8t7ls0I8VU9d/hpllZiIwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 19:36, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Move the check that verifies that reservation of fixed area does not > cross HIGHMEM boundary and the actual memblock_resrve() call into a > helper function. > > This makes code more readable and decouples logic related to > CONFIG_HIGHMEM from the core functionality of > __cma_declare_contiguous_nid(). > > Signed-off-by: Mike Rapoport (Microsoft) > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb