From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7444FC761A6 for ; Mon, 3 Apr 2023 13:07:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0D7E6B007B; Mon, 3 Apr 2023 09:07:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABD176B007D; Mon, 3 Apr 2023 09:07:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 985EC6B007E; Mon, 3 Apr 2023 09:07:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 89A526B007B for ; Mon, 3 Apr 2023 09:07:39 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4F902ABEB0 for ; Mon, 3 Apr 2023 13:07:39 +0000 (UTC) X-FDA: 80640106638.21.CE32D46 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf30.hostedemail.com (Postfix) with ESMTP id 27D7B80019 for ; Mon, 3 Apr 2023 13:07:35 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VWqebsGW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=h5q3i5np; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680527256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HSoJPiNm6YLdrvyBCRNcHzBUr7oKAdacKl0GHdUtJXA=; b=7N9np69tne2rImTaSlwnI8/loLfM1X/bN1xfq7B1D+mFnMpUP678oAZ67Zhab97RDYntF2 6CQy1PC05Es1yXxY7IUmCXXsNwdqEIVCQMDuypNwTbV7e+mnYLL+dDNWPkUVATsvBBYwIq /qOEr2BuxKDy2+r0iO2zz28U9oPaJyE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VWqebsGW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=h5q3i5np; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680527256; a=rsa-sha256; cv=none; b=VT5vJtWSP8t2Bqy/snLchuh05JzxzFOYkGc5cihNy1OMuXyO8rmB3d6M+RBmCfZGc+bvEo sZ66ulaf3tIH1F/93b9j5gklbRHxnSqZYJj/OogOB0/NdAn2RwkvzVYELQ5uVrDDG3O+pR 7NJvXobM092hIvyHRahplS2JMKeweLw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AD36E1FF6E; Mon, 3 Apr 2023 13:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1680527254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HSoJPiNm6YLdrvyBCRNcHzBUr7oKAdacKl0GHdUtJXA=; b=VWqebsGWD8RAUsjZeeaP7K5SjdgTlp5fwMlBEgdMdHT4jVR3zeZ2tQhOESTQ3eQ0KKwUfe 6LqMQ1DTNheF5SqznhydptvbvXLXMBajFHSA6zry0wxZqbEJ8wjaJCDQTXeVSxmKPTsUSy 4nJLJVkcm4u7gVWb/VXyAdsRyAhfv8g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1680527254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HSoJPiNm6YLdrvyBCRNcHzBUr7oKAdacKl0GHdUtJXA=; b=h5q3i5np2j574eqECbyNVp3f1IFao5UeZNBpPDfBsYuTt2l+15XRQsVsYhXLolIoF85mlX ouTblE3ueplUupCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 23B561331A; Mon, 3 Apr 2023 13:07:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id adnlB5bPKmS5YwAAMHmgww (envelope-from ); Mon, 03 Apr 2023 13:07:34 +0000 Message-ID: <2a8278cf-d282-ada6-0161-3b9c6adcb12e@suse.cz> Date: Mon, 3 Apr 2023 15:07:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCHv9 02/14] mm: Add support for unaccepted memory Content-Language: en-US To: "Kirill A. Shutemov" Cc: "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Dave Hansen , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport References: <20230330114956.20342-1-kirill.shutemov@linux.intel.com> <20230330114956.20342-3-kirill.shutemov@linux.intel.com> <43234108-fa4f-7583-e3b4-2daa2de89fb0@suse.cz> <20230403100244.4sre7ki4ccusiiul@box> From: Vlastimil Babka In-Reply-To: <20230403100244.4sre7ki4ccusiiul@box> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: bfgurkozmrg1wwbyooq6u6k9umokzxfr X-Rspam-User: X-Rspamd-Queue-Id: 27D7B80019 X-Rspamd-Server: rspam06 X-HE-Tag: 1680527255-156007 X-HE-Meta: U2FsdGVkX1+XGYSWyruQuQdhdtK6/j0Ige6ldXV2kM+DtZE4ZO9KLeMg6o/lLmMWnn3MNtzHQ4IBBTY6tYj8+17B/2XuVU8C0rFIetlGbxoDJ2r6XixcJwx3mu0dcQQCWbsd05lOwMg/hh7uqSfq8Rb//pdhcEfwJWMKnYifKdilcwLv7kuA3BnnIRPy4wIDogJ3Gbrfd1xMHMfeaAJBtn20KZnk/N4knbyKlcFBCxLw6qOfWgwuQv8gu9Pjz2nmCJiM1G9gqJ4w4053wHb21desQbFiTC/1du+R7bClJuECbcA0rfi9R8LRN7kjbks/iWFlaCQRl4p16iT0El5BSezCpkdbcR6NPztaFLOjB4KZ6kB5CXpBv5pt6Fcv9wHWlv7lh4HBDS0oV8DS+RBOpUqwoXlG70tCj7xtJLMqNAFZXncTnQ5yxmyIF5MAc4P5AnVzdQPdItD7XF7krBmb3bDE+LPX4BftOGrrGXyeDi5AN8xanl0EdrM4j2BVCweKxNOzHJvn4WdxXtcAOmzzc3VANN8d1dseTLRyGXtvIVoXu2cBgFi6g7fyyvDQfoUl12oq1sZJDpQGxd/NZgmBHq4mfNluN+fyn2zQY5S5QBy5YL7S/u6Kh25LE8JtoM05k9b3YZndyHY5w7fOiykagek3LrttBon/S8xz245O8p9WKAlGq+iglTiSsnCz+TvrJiXvwlb6RxRqN28c5A1k63VcmnPwKntpqOzDcLam4CxCfmvqUABb/0XxEj47rp0bCI0pItqf/VhHjvhLT59Cvt1Rmakp8a3tTYJjDvwo/WejD+X/fVY4+DVSUAiDG6GulAcHwmMfy8dSPTqOFF/6Ay6WukncvvRd1YPuGnF+08zovWHMDl4IgBlYME1Zvnz/MXBu1f1yUKMomIg8UsvYE05n2Bk+eOXiHLxPzbN7engSXiGHFPz3kUHNutaQlYYYg/g+wrRCOvzeAwfipFQ M/Us9fwJ S7w2fcinkIHb5iQj7GJAXZXSkgqYWrqngOkXHHglE2zBr68c2XGxsMRgtx42KZ8xLIuUk9kQF8LLvzJnPhiSeHe1vOoH5u1m0+9jRd8LX8ZC6crscfNkaoR1vrfUOqY7gzzOu/qP4H6zzrHTfNDEp16i43qUmqJmxqS3e8bul0p9tskAMKbBvk69BTYPr3MFqMD5JZV/aq1bCOtOgMCQJ+YyGeYDrKnPSq5ldz8dX4xEqdF/M1IDfbsEgn2ic3GG+ye5IJN5PT8QYW6M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/3/23 12:02, Kirill A. Shutemov wrote: > On Mon, Apr 03, 2023 at 11:26:53AM +0200, Vlastimil Babka wrote: >> > Signed-off-by: Kirill A. Shutemov >> > Acked-by: Mike Rapoport # memblock >> >> Reviewed-by: Vlastimil Babka > > Thanks! > >> Just a small suggestion below: >> >> > + >> > +static bool try_to_accept_memory(struct zone *zone, unsigned int order) >> > +{ >> > + long to_accept; >> > + int ret = false; >> > + >> > + if (!static_branch_unlikely(&zones_with_unaccepted_pages)) >> > + return false; >> >> >> This potentially (depends on what compiler decides) means we'll call this >> function just to skip the static branch. OTOH forcing it as inline would be >> wasteful too. So I'd split that away and make the callers do that static >> branch check inline. Just as deferred_pages_enabled() is used. > > Like this? Yep. > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 07e16e9b49c4..80fe5e4b6cca 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -390,6 +390,7 @@ EXPORT_SYMBOL(nr_online_nodes); > static bool page_contains_unaccepted(struct page *page, unsigned int order); > static void accept_page(struct page *page, unsigned int order); > static bool try_to_accept_memory(struct zone *zone, unsigned int order); > +static inline bool has_unaccepted_memory(void); > static bool __free_unaccepted(struct page *page); > > int page_group_by_mobility_disabled __read_mostly; > @@ -3464,8 +3465,10 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, > gfp_mask)) { > int ret; > > - if (try_to_accept_memory(zone, order)) > - goto try_this_zone; > + if (has_unaccepted_memory()) { > + if (try_to_accept_memory(zone, order)) > + goto try_this_zone; > + } > > #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > /* > @@ -3519,8 +3522,10 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, > > return page; > } else { > - if (try_to_accept_memory(zone, order)) > - goto try_this_zone; > + if (has_unaccepted_memory()) { > + if (try_to_accept_memory(zone, order)) > + goto try_this_zone; > + } > > #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > /* Try again if zone has deferred pages */ > @@ -7302,9 +7307,6 @@ static bool try_to_accept_memory(struct zone *zone, unsigned int order) > long to_accept; > int ret = false; > > - if (!static_branch_unlikely(&zones_with_unaccepted_pages)) > - return false; > - > /* How much to accept to get to high watermark? */ > to_accept = high_wmark_pages(zone) - > (zone_page_state(zone, NR_FREE_PAGES) - > @@ -7321,6 +7323,11 @@ static bool try_to_accept_memory(struct zone *zone, unsigned int order) > return ret; > } > > +static inline bool has_unaccepted_memory(void) > +{ > + return static_branch_unlikely(&zones_with_unaccepted_pages); > +} > + > static bool __free_unaccepted(struct page *page) > { > struct zone *zone = page_zone(page); > @@ -7398,6 +7405,11 @@ static bool try_to_accept_memory(struct zone *zone, unsigned int order) > return false; > } > > +static inline bool has_unaccepted_memory(void) > +{ > + return false; > +} > + > static bool __free_unaccepted(struct page *page) > { > BUILD_BUG();