From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B6CCC4345F for ; Fri, 19 Apr 2024 02:07:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3041F6B0087; Thu, 18 Apr 2024 22:07:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B3A16B0088; Thu, 18 Apr 2024 22:07:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A35F6B008C; Thu, 18 Apr 2024 22:07:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EF5C36B0087 for ; Thu, 18 Apr 2024 22:07:34 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 562C11A07DC for ; Fri, 19 Apr 2024 02:07:33 +0000 (UTC) X-FDA: 82024644786.25.395FD91 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf02.hostedemail.com (Postfix) with ESMTP id E08438000C for ; Fri, 19 Apr 2024 02:07:30 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713492451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jw/7lObclQzi2xFvGX2GLTNWCdMcViiu85+EDNJM9/c=; b=YqavQx5ycLH5DyyFGaRhdvnngoFY4p7neC3d5d5om9neushRWqxljtAM5G0Yl9cOBn6Rpk 6Lw60qFAP02vj9TYGRQYG584W0GSQsHJpj1+/B1/I2b0Qps6OmO6N33gCSGsIJriJNwZFm VWp0Tdxc4QVvK57QfCt6UpdnJ86wWUU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713492451; a=rsa-sha256; cv=none; b=bPYdHDMA7fLHo8/SzgBFlXOdIi38nToZ8/kZtqO014OD1A6BQ2FPed70VI2IUYa3CVhPDQ 1lgxi2zIr3sCB693nOm9hhKFJff+ib5Gy4wG1IRg6mkRvACVPTIa3y5LxiCflp1hA8xB6a 6blEyf5XEirHmh9xx2bIZpp3evRgs1E= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VLHyS4KwRztX4s; Fri, 19 Apr 2024 10:04:32 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 4EA871401E9; Fri, 19 Apr 2024 10:07:27 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 19 Apr 2024 10:07:26 +0800 Subject: Re: [PATCH 2/2] mm/hugetlb: fix unable to handle page fault for address dead000000000108 To: Andrew Morton CC: , , , , , References: <20240418022000.3524229-1-linmiaohe@huawei.com> <20240418022000.3524229-3-linmiaohe@huawei.com> <20240418133817.afb65c8dcd11cfea7c686d25@linux-foundation.org> From: Miaohe Lin Message-ID: <2a7c22c6-edda-e113-4688-f728b4f2d65c@huawei.com> Date: Fri, 19 Apr 2024 10:07:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240418133817.afb65c8dcd11cfea7c686d25@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E08438000C X-Stat-Signature: mwebwhq1rzj6msr931nh4j4ozjmp95b7 X-Rspam-User: X-HE-Tag: 1713492450-516677 X-HE-Meta: U2FsdGVkX1/hjnEGvcHcvUnHHF/Q/z/Fs01l8B6fQyhlWPqvq1ka+fC0lMDQv3ZfD5aakO1GyrgT1/mtac0tS/8c2JxObyJYJyvvF4j/TLk69VqAewP09E0r56LMvc0RvF+Sj1Kdm0lzrTBwyuOc9pqaPPhpgB6Fc5hD+Ekal4h4iijntpAQD/67U8VoZLqUyRPfZC+LtRO8fn8tKN0+ORz3hyPUXHJOChVsLopsZ0V5mrwi4PLphWWzxsBxsigzb0JmCTBrvhKyLF6rZkwqSejrKLPFvwNBfCSfQeQMbcqhlrpA5+Wm43ZyYBnJwBNK/COnuqMw39CprBNR/D3y11zMMETv+E7twzd6WWd4QvfQLVI7QdZkqMGISHhZgFo9oaNmKzzSY3Cq8Hdcls0IkjAcolDInnZ8RDihOxQZ86ML7QX/XmHS51eIPPXJutuesC+seHjP5/JdWAsO/PdeQSSFJbeGXLL5TAbxSmiS5fOcoR9vpuji9Wa0r09dUzpHSZeZFdxIy9PaFZIVlYLqdViEUx4MjK3U8a1qDTlhsrovkUE7P8ElGqLsguRCbAIWtsz8yvlxiLkf9IzI50sppQx9r8gEGXWkCHW4uM5XwcuzIM3DF84pyzuBprotKRaAL1feoit5V9/Wk9lSXFa6az/aeU42B463flbOKH0Tell+z/ssoAo/KlluaAh7xp0GXyl3FBplY5QiCh5Vc4L4pFb8dqqIDMdvyZjn0JI+nWrzyD3GKnwbNncWNgnbtzwxWwKQ5YUP7lq8O0rQMwRtWWq5rNOGWGDNEyl567g8Jw8+ssgcL2+iyrPzHD2yxM+5VoQsv+ru20DHVnTv36IOuXdabnu0g/UxI7pDftyrIvKCU8gbJK9bGIPHI8U7wZ1Ftcv8s48+6Gw1q5Ve6WlhENEgLal2PsVffQakKuAjFcds168WblEjaLZHe3tjZGKv+bwE1WYw9/ymADvztOq kXAuJNUX fpX/7mRxVpN5CDeqhMadrbYh4FzL4iC5EJMuWfiog7E0nRimf/6CcqDzv7sX+2ArtKMcZjsa5oOKZISeEoxpeldtZRKlIByQIRpQCbwfYeRe/E+mW3OeK+lL8u/vJAP6xNd+RqYDu7diQLqX94Ur03sZQzA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/19 4:38, Andrew Morton wrote: > On Thu, 18 Apr 2024 10:20:00 +0800 Miaohe Lin wrote: > >> Below panic occurs when I did memory failure test: >> >> BUG: unable to handle page fault for address: dead000000000108 >> >> ... >> >> The root cause is that list_del() is used to remove folio from list when >> dissolve_free_hugetlb_folio(). But list_move() might be used to reenqueue >> hugetlb folio when free_huge_folio() leading to above panic. Fix this >> issue by using list_del_init() to remove folio. >> >> ... >> >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -1642,7 +1642,7 @@ static void __remove_hugetlb_folio(struct hstate *h, struct folio *folio, >> if (hstate_is_gigantic(h) && !gigantic_page_runtime_supported()) >> return; >> >> - list_del(&folio->lru); >> + list_del_init(&folio->lru); >> >> if (folio_test_hugetlb_freed(folio)) { >> h->free_huge_pages--; > > We should cc:stable and find a Fixes:. This appears to predate > 6eb4e88a6d27022ea8aff424d47a0a5dfc9fcb34, after which I got lost. It's weird I didn't observe this issue before last merge window while corresponding code logic seems not changed. I will try again to find a Fixes. Thanks. . > . >