From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6DA5C67861 for ; Fri, 5 Apr 2024 14:56:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A1D36B0088; Fri, 5 Apr 2024 10:56:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 452286B008C; Fri, 5 Apr 2024 10:56:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31AAA6B0093; Fri, 5 Apr 2024 10:56:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 12AA46B0088 for ; Fri, 5 Apr 2024 10:56:36 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BBCBEA17EA for ; Fri, 5 Apr 2024 14:56:35 +0000 (UTC) X-FDA: 81975779550.08.F716327 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by imf12.hostedemail.com (Postfix) with ESMTP id E34E740007 for ; Fri, 5 Apr 2024 14:56:33 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=LCrjDdKL; spf=pass (imf12.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.44 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712328994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eVVvp+398iheOw5gutAtm6G0zLb/uxNorrWUv4KFnio=; b=nxkMTugfJ1g/y85wvZkwnj/T1qqG2EmYGo44Z68zJRSw9HA/D9+kVlFmNcbsoeMcMILlD3 ss1jUTwgZszxGx4Gie1mWBdR+fU74lsdfhUB0NuBw7ASdCEO6c1nZ3G53y2K0ndF45SfPF D/NkDjwmbrG1Zj9aXV62aG4/glATVbk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712328994; a=rsa-sha256; cv=none; b=kbDtHdGzEbtdUpabSci4Bta9W8jOIVdNufkJOvInxIaS/prrcOZ5LqE5JoAoOqmeVqfxB8 ehq1kmvqqmxwHp9xiPjiIIfVnFOfq6KlVgNNOkpzW+alRwMN2i0u7A1Z+vHvYSLuZ7oRwS 5u1uvGyx8BnjM26nuy26A1G6ZD7mWuc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=LCrjDdKL; spf=pass (imf12.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.44 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-7cc0e831e11so45833539f.1 for ; Fri, 05 Apr 2024 07:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1712328993; x=1712933793; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eVVvp+398iheOw5gutAtm6G0zLb/uxNorrWUv4KFnio=; b=LCrjDdKLmwltm4bJS9A0gM0XWNRKVRVOkISuIaKoaFd/0TEzMsJPkIJ48n/HWHIR32 /IelbREz18JMsoF65Gl1wcF91dAd3hTwnvMwI/VbfQO8cJ/Hy7tQYOgXIUCs4gVUCGUC HnMwPKrEpaBdAArmsamC9ywoHZHMmWWJ6H5mA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712328993; x=1712933793; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eVVvp+398iheOw5gutAtm6G0zLb/uxNorrWUv4KFnio=; b=nKVRmfuC8VvY9y/pwJbJ/AaIpctPd4BkwElmkTSMWpOU28EIXoMB23wl+1HmVc1fDo 8We2df5KUKeajs56BLWcRNjA8vEQvRQM565JbxFS4MrZAcy9nzx6emCnzqxxbFL0I5GQ xf5sP9K3XR/809xAESvaAxFKEIGMMM5T4QQrpwhe/hBiFHrrkNOb/oF+6hXQaOzQHOnU 4LXIgiiV4WYQbSdjf4vE4TXqUbyCkj09w6hjjmmyd/x2riwE1bbtPPDqNMGhNgLB73EZ GAkZ90kJT20oLSYcR89mi9FGP4eJDVoTkVVXMAsHqCctdbz5lxxlK/nTo0gYaZ5Q3v9i CwPg== X-Forwarded-Encrypted: i=1; AJvYcCU4XM+6+ILZFRcyt6zFuPFpdrq7bz+5D6BisKJioeX2Tvuxmy2zXbhgFN4X9CgL/rhCMUs3iylCkXErMShFr9aKzJ0= X-Gm-Message-State: AOJu0Yy9q2aF6gXH1W4HdkF0pI07F3l9yM74Ywj5PuAzDpLKa1uOb08d AXTnZHhyBCYj3kWYXeoInV+J+B8i4Riiddu7M8se3n871OeG7wQf5VM65atRvm4= X-Google-Smtp-Source: AGHT+IEkdy1rdEG+rjc30ywKaQ9qlK6/njmx8r/DcDzK1jQaFuF4ReeRun+a1EcXGR4eE0eknNVLJw== X-Received: by 2002:a5e:c648:0:b0:7d3:4ff8:7bb1 with SMTP id s8-20020a5ec648000000b007d34ff87bb1mr1694674ioo.1.1712328992992; Fri, 05 Apr 2024 07:56:32 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id j4-20020a05663822c400b0047ad636c705sm601613jat.73.2024.04.05.07.56.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 07:56:32 -0700 (PDT) Message-ID: <2a77adeb-ed22-4a9b-a1d9-ac5d29ae696d@linuxfoundation.org> Date: Fri, 5 Apr 2024 08:56:31 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] selftests: Replace "Bail out" with "Error" in ksft_exit_fail_msg() To: Muhammad Usama Anjum , Eric Biederman , Kees Cook , Shuah Khan , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel@collabora.com, Shuah Khan References: <20240405131748.1582646-1-usama.anjum@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240405131748.1582646-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: j6ciojm54x5ogghj1puegcqjqgo5krk5 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E34E740007 X-Rspam-User: X-HE-Tag: 1712328993-215102 X-HE-Meta: U2FsdGVkX1/shquPT/8sFvVf1M1ZQgwplxByYrFUfDx/7rXi+qy1r0aZ8LrHdY6aa1KFr8b1hOf/x9z7L4nBM0d9gjCKg2hHjKwcXanNrFIssySdO+XA/n2ZWg3qA2wS9B4wKjuElMsPlE5TPuiCDLAIHYjiEbIt/mN3bEk/aFSsZilCKlUDAzpIw7YvphWBx1EMevKQRQPM9V4WmjUc/VQ1GaAdY/y/CmPsNUziltJmh2dyGnKFXrAegJhpzfAUXWvSu9a8XGoj+9LWaOMcpOKs4+m5cigvChwUFRvMawlzQWCZOLDbFwslL4vwl7ibbIQlIJwss5dLWWgmGxD0w2sHYarZQektAQ93f1GcMKW0EXKjP6zX/zPbqTxletj48N3FXbi8ShvmbUmgRnS5k/zQEoVlszpGGEXu8QvRG9V/D29QGZMS1z3cr6envW4lsM2NJx/BtvwUBu0yWTlpE6i0XPVS10+PlMndV66IT0O2JTeggoseqpAZPIvq4SEGZ/oIQf71AzV1lGZildQtKWTETdUQ6RQkqkTD+aYuevC78UZSVcRKdHMUrzPlKiFHvN1Uj3lGHkrPnVw+pvWMPgMxOJwJomaKKqoSAE8dBvMIa535W0po7Wf+BKwegb05QcVkC3dyde8bG8g6TR1Z1d1U933mRBO9LwXnnMnoTsoEtn9pAlJXS+6Joi1DTznKwlL9K2Z9f31IMVcLCE1+TJazoe/BaTHxkCvG7EOKsQw5mYCCC4Y8fyn/xRg1t8d/yeQnfYILfRtr1v3GV/0bCMGVA8BZjLGrPeEahiXBw/MifBQ1FGmsAXhAOUWR8wGXUrDj76TqQZsXVsYznpbbL9TVdjTeR5sts46lKUI8YOwzgqVrcrsQ/u1+JjqW5KOVwX0K3cOUevgdFhY1c6AEJ6F7IMFOWceVQIgn4IUA5MRcFXd98cSjUTmuu7O1Np3OHF5Jm11gzGCJWx83vH3 1Jkz8fiX h5yflBHu/LcATrWczJ1U57JEquq/07G8XSIwhWIAlsQI5i3cdtb4AHND2j07swn4gp7bagC6HtU9EuHsFgwtq6kqNfyDV4QDW00cjQdMnomctxiuLuOGAdqFzritDPGWKFi0GlWCx+9xj/JWOuC4jhq7Isptf8R7piO1EPDvkooVVntYorC9BobAd10cVyAOH6TCU X-Bogosity: Ham, tests=bogofilter, spamicity=0.004775, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/5/24 07:17, Muhammad Usama Anjum wrote: > "Bail out! " is not descriptive. It rather should be: "Failed: " and > then this added prefix doesn't need to be added everywhere. Usually in > the logs, we are searching for "Failed" or "Error" instead of "Bail > out" so it must be replace. > > Remove Error/Failed prefixes from all usages as well. > > Muhammad Usama Anjum (2): > selftests: Replace "Bail out" with "Error" > selftests: Remove Error/Failed prefix from ksft_exit_fail*() usages > > tools/testing/selftests/exec/load_address.c | 8 +- > .../testing/selftests/exec/recursion-depth.c | 10 +- > tools/testing/selftests/kselftest.h | 2 +- > .../selftests/mm/map_fixed_noreplace.c | 24 +-- > tools/testing/selftests/mm/map_populate.c | 2 +- > tools/testing/selftests/mm/mremap_dontunmap.c | 2 +- > tools/testing/selftests/mm/pagemap_ioctl.c | 166 +++++++++--------- > .../selftests/mm/split_huge_page_test.c | 2 +- > 8 files changed, 108 insertions(+), 108 deletions(-) > Andrew, Kees, I will apply these to linux-kselftest next as a series since these changes depend on change to tools/testing/selftests/kselftest.h and need to go together. Are you okay with that? thanks, -- Shuah