From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C475FC433E0 for ; Thu, 14 May 2020 08:37:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9120420787 for ; Thu, 14 May 2020 08:37:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9120420787 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0AD9890002A; Thu, 14 May 2020 04:37:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05EB2900028; Thu, 14 May 2020 04:37:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB69390002A; Thu, 14 May 2020 04:37:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id D4980900028 for ; Thu, 14 May 2020 04:37:54 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 83AFD2C78 for ; Thu, 14 May 2020 08:37:54 +0000 (UTC) X-FDA: 76814671668.13.mine68_4390a8d2adc5d X-HE-Tag: mine68_4390a8d2adc5d X-Filterd-Recvd-Size: 4203 Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 May 2020 08:37:44 +0000 (UTC) Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 05EAC9A63BD46BE627FF; Thu, 14 May 2020 16:37:24 +0800 (CST) Received: from [127.0.0.1] (10.166.215.93) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Thu, 14 May 2020 16:37:22 +0800 Subject: Re: [linux-next:master 7592/7905] arch/riscv/mm/ptdump.c:57:3: error: 'FIXADDR_START' undeclared here (not in a function); did you mean 'XAS_RESTART'? To: Zong Li , Andrew Morton CC: kbuild test robot , , "Linux Memory Management List" References: <202005091847.zkVHPjis%lkp@intel.com> <20200513180745.30cfb5d0011c8e12972bdb8d@linux-foundation.org> From: Kefeng Wang Message-ID: <2a772f7b-bf5c-9f12-a3c9-92fb3e886f77@huawei.com> Date: Thu, 14 May 2020 16:37:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.166.215.93] X-CFilter-Loop: Reflected X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020/5/14 11:47, Zong Li wrote: > On Thu, May 14, 2020 at 9:07 AM Andrew Morton wrote: >> On Sat, 9 May 2020 18:46:50 +0800 kbuild test robot wrote: >> >>> Hi Zong, >>> >>> First bad commit (maybe != root cause): >>> >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >>> head: 30e2206e11ce27ae910cc0dab21472429e400a87 >>> commit: c0eba2d72e70b4208ca6fd82820ba7428090e350 [7592/7905] riscv: support DEBUG_WX >>> config: riscv-randconfig-r003-20200509 (attached as .config) >>> compiler: riscv64-linux-gcc (GCC) 9.3.0 >>> reproduce: >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> git checkout c0eba2d72e70b4208ca6fd82820ba7428090e350 >>> # save the attached .config to linux build tree >>> COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=riscv >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kbuild test robot >>> >>> All error/warnings (new ones prefixed by >>): >>> >>>>> arch/riscv/mm/ptdump.c:57:3: error: 'FIXADDR_START' undeclared here (not in a function); did you mean 'XAS_RESTART'? >>> 57 | {FIXADDR_START, "Fixmap start"}, >>> | ^~~~~~~~~~~~~ >>> | XAS_RESTART >> argh, I can't figure out how to make riscv compile :( >> >> Are you using the riscv32 toolchain or riscv64? >> >> And arch/riscv/include/asm/perf_event.h does >> >> #ifdef CONFIG_RISCV_BASE_PMU >> #define RISCV_MAX_COUNTERS 2 >> #endif >> >> #ifndef RISCV_MAX_COUNTERS >> #error "Please provide a valid RISCV_MAX_COUNTERS for the PMU." >> #endif >> >> where is RISCV_MAX_COUNTERS supposed to come from? Surely this should >> be implemented in Kconfig somehow? >> >> Sigh. Zong, did you take a look at this? > Yes, I had taken a look at that, the problem is that the .config > selects CONFIG_PERF_EVENTS, but doesn't select CONFIG_RISCV_BASE_PMU > together. It seems to me that it is a bug of perf porting on RISC-V, > CONFIG_RISCV_BASE_PMU could be selected or unselected, but in fact, > CONFIG_RISCV_BASE_PMU must be always selected when selecting > CONFIG_PERF_EVENTS on RISC-V perf implementation. Maybe let me send a > patch to fix it. Hi Andrew and Zong, I have sent some fix patches, and Palmer accept them. https://lore.kernel.org/linux-riscv/mhng-d7e9b8e8-2c97-490b-9eac-fd88c7a5a34d@palmerdabbelt-glaptop1/T/#t > > >