From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 962CEC5B543 for ; Sat, 7 Jun 2025 07:59:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 029846B0088; Sat, 7 Jun 2025 03:59:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1D686B0089; Sat, 7 Jun 2025 03:59:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0B3A6B008A; Sat, 7 Jun 2025 03:59:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C655A6B0088 for ; Sat, 7 Jun 2025 03:59:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 363491D74B7 for ; Sat, 7 Jun 2025 07:59:25 +0000 (UTC) X-FDA: 83527854690.09.DA4B197 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id BD46C4000A for ; Sat, 7 Jun 2025 07:59:22 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KM1rqUtt; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749283162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mMxMfTey5myO1nuvBBdoQ9yFV5viR/KDVxlFQagbxA0=; b=7GDuxmqks/rXlDEl4kTeUhqcCf1mVQ6sQkaYvbGmtg+5OgFRC6pMakkF+8X+tvBD5xqbR7 0R//LwoT2TYB4+hlXUY1GNHvC4v+DoVKhegfqwWzuqXvwNXq0RPgoZfS5xmFWgD0pHZ0TX w8Z7UlsxQtbbqJ4E+X2VhN6Dfg4fHw4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KM1rqUtt; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749283162; a=rsa-sha256; cv=none; b=dmIMi9z16/tCBTLhXaPuWqvPeYqckkPPiz4aPfvh+MQgq2msZtNRzCciBhURw7IrIypmGd H7MsPLJ7aLPKYR+Jimt9QfZzdwa85t3lyjwv3hpaoNnaDrg5eA6QDdiwN4tzC/RweyjT+D XBpQSr9EsYbwRTTQRxl+FT+iYnpzenE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749283162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mMxMfTey5myO1nuvBBdoQ9yFV5viR/KDVxlFQagbxA0=; b=KM1rqUttld0z4eloAOvs8m7lOdPxhZb2lCLOrPyhpy01PPCEaVt+Mm684RZaQiIuumE/MH ZClAIawD1URaDFyDcW+ha7y7iZJS0XgRCeQbyYmOy5Ns7mEg5AcNzZajapgQqBemY/Kvzd HoxozFAEfS2CJwEwaxir8rR8jYYkaf8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-46-fwo9HO1MNd-DSzLl4DtdMA-1; Sat, 07 Jun 2025 03:59:17 -0400 X-MC-Unique: fwo9HO1MNd-DSzLl4DtdMA-1 X-Mimecast-MFC-AGG-ID: fwo9HO1MNd-DSzLl4DtdMA_1749283157 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f6cc5332so1692599f8f.2 for ; Sat, 07 Jun 2025 00:59:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749283156; x=1749887956; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mMxMfTey5myO1nuvBBdoQ9yFV5viR/KDVxlFQagbxA0=; b=Cobz0TjpMV/h0RDLvJpdW9IrkpFxjqf3EF7ggFURV+a3qVBEKsU4XJXjkpxpJMNPdJ bjigebpcQTS+bSnZ3tW6XpFzLh11f7avg9B8235A8wmctbjGEk2tC21236v4rLgmIRPQ CigT61iH+t6EbLxF3/CvZ4Osw4d1JzozNk68Xpxg43LkZ94jsvhhGpuF9eEZVPPhl1dG CZHDj+jTTAyCW/9Z40faw+YDN5lJrygOoIy1fC1EXtldPum5+AjGh4rWJLS48ANrW0WP zd5jQmg011e474YsmIeJiQN9rqx4SF2Tw+9dx2rqM482aHYlBwfCLyKy1zK+/Lf1cSH8 M3Tw== X-Gm-Message-State: AOJu0YzHdLj1mOV8jX5wOCbaOBnVjK5BnHy0LLZSkJPf7u2NeP05Qbs4 mUeHrxYQs2xHYBa6D+CVyfE/mAff3Jpc4b/FplhHBtfW507n4NQXlqptENB051D82eoZ7X43Ftn CgKM799ies5ByZlCXVpBrtjckPiwyF/LE2NPboVU3EOo6Ni6+trDa X-Gm-Gg: ASbGnct9owm6nsVXYRbzoYZesz61yX57Yq6OjTNcp52MMp88jK4tCeC6r4TQUh6Rzeq YqDHMaBEuCa5R3BrmOC3mH3S0vZ/T/V3+yqtV6zI4K+T1DAIVvkTrpktKQk/eQ0Jb23PIoohuSO lZIgvKdK4nP9wYSBAM00EjArsNHQNx70WL4yG1DmdNkHmTgmVbGbk9RfjQ3eihs4wOjO/kIt4bG AUF5yyzlbIdx++S0BJFCpTI31BApTOLBahedVJYMX1OaO19Omn1GMHIPtsjIxRcH/hg8HxHY1Sm ELGlxEjk0t2ITVneQ5xiMAuRhMNgEOh05Y+6fMCo3yWVhwxZqaHwkZObh6zAwf+Eilcs6LevJRX j64aep4WbFLXp2Vzcmy4oEZ5jjb0TzQFCu0hoZ21N2YjZ X-Received: by 2002:adf:ee47:0:b0:3a5:3e47:8af5 with SMTP id ffacd0b85a97d-3a53e478c24mr619282f8f.27.1749283156671; Sat, 07 Jun 2025 00:59:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1bv5kWgSFN85r7D/wN0KvIK63OuUy04i+18rhFiKPZifQa/vYSJOlOkDIDyNuoSqfS+4oTQ== X-Received: by 2002:adf:ee47:0:b0:3a5:3e47:8af5 with SMTP id ffacd0b85a97d-3a53e478c24mr619263f8f.27.1749283156258; Sat, 07 Jun 2025 00:59:16 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4d:9f00:3bce:123:c78a:cc8? (p200300d82f4d9f003bce0123c78a0cc8.dip0.t-ipconnect.de. [2003:d8:2f4d:9f00:3bce:123:c78a:cc8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452730c73b8sm46391245e9.29.2025.06.07.00.59.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Jun 2025 00:59:15 -0700 (PDT) Message-ID: <2a768123-4423-4f52-a0ef-96fa69872949@redhat.com> Date: Sat, 7 Jun 2025 09:59:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/debug: Use BUILD_BUG_ON_INVALID() for VIRTUAL_BUG_ON() To: Tal Zussman , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250607-virtual_bug_on_invalid-v1-1-b792ac2b0920@columbia.edu> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250607-virtual_bug_on_invalid-v1-1-b792ac2b0920@columbia.edu> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: y4-gkEX-ommEA2AQaDvNGmmIvXRwFZkSa8PI5rzJ5gs_1749283157 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BD46C4000A X-Stat-Signature: 1p5xnyfkowxcdtgdydj1tzf41xa3a9jd X-Rspam-User: X-HE-Tag: 1749283162-819499 X-HE-Meta: U2FsdGVkX19F1pqp2OwPlSbIXljVEd8WZI5zOXAA/n1eApKGRwUh1asBgAoTwaPyHqJIdDixmaS6oWSdp/J/2vuvhfiu8RZSekIOLvKF4Oi30WW380woIU4F5dafd1ZtLQdwuqdB04m/rF5pGR9YKJn2WG/h5XGpjwPFbA3smNnLD9gxECXGeJj7CXI7oYLCof6Ka+kauOtwRl8QndobhDgPeGg4NALDdyjWTwktxrj1YYOMzFAITxIPA0UPmlJjNCKXbD/tLl1a+F1Q51U9HOGSaf+wUGNOxf41S9QGbw493RLPZbBDK9U4RRrX1EIcbAnYGQITDtUox55QNLVXdLWORuTBsJzJUZ6tjbGvmpyCItmos2Ssdth9kYb0zAG5kx2zmA3djC3TRQ67aVh79DRTD5K27fxd2nNascNuGmGmfCNv6Z81s7xzPdk5zVbObtNkXLJFot8g0H/pOcEVHrVUnWUsPprWWlTpMNkcV1WGt/z6sDTq5wiBx8mBVUfQ5YRjQmRitAhJcUvTXy573PcJk2XjEs+6JsduGrN1LtooJrWc/rN+w9X2YbiAzu6BilX0dLeXajO4KATd6J4aBdJphXymoKT1Dm0nUcK8ZVLNebkJWISQurDUwHtlPVGmh4tqrF0U/gDWvbknNgfvSFyxyDgNxRsf/WXsR2KwmJF5q4MpnRNxZGNiimcutTR1h87e48r/R7PK2JPOMv28lEvHfCQGxj9CUZWP0vAwDtznZE7bOE0k1y9k+9VOkZDBF4V5WC07+Y8IlVMp/wtWXptSvSV2pdXzf8NbfVDPDo1Z1JPIJ4w0nFQYrJayQ5DsCAZL9DiXZDmyXaWnTDqFHOq7P9rAN1Q1w8HVz9bV29Oq7g1V3TORXWAWjeIzK6Ke5TR7t5+hyxCEue1ep80rRNa4zeXrDtfNrv4BkiuNapIpgIlYncbp5CVuc+Frx6IRpPCZhhD4qRJMw1gsCvQ bbv4Dhf1 og8cHgMMH4mp2wco+WR/JPacwbCXrARLNrUIriJEcZgHPlVMGonPuCeYSWR1euteNSLXoi2CDK9mdhOz6oWdutzodY8fUcHE6/4NoF7RrRO4T7XKRw5GKu/m1633UkqwgLlnsrv0t1OJ3MBC+vQeo8iym29D35HtO0KAOq/Fc5GS6Shu3B5ZMqgQAAPfpjHxB+44fecJgfyOs2qkKTZfpO2pl4jPAcvZbt4yA+axXU65AzaeatzmfZJCGfMQzWMY8AoPi5ryQ0u0RDZmsMi6aNSM9KZiCsakzy7G6kSZ9TN/R0/Yo2ItXZ/bT9FmswKyxRzfxygEmJADsu88D31/57iTOpf50DpYa+tfk5WZZHmK64hlrVuTjScEyjK+eWHCdJpnJ2VoomFiF+Z9Qhfwe5ucNoscJKhuvdIJiRFyOVms6QufftNyjBHaW960Wq4ma0sIDMY+RQvk0MnE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.06.25 09:09, Tal Zussman wrote: > This allows the compiler to validate the condition even with > CONFIG_DEBUG_VIRTUAL disabled, and aligns VIRTUAL_BUG_ON() with the > other macros in mmdebug.h. > In the light of recent discussions, I think we should get rid of VIRTUAL_BUG_ON completely. There are only a hand full of callers, and I am preety sure for most of them VM_WARN_ON is a suitable replacement. > Signed-off-by: Tal Zussman > --- > include/linux/mmdebug.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h > index a0a3894900ed..012aef40e7a9 100644 > --- a/include/linux/mmdebug.h > +++ b/include/linux/mmdebug.h > @@ -129,7 +129,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi); > #ifdef CONFIG_DEBUG_VIRTUAL > #define VIRTUAL_BUG_ON(cond) BUG_ON(cond) > #else > -#define VIRTUAL_BUG_ON(cond) do { } while (0) > +#define VIRTUAL_BUG_ON(cond) BUILD_BUG_ON_INVALID(cond) > #endif > > #ifdef CONFIG_DEBUG_VM_PGFLAGS > > --- > base-commit: efe99fabeb11b030c89a7dc5a5e7a7558d0dc7ec > change-id: 20250607-virtual_bug_on_invalid-81d24b276109 > > Best regards, -- Cheers, David / dhildenb