From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A83E6D42B9E for ; Tue, 12 Nov 2024 15:48:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32CEE6B00E9; Tue, 12 Nov 2024 10:48:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DFE86B0101; Tue, 12 Nov 2024 10:48:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 156896B0102; Tue, 12 Nov 2024 10:48:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E9C296B00E9 for ; Tue, 12 Nov 2024 10:48:57 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5FF12402F9 for ; Tue, 12 Nov 2024 15:48:57 +0000 (UTC) X-FDA: 82777875138.12.954FF53 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 5819A10001F for ; Tue, 12 Nov 2024 15:48:08 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HXpnJVNO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731426359; a=rsa-sha256; cv=none; b=3YaAS6HOaDiNwDIKSjUWTZoneL5s6s3QTyFmRevnvfuSgW6c3lBCBPEWRX7EHhvEFLTXKm Yunl6/yXf85BoMvvM2dxiilQzAHZ9QbzhMkASx0aWla0a307+CkyUbFtfcxi03ctlHVXYl 5yo5rErMrMBf/PLZ09w1zyhRtoYUlJA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HXpnJVNO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731426359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NBzWljeInLaYVlceeq4uS83CUx9RaqrCT0JduSM/3es=; b=VUGrEFrBFD9q3k2JhBZh34UREHirnGJBPXmse8G/gRD7n6wDu1c6BGigD0i+8SmhI+p7Ks iWxVfrCHDp5E/ztR9hpnncI7PLKRiAdfqhUfaOQtHCXq9KRDJfuAfdDiATR2NivVIicgXy jHteGMmWctuxH2xBmzbD999enSEIvzc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731426534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NBzWljeInLaYVlceeq4uS83CUx9RaqrCT0JduSM/3es=; b=HXpnJVNOxdjEkRdv2nHcGufOXfRyINb89me/l6L7d+++UkWAgWUIycW2tWgBAAStS8vmCk m5KE2UU1zpUmhmW3sQGd271BlTIybXK5xCRVZpD1der/4voCDwnKwdYiyCdPTBco64+Bqu iVg80WH68nZbkc6SNf7e1z6mQtNu1Fc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-QR8_bGTkOYKc9yWeahcr9w-1; Tue, 12 Nov 2024 10:48:50 -0500 X-MC-Unique: QR8_bGTkOYKc9yWeahcr9w-1 X-Mimecast-MFC-AGG-ID: QR8_bGTkOYKc9yWeahcr9w Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4316655b2f1so41413795e9.0 for ; Tue, 12 Nov 2024 07:48:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731426530; x=1732031330; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=NBzWljeInLaYVlceeq4uS83CUx9RaqrCT0JduSM/3es=; b=jHMBa0FvloKZoiDDX6J59mYubnZXSapRl3r//E9WB4+xkTH/CBjQNdRvpbiFF05Ffw ltijJAV6gHElE3TbFHGLUX4t6R4Cbh4xWDz3uo2UORqTDkS8Ll4VbwCpc8c/AIE+lTFd 8xIyFl1y8a1/N2bMFChih3HYLC8pu7IWhVnwX2AGn+UgfwE6YJUhicp+l1X3Wmr+73Zx XiOVtDIp18LZDzoBztpmvTR5188jjSpQuKb8mB0bCznTvNnIXejQ6dclxuHopdtig/Uf uhV06bfcgHHld2kfWQMBnVa3cjBc1aQcIo6kj3NBE5umw5WrGaD1ipX1qcdIPcXhUema sEAA== X-Forwarded-Encrypted: i=1; AJvYcCWUqHkBqHkC1iqQYT+f4oEl4Mdo+YChZEPzsrXskYPR2F3OdBof1aryCWjWS3FtmsBJK2odREsbkg==@kvack.org X-Gm-Message-State: AOJu0YwVCHpQ4socGM7wKcpsSETiaj66puy3v9z2lCTAQnm91f8yS6w0 o9gNvajbPoINzWktQAEh+udb92LE0tp7O9BYNxF1DLw2YVnkPs+qLWl9/zhJvZfO8s6XTYNudKm sRc1V7rs4KedqWZM6ooi93nCKRr4asuKqauZYIqapp3n7s4nQEoAvHF1P X-Received: by 2002:a05:600c:510a:b0:431:4e3f:9dee with SMTP id 5b1f17b1804b1-432b74fd7edmr149845475e9.4.1731426529691; Tue, 12 Nov 2024 07:48:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGiPlR/rYHL3ApkGE6Xy5PVD9KX3s3Wo+vNqUEbyrZ9AhAQ6ENWfeeHRjP2S1TjOJdxKPfR6g== X-Received: by 2002:a05:600c:510a:b0:431:4e3f:9dee with SMTP id 5b1f17b1804b1-432b74fd7edmr149844975e9.4.1731426529244; Tue, 12 Nov 2024 07:48:49 -0800 (PST) Received: from ?IPV6:2003:cb:c739:8e00:7a46:1b8c:8b13:d3d? (p200300cbc7398e007a461b8c8b130d3d.dip0.t-ipconnect.de. [2003:cb:c739:8e00:7a46:1b8c:8b13:d3d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432b053069fsm218177955e9.4.2024.11.12.07.48.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2024 07:48:47 -0800 (PST) Message-ID: <2a6c1377-c76b-4b75-b4be-6896c860896b@redhat.com> Date: Tue, 12 Nov 2024 16:48:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 06/10] mm/hugetlb: use separate folio->_hugetlb_list for hugetlb-internals To: wang wei , tabba@google.com Cc: ackerleytng@google.com, airlied@gmail.com, akpm@linux-foundation.org, dri-devel@lists.freedesktop.org, jgg@nvidia.com, jglisse@redhat.com, jhubbard@nvidia.com, keirf@google.com, kirill.shutemov@linux.intel.com, linux-mm@kvack.org, mail@maciej.szmigiero.name, maz@kernel.org, muchun.song@linux.dev, nouveau@lists.freedesktop.org, pbonzini@redhat.com, qperret@google.com, quic_eberman@quicinc.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, simona@ffwll.ch, vannapurve@google.com, will@kernel.org, willy@infradead.org References: <20241108162040.159038-7-tabba@google.com> <20241112152849.10369-1-a929244872@163.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241112152849.10369-1-a929244872@163.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pmGfDNI2l6PMjoDmx8sAq6l4lmu71CkefjFyJUh-EsU_1731426530 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: zngx867qhzo77io9ga7yjpj67gyh7fux X-Rspamd-Queue-Id: 5819A10001F X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731426488-548774 X-HE-Meta: U2FsdGVkX18C9Ks7cIkhnNlJZDBj3yBbj1tn+a2ts1pVNo0132NUtQQmQIFkR9XJWdQ+Vpgud/Gr2TvnCt2Fs0fzZQ+7z9vC0GAD5+Ms0s59UWwgxC7U3uAp64iBVv8THtHvST2ithWISFOiWP1U7vIlSTp/G1uNsRRFX373bMzKJ/t2RxaBJxI8ryAWqrRLVeAZr/WucD7osHsMMfEFzubmya2W5xlFbY2NiL2Pxx1Oq1c+BCsNipfFpLk+3MHMSnjXWuHhSAd48wRSbSpLxY/9A+BVskqEZnegCjO/HVSUDgRlN2+v06gnF9oR4ZGRtI65IeoptLbfPTEWnnKjfhcuqHR9LgY3Ch9WcQx3XXReim3KEegW2VGrh94O4udiERMzPJGczu2vvCMX9SXhwH57rU5HbzilT8835h1i6jjkgqSYh7I1SVblDMj1KJ0vxI1Q6ZC7aPpx0lK5fTAo1vO/XsbAznTIA4jq1Pi/O1CHWkL5n2m9ls515Jq2b6PbBqrDrCjLvPOMprZ4TjruBmsznaTxH188JA/4huswyTLs3uwqwYZHujCOUEpNzuOOE2k7jW72dwYqVH4yPz7vl3acU0OBbXFE1drl3w2LYGBXs6pxqwkrDxHYdvViOzBQxkp5Dzqy/CzPiSL989prFYLiQba9vpe7g5Hs5l41/S1hxWW7dgi5ysVSFVNMCN5KYLKaT073MrRABvejPJ9luVQmjVDqfEgv+lG/QGEC4x7lBMFueyR7wQMR4JY0n8PaImqE+qdollDOwsBfUioU7NpX+WTxSj0y+kMYKUoRSiuMxcG2KUQZYbJvqTxJ0Zi+xZxE7Hpp6A0K34FslDBszZNucN6zHchu3nF0jYCYV1vtwXVhC/baeFYgOHyreKxE7ya128DP+dauAlU2SBh7ae30OEWJItNfhAIcyVcACjihdQCkH2/dgsMRAEhuIb5hFez45PGVxm2t+GYkaSS 7GJAAV9s mE8IxxflcdHz8MkcMynU3x8gyaUIMf95W61/ZV6fJLTS6A7orQNHOy8Pugz+1RIwymHbxKfU3thYEMdD8oe4fW1zQvQvSgaULQIVQDyTDmvCu0bT4kj5vK+04Z1oOl+WPYlMaNShLCWQckjQ1Tyn+3GMckR8Dvuo5I2NzheOEopMex7XBrKQ+/GQO1cRE/fLicuq7mjxqLIFxqbPtjpqWCTsLsDytSwJjv60lR0AQQTBe/I3J5HWHaS4vMNkWBQ559DF008/F7hKNNqGPQrhogyXW4iV0H922c1UyuLQJl7BrYvs6eKthjJq6yhJtuhh+oY3+hrnrFciAMwVnqEucgibuqPX3k2Vy8LWeGzJMgzKUr/BfONN1V7Y4NZY7Znpc0w/edEQUDranDuoL1Q4AgISIhbZUqUlvkq4J6XXsJLKrFyEAaDc2qBn9BI4T6x3WtQb6srKc2GU9WoYu5NfBAG4pfDj5A+y6sUQ4EtTQIamkJZwI05TMdwmGhTtRy/5BDnozYpEFu96G98mCNUH9yeHNQrcLCr6d7nXbDn5pbiqIGzA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000125, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.11.24 16:28, wang wei wrote: > Signed-off-by: wang wei > --- >> diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h >> index 80fef38d9d64..365c73be0bb4 100644 >> --- a/include/linux/mm_types.h >> +++ b/include/linux/mm_types.h >> @@ -310,6 +310,7 @@ typedef struct { >> * @_hugetlb_cgroup: Do not use directly, use accessor in hugetlb_cgroup.h. >> * @_hugetlb_cgroup_rsvd: Do not use directly, use accessor in hugetlb_cgroup.h. >> * @_hugetlb_hwpoison: Do not use directly, call raw_hwp_list_head(). >> + * @_hugetlb_list: To be used in hugetlb core code only. >> * @_deferred_list: Folios to be split under memory pressure. >> * @_unused_slab_obj_exts: Placeholder to match obj_exts in struct slab. >> * >> @@ -397,6 +398,17 @@ struct folio { >> }; >> struct page __page_2; >> }; >> + union { >> + struct { >> + unsigned long _flags_3; >> + unsigned long _head_3; >> + /* public: */ >> + struct list_head _hugetlb_list; >> + /* private: the union with struct page is transitional */ >> + }; >> + struct page __page_3; >> + }; >> + >> }; >> > As far as I know, increasing the size of folio maybe decrease > the revenue of HVO, do you measure it? We should always have a writable page2, even with HVO. So nothing should change at this point. Thanks! -- Cheers, David / dhildenb