From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62201C7115C for ; Wed, 25 Jun 2025 12:22:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 007686B00B4; Wed, 25 Jun 2025 08:22:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF9126B00D6; Wed, 25 Jun 2025 08:22:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC20D6B00D7; Wed, 25 Jun 2025 08:22:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CADC16B00D5 for ; Wed, 25 Jun 2025 08:22:13 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7B828C028C for ; Wed, 25 Jun 2025 12:22:13 +0000 (UTC) X-FDA: 83593835346.07.90B0096 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 0372DC0014 for ; Wed, 25 Jun 2025 12:22:10 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jDov+NWO; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750854131; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ss1icrrIyxEdtIqjAwEJ+j7FOIWgk08akbGMs7EYwQA=; b=smFoPJDFQW1xQqX8M5Wjk3YIJ/TuKWoK/9HHaeCws6qRa+PYyAohtkf4QSXfdM5gUMYyQ6 XiKqqB5Yn61o39pveVwvLXUnxmUHj7/cJLwv2psowwnAxMOOJEGRg8sG/vT9M5SMVBhMsb PFuCsZ8n5siRlzcSyWfPwEJ+OHBU8nk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jDov+NWO; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750854131; a=rsa-sha256; cv=none; b=o32kQZyKSrjTr+xY1YWMP+27GhTbJ3SJx1Onozt0GzKD1fI1NOJt2d+eZKUoxo6cOQX1Rk a0MkB92RkiUvz43+kHbr7C0lqvV5zJFUe540jVOngdGDLd0yRxCdYPerf8tjAbNLvfabXU 5wZnDQhMmnH4cGUPZPnlzmKaI0MnxnY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750854130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ss1icrrIyxEdtIqjAwEJ+j7FOIWgk08akbGMs7EYwQA=; b=jDov+NWOwDV1fPF6pHmbPgMfOwJOOViG0pldur3qNd0l8zT0j5Is+7dpYEu9qTjG5S7MU6 da7oW80GSzvi6kMkVSbvQQwQZz/3zcBJOvUwnU/Bp9ndQWeyopRxy1vgd/QyXDL10b9zwJ M3z/Vw0OqRAoL5OopQjBWlNyacdGWao= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-MnRklTIJOYaPpqXbWwMU_w-1; Wed, 25 Jun 2025 08:22:09 -0400 X-MC-Unique: MnRklTIJOYaPpqXbWwMU_w-1 X-Mimecast-MFC-AGG-ID: MnRklTIJOYaPpqXbWwMU_w_1750854128 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4e9252ba0so3518755f8f.0 for ; Wed, 25 Jun 2025 05:22:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750854128; x=1751458928; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ss1icrrIyxEdtIqjAwEJ+j7FOIWgk08akbGMs7EYwQA=; b=XCvKeity7/Zw4njvoKEd2alV357dZX1sOg58UaB34JcPy21YeDEahKP07QomvJbLrm H+6iCfYpDYDKbHG6LkYjp8E57vcQSPFyiomUlkdO6nNg5mFm6Z1JOkrIGzZNVSCgO4NQ yBl9OZtbuRPwwjviC5aRl9p7ouG9rz2IY0ty0C0pzJnsftycqpkUwzlTdERRlzA1uxHE lmOh/25DLliiGksaQ0dNU0B4QqLFTm+hXgYTfzAHqFZv2tW8U636BpMuchVUwFTwHxzB hyyHIcTy5G9Ie44jJvrLUqcgmc4SwZrOEIPS9rOl/MMKmsl5FtL1SFYEPDELZH7DQPlG ltuQ== X-Forwarded-Encrypted: i=1; AJvYcCVkc9cf7YD+6yGmhmgv8nKYWFSK+TLCNVOEWU4F01ZUgERhWMHe8barzM5CQDS7JUk5vN4jfPpO8Q==@kvack.org X-Gm-Message-State: AOJu0YzlQvpRGJgSJbKk8IGImBjC3a7TZ9J3eTXHJA8rCU+neFwjTGIM eP24yZn5oFNeBgyeZZ+JgzCP3HEiVvsUg/gLbqBy+exK1g7VNRoQ1sorGb9mRuiqS+O1JWJccg9 Vjvyh65rw+Nu9uSvq50yZsbcW8bxV+zMdo1dkNGkBwChJaDsaBL7+XaPfyCEEjUs= X-Gm-Gg: ASbGncuAxcBN5ZmLzJUmIlGxJWqzLacW/tVLp1W0HB5fecb3hqkKq0e610mAx/VVsiU /bTkc8LHtif9DVGAiUzTezx/WwfZzjqTv934Vh6+zESzPwDYk+1dck6wkzq6QaVmPzL+C3LrPpD +hPHVEVeynL69Aehxazm+ClY4eBkyMaAxoL/T3k8IkWZh97q9a14IkwGKJ/2Lscz3l2WpSFqahk 0B92y1r02NCLhSO8jLxWMY516izKlTlaCK8piOpFTiKMaylO4iuS1KsNjEsJgEoCu7CwCc8juDZ 4+r8s/Mum9BbfKg8Y/LkyrAggLdY0ZTGtYDGDy2UPRdN2fGaI+o+OCAuadZN2n8wE4M3SMPRdQk PlRJC3umb+LZOjXy1mL/5HTL77u+LaBUzEgpqnGimTGjo X-Received: by 2002:a05:6000:3108:b0:3a4:d8f8:fba7 with SMTP id ffacd0b85a97d-3a6ed5b87cemr2295905f8f.2.1750854128006; Wed, 25 Jun 2025 05:22:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXD9sUq8o1v9iLB/oups2tRX8p0JsC4u8k9dqDLBu2AXP5v6GrmxZvNjnCOvP+SMYwTUwmuA== X-Received: by 2002:a05:6000:3108:b0:3a4:d8f8:fba7 with SMTP id ffacd0b85a97d-3a6ed5b87cemr2295872f8f.2.1750854127537; Wed, 25 Jun 2025 05:22:07 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:1b00:5d6b:db26:e2b7:12? (p200300d82f121b005d6bdb26e2b70012.dip0.t-ipconnect.de. [2003:d8:2f12:1b00:5d6b:db26:e2b7:12]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538238198asm19174925e9.39.2025.06.25.05.22.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 05:22:06 -0700 (PDT) Message-ID: <2a55024b-509d-4bd9-81f4-c883858e110a@redhat.com> Date: Wed, 25 Jun 2025 14:22:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] khugepaged: Optimize __collapse_huge_page_copy_succeeded() by PTE batching To: Lorenzo Stoakes , Dev Jain Cc: akpm@linux-foundation.org, ziy@nvidia.com, baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250625055806.82645-1-dev.jain@arm.com> <20250625055806.82645-2-dev.jain@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: K9IyYWHOmEN-ygLc3RjgChyTXPUQjTldgG97QEpRU7Q_1750854128 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0372DC0014 X-Stat-Signature: 3y4tb1sii7rsticpjhh3fzfgukwfsbs8 X-Rspam-User: X-HE-Tag: 1750854130-906882 X-HE-Meta: U2FsdGVkX1+mB+VtStaredqjXbIVzYHI1XosUezvpOg/YD+nRp9EfubPX3leogujkk7ZGL+4At1tFSe5l4Hp/xnicgwGznz7U+ByyCPuXhIvJoKxyIg6rWcye89QdQ93xoeuHAtm36owb4JPnaxHEJgAocNpaiaZzNoNK0AuW1D9f40CETaLYI4baYLvL5fOBMM8NZLCodZrZa8wVxslfCKuIWW5KCCln6AXMhOl2a6c2DiUBFjRiaVB2D6e9hj61yrei2qLJjUYMOA5g7DNbmPLML9wR3wxbJO2lfxWFmPvlD9fw5W+FkTNdMKCv2o1YXKZsVhBMKJ4/QhYIwNgkX8jPDwnWN6IgtYq1rztmBt4Gmu/DiPxhiXA12kN0V7LxFWXgrsmXnLqlbNk81i8wLIPEH4cuAfiNFcMiV9F+UptbCsjYS+43h+1Eutyy86Byk76BeEnatNjp8yOR52jOGjPEFl3nnwWIwE7OIF73fHxKv0cqIpn/HWv4ZIxbPh4VMa/49DgDipfPXGgvnZQocsDd4o+JlN01qAtIRkrD2WEbT7RuZebrgz2zFuMPU08LVBT4dL4+/FJKE3dOGa3bQsafR6rH/T364OYBBX5DoQcCdrC0LE59va59bRGxvGlMesrxlZwGAYb8M6PmJBt+YhFN352hUonfzNUdIXERDP/q13uN+vgjEg9Gip4VI/R0gldQ3nn4Sm8jW64TqJeDR3O1tzkRc0rg1VoHnaqmuEfar7aUyR9tggPTVAOqJj3/D6bf+XHRjQkItTw4waP976lhVzttgjagswr7E6q8Lqpsv20h/pMvb4IRC0TvyIH9Th8UopNN8+Vmqlw4fUROLOrwzBYxFOt6YCdRUzodb9WytUjcAY3KTU8acZHhzrwJPmrCI9VZK+WAHJ0ZkHvIJCep/rZmHOADPXSqkrLuYBFSmpDqw0Yz9CU9NCz8nnyh3iDhOI0hrdlkScbpic 3KzOKjqU BndEFJw3i1NTxO9CybaXqjPyFUqr+tM4K937ohlimglDW7OjkQUeJ7mvWg5owWWOP1aY1ZGhaVLhVA3YAyZhLlAvTfb5/ysGmbjYkA140TKPIHaBGHP0Z81T9/hE+NjFRyuYH359uYOw0yIa6uBtUMTCKBnG461+TGnzg+TZVs1Llp0+qOd4bi0m0U9ACOhEn/QRakWquneFwkIGSOkuk7PwNqcwUKDAWfFvBmSbh6hH2rjSnnLXjM457IZDrFCJmbr4Jo508biaw2EJgDdI8Qnu/rklhIuXSkQ/jD9D+c29zGrPeg9X+eAFn3wFXhzzgl0LOKFGfUcaXX7KTnJa7pThHPGuU33X81KZzU2tYhvj+VgEihb3JSQ5RoZ1HFdkrOdNllYYiJDEtDwOJBVTc5gJ1ngs+xAaaOj2E3lZms4/olrRqm5awxYm/6gt7TpR/n9+gdsju0FGkX+h5x+vdzzlA6o64yzK45Lf4CbgmWHTja3X6J1OCwU6Ma9L6zJLLf1Fr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > if (folio_test_large(src)) { > int max_nr_ptes = (end - address) >> PAGE_SHIFT; > > nr_ptes = folio_pte_batch(src, address, _pte, > pteval, max_nr_ptes, > flags, NULL, NULL, NULL); > } > > BTW I think David raised it, but is there a way to wrap folio_pte_batch() to not > have to NULL, NULL, NULL here? :) I'm working on a cleanup for all that. So stay tuned :) -- Cheers, David / dhildenb