From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B84EED43352 for ; Thu, 7 Nov 2024 12:04:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BA366B008A; Thu, 7 Nov 2024 07:04:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2439E6B009B; Thu, 7 Nov 2024 07:04:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0435D6B009D; Thu, 7 Nov 2024 07:04:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CA5F16B008A for ; Thu, 7 Nov 2024 07:04:39 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7CE3EAB2C6 for ; Thu, 7 Nov 2024 12:04:39 +0000 (UTC) X-FDA: 82759165482.08.069F51F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 2D6F014000C for ; Thu, 7 Nov 2024 12:04:10 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KBjduNja; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730980851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B5+vZDmkrf1avaWGcD/MhpIJkSW85xJ3HGW972ay+qs=; b=7cJKfGfvLG2sCkC1zRO9F3Hxkv9I52OLOOKC5q/yDuW+nXW80fZmgpUkl/wKqqFMfi9Jjq +zpQh2KD2jmmKKiz1O8e5LsrpQE4RLaTOafqtA5c2zsyNSllqUW32eqE/xIjXtfYaCfDVk 7+1cQGQ89+pUuSUrqyCILVxmigETHKQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KBjduNja; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730980851; a=rsa-sha256; cv=none; b=1a4qjJJekBYDO3jBrWUvTqzL5G+FiXejbZiiS1Icaoo0woxYZEncVVxZf3UJBd4i4qsvvo kDcCN2Kc0a2O5SDcWb0yc6G9S/xNsnkGscBs0VButiWy4dSDQnOCgRRT0dSvwX56DLm2o9 vY5WXXqeWazeo3C216d/tIao0mf0WGA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730981076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=B5+vZDmkrf1avaWGcD/MhpIJkSW85xJ3HGW972ay+qs=; b=KBjduNjaqJrTIb1duZD5DAssgLRF7vpxgj94FUXkL9sJ3w0T14jh7HSsgZumhVTddT8GuI 9P2m+wQqDyQkDK3ZHenh+b1u9CDkRwNp32F/4U6DTeVlDfvTMMLH3pZ22wmlMIJbY0qIYt WOMZgUtoHZEOi4SNStIUGu8p0/oRunM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-Nsov3QAhMeevgVmYE-2nlg-1; Thu, 07 Nov 2024 07:04:35 -0500 X-MC-Unique: Nsov3QAhMeevgVmYE-2nlg-1 X-Mimecast-MFC-AGG-ID: Nsov3QAhMeevgVmYE-2nlg Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4316e2dde9eso8102035e9.2 for ; Thu, 07 Nov 2024 04:04:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730981074; x=1731585874; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=B5+vZDmkrf1avaWGcD/MhpIJkSW85xJ3HGW972ay+qs=; b=w/aH04NmZn/KYQzHsi7ytYNT7/ujrU7Vc38P0aB0fYyNFrQwDEe/HNl9WJe/bcEGlt WC/Izp253SCJsvryOiNq6i/eFsizOpEOV2EkknVVjHuIhjkCd8yIaon0kteA26q8rnOc aT0y+9hZ/3NSQnngyZ4XqrsKzX4ZCYx+UGsW3uJU/0CJApsDT3nZANw1sOmarWykvBT1 W6PLSAjNHFhUw/Pu6IhzYG5CN6GAwF5wXTi3fDJuug0CWJTcje2WQto74k33Ls9j+Vvg J6pUBPzkHHXFoFvwrsQAya8T7cRo+GWnXwVcEtMTnzALzTETYtKA+2ctq34iLMz7E1+t ydBw== X-Gm-Message-State: AOJu0Yxsn1WAk+Wwxl1JdE+gWj8csx8/j1GtQCmaqA9OOMYZgt48zlyv +hnU/1X0YVDzC6/9OwrjyY3DBWs3qyTmA5QHbQDntMtAu1XAhkxhozpxXXj326JKJ6VCAFmEZWq +BddltIRokgKfMkYEVVc1/QBwqQEp5Z2exUhTRl/jJdb7tkL0 X-Received: by 2002:a05:600c:444d:b0:42f:75e0:780e with SMTP id 5b1f17b1804b1-4328324ad00mr242896925e9.10.1730981074014; Thu, 07 Nov 2024 04:04:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IG3lXGq6xDxKBR/CQvZy5DO6U1eWql6WfDOCx037KzREk66lI1J4aMmIQDDc9WaWiP/L6MQEg== X-Received: by 2002:a05:600c:444d:b0:42f:75e0:780e with SMTP id 5b1f17b1804b1-4328324ad00mr242896655e9.10.1730981073664; Thu, 07 Nov 2024 04:04:33 -0800 (PST) Received: from ?IPV6:2003:cb:c708:7900:b88e:c72a:abbd:d3d9? (p200300cbc7087900b88ec72aabbdd3d9.dip0.t-ipconnect.de. [2003:cb:c708:7900:b88e:c72a:abbd:d3d9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432aa6c037bsm57190955e9.22.2024.11.07.04.04.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Nov 2024 04:04:32 -0800 (PST) Message-ID: <2a3d6cd7-ee80-4a60-939c-129e7d3e169d@redhat.com> Date: Thu, 7 Nov 2024 13:04:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: fix a possible null pointer dereference in setup_zone_pageset() To: Qiu-ji Chen , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, stable@vger.kernel.org References: <20241107113447.402194-1-chenqiuji666@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241107113447.402194-1-chenqiuji666@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fkbI513n1T9s494kkwkwJAaDnbMEnWSpuTbIxkUwq44_1730981074 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2D6F014000C X-Stat-Signature: 7g5bd5wb8amqxijfw1hcafktuz5yyzjr X-Rspam-User: X-HE-Tag: 1730981050-857 X-HE-Meta: U2FsdGVkX18qoSeLlHofAeG2DlYCIIFONUmLdRlep6ek2byu4m7zPTl9pAK75qoTC+i4gfsYxBdPcObZt05WEp62F+evlK7fm7dLQpz9qEe8Fd6qO95ORUI6MY1WtQ4f6H5Zh91nYtCO988PNPzpSTW19/Xrln6/7VYQI38QW/9NfmkGAImfza4GsZNuGMyMtR4ZTbosndjGADhX5xe5+n4Sy5UVPKuG7LrLhAojwPhBXg6VAOrE0lXZmusYJt3OS/6MOyhD3Qd+mGAsUGlCCChtje91qSsrlgfCwcTum2o+WHKgrbYFXue3Aj4GtHIR9YlBTFqQhWOOfyNKsVuBEbsXkLuB6KTdxa9CDTr9RSg/JaQDye70OA8v44w+EuiqeBgMuACNkfH2QNPQdTGw9q8ltbBPgqQJFGc199R36HyXafU+5yGrVIbc6XsygJG6rK6O1qrHkSXvxf0GG9hLh2AeT6xv/JyZIujFwBmDflpBCSl4cgc4/XD84KSErwmq1OtT/wqGdXLF8RJ6elOewY6pKjhZC0STJvCj7CxFG5F/NifLgX47HZyU8XG/PYRWLerBaglUBe1EoBsqdLKCvd/4MnzrZZM3LAKkWh+rX5VL2WINpakSsUvw6Z6Q0zHp1XL1yrdRL/1FVjdURqrYk8MK6xen5Yt4LmucT4piDe1Xg5Fl37CDqZ75uX6vnkpxwP43vvnQtdJ+LWAvJOldNzn35afu5g0+am6B6oWxvDRplm5iizVEr0ZLfw3NYF7HPWBsdzp6K5RKSvT8ttNxa1jxhApcYBRQURpHEb9KNag41/YNZWkYmaldEQd3ny5Q2gmOmE/MtNa5R/9KUo3lvXw3xfsfNHvaTW8rVgPEOOKGcXtAvkY/8YEPrRA3B/92zX6y/MJn3UymSQ6MGwlIhyvSneHiCjFayi6qo8eNC06/ShU0O2z/0jaIiaRlNTnl3CxMpBIq3arima2M85O BDPsKEmQ Co4aPvfTdkwUGP09aXwa1BCVrXRu3EF4IuR8kKnLJxvelMZtHH3x1UsGpoEk1CNII7ImaUVxk+XVg+pJKZWVcly3K3f6bqkKS4NROpccNcsySjTCISSPtldAwe8QJxGG+edRqRqFY4JRDkn9yCut0VUSw50S7Nn52G7gzSMLHHvF8sFkAlu/O7M62IZgKfscDQzyiKHGc9IgVzeaF0DveO2F9XHKOo4wHGGkQV+W0MrnzjTXZD3LkfRjsVagVIu+6H6DTfL8NcOOGbzmqIDmfc2HmqRmCVI2DHZ7w0jCU9X/L0T4E6vp0PCHZOOM44qxfassjW1PXCIwHB9tsL/GCgPzQNxj+sFc5NaXKfECgMduGWpfMQt/F38wwq/JeaFfVwvxJwRh8SWcZ9LVGnGcjUbp4Vh8l11TBm15JlHuky5p9LpmIi/dZEHCEUJCYi+Sj4F6dC2PKbSqAfcnuRq8M/SH/KoN5x4rzWSmHRqtUKCW58VU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.11.24 12:34, Qiu-ji Chen wrote: > The function call alloc_percpu() returns a pointer to the memory address, > but it hasn't been checked. Our static analysis tool indicates that null > pointer dereference may exist in pointer zone->per_cpu_pageset. It is > always safe to judge the null pointer before use. > > Signed-off-by: Qiu-ji Chen > Cc: stable@vger.kernel.org > Fixes: 9420f89db2dd ("mm: move most of core MM initialization to mm/mm_init.c") > --- > mm/page_alloc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 8afab64814dc..5deae1193dc3 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5703,8 +5703,14 @@ void __meminit setup_zone_pageset(struct zone *zone) > /* Size may be 0 on !SMP && !NUMA */ > if (sizeof(struct per_cpu_zonestat) > 0) > zone->per_cpu_zonestats = alloc_percpu(struct per_cpu_zonestat); > + if (!zone->per_cpu_pageset) > + return; Don't we initialize this for all with &boot_pageset? How could this ever happen? > > zone->per_cpu_pageset = alloc_percpu(struct per_cpu_pages); > + if (!zone->per_cpu_pageset) { > + free_percpu(zone->per_cpu_pageset); > + return; If it's NULL, we free it. Why? > + } > for_each_possible_cpu(cpu) { > struct per_cpu_pages *pcp; > struct per_cpu_zonestat *pzstats; Also, how could core code ever recover if this function would return early, leaving something partially initialized? The missing NULL check is concerning, but looking into alloc_percpu() we treat these as atomic allocations and would print a warning in case this would ever happen. So likely it never really happens in practice. I wonder if we simply want to leave it unmodified (IOW set to &boot_pageset) in case the allocation fails. We'd already print a warning in this unexpected scenario. -- Cheers, David / dhildenb