From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F7FAC433F5 for ; Tue, 31 May 2022 17:09:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99D836B0073; Tue, 31 May 2022 13:09:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 951D26B0074; Tue, 31 May 2022 13:09:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80D9B6B0075; Tue, 31 May 2022 13:09:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7128A6B0073 for ; Tue, 31 May 2022 13:09:14 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3E246212F9 for ; Tue, 31 May 2022 17:09:14 +0000 (UTC) X-FDA: 79526673828.06.704E6DF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 751D8C0067 for ; Tue, 31 May 2022 17:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654016953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qlKYVZzM2nYriJyvVC6KR8ssXZiDKMRbz1mFUuX7x88=; b=R6HDZQDbcFq7Re5r9mxkKTokrWH7Gisk/mzVxeKWkYs8aiZf3av14+cT1GIQIB00N9mWSN M5KWrkzeELa30u7v0hSKzQBUaPQ4l1gqhJl9QcrJr928f918sVFMAsKrGMc1sYgjT+zJP/ 6RVNsW05k1mNled6OJzBFthohw83jGY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-377-ZA2FPh2nNtawrPlIsie63Q-1; Tue, 31 May 2022 13:09:12 -0400 X-MC-Unique: ZA2FPh2nNtawrPlIsie63Q-1 Received: by mail-wm1-f70.google.com with SMTP id o23-20020a05600c511700b0039743cd8093so1601401wms.6 for ; Tue, 31 May 2022 10:09:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=qlKYVZzM2nYriJyvVC6KR8ssXZiDKMRbz1mFUuX7x88=; b=nsORc2nGTviFvhfLLghUct2eBJKBk2aWK0Ljcz/Scs5O5Y7PXFq0ywx5cpLSN2wI5P hlG6PvovZPSRfVt1pk0Rry/dTdh0Ar5LEhZlr9y8dudrp2/4+8X+Punq9E/E7AY4XONV ul4iHLsBLDN7YoqE9wAaphMSeVQMoqplYyal3bOCXq7l66D7+P3xvJ9NgM6nqOx84+SC udde+PoLqZLhtAHp7K62l4TlRjFqF9TaRz89ST/WIUvsigNbk6WAhTi93XAKiGLfWgPk 745o/7dP/UoqSG1MuW1SpGUh98E1TkeEuPu+bLqs1p/bWM5ivulPY7S+aG4kp372U9XI b5eQ== X-Gm-Message-State: AOAM5305VKRU0xk0eSsLxQ7y0aT0VM9qqtVuY8pjK0HrSVrbN9dPhHaF ErjopArDzcFHFsidX5KLwpoib8muwWClTxvsnimhgPHU8uyXjePVVsjuRnF/tjP7BB2M0alsZf1 lN7lH6wHesIs= X-Received: by 2002:a5d:6e03:0:b0:20f:ca43:badc with SMTP id h3-20020a5d6e03000000b0020fca43badcmr40314680wrz.547.1654016950822; Tue, 31 May 2022 10:09:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5hk+GQTU2b75312EXstPNYHVkp2viSPEhpy8invNfQjZgVwpRrXjjYy9nTkgZ+l6m10V6+A== X-Received: by 2002:a5d:6e03:0:b0:20f:ca43:badc with SMTP id h3-20020a5d6e03000000b0020fca43badcmr40314662wrz.547.1654016950504; Tue, 31 May 2022 10:09:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:f100:8096:9368:ba52:a341? (p200300cbc708f10080969368ba52a341.dip0.t-ipconnect.de. [2003:cb:c708:f100:8096:9368:ba52:a341]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c410700b003942a244edfsm2616828wmi.36.2022.05.31.10.09.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 10:09:10 -0700 (PDT) Message-ID: <2a3cc8fa-72e0-021f-8849-2641ae85f68b@redhat.com> Date: Tue, 31 May 2022 19:09:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 3/6] mm/page_alloc: Export free_frozen_pages() instead of free_unref_page() To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org References: <20220531150611.1303156-1-willy@infradead.org> <20220531150611.1303156-4-willy@infradead.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220531150611.1303156-4-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: nchhmj7wxmdmng4r8o4gwc54kbxks6b9 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=R6HDZQDb; spf=none (imf22.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 751D8C0067 X-HE-Tag: 1654016950-343185 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.05.22 17:06, Matthew Wilcox (Oracle) wrote: > This API makes more sense for slab to use and it works perfectly > well for swap. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/internal.h | 4 ++-- > mm/page_alloc.c | 18 +++++++++--------- > mm/swap.c | 2 +- > 3 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index c0f8fbe0445b..f1c0dab2b98e 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -362,8 +362,8 @@ extern void post_alloc_hook(struct page *page, unsigned int order, > gfp_t gfp_flags); > extern int user_min_free_kbytes; > > -extern void free_unref_page(struct page *page, unsigned int order); > -extern void free_unref_page_list(struct list_head *list); > +void free_frozen_pages(struct page *, unsigned int order); > +void free_unref_page_list(struct list_head *list); > > extern void zone_pcp_update(struct zone *zone, int cpu_online); > extern void zone_pcp_reset(struct zone *zone); > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 6a8676cb69db..825922000781 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -687,14 +687,6 @@ static inline bool pcp_allowed_order(unsigned int order) > return false; > } > > -static inline void free_frozen_pages(struct page *page, unsigned int order) > -{ > - if (pcp_allowed_order(order)) /* Via pcp? */ > - free_unref_page(page, order); > - else > - __free_pages_ok(page, order, FPI_NONE); > -} > - > /* > * Higher-order pages are called "compound pages". They are structured thusly: > * > @@ -3428,7 +3420,7 @@ static void free_unref_page_commit(struct page *page, int migratetype, > /* > * Free a pcp page > */ > -void free_unref_page(struct page *page, unsigned int order) > +static void free_unref_page(struct page *page, unsigned int order) > { > unsigned long flags; > unsigned long pfn = page_to_pfn(page); > @@ -3458,6 +3450,14 @@ void free_unref_page(struct page *page, unsigned int order) > local_unlock_irqrestore(&pagesets.lock, flags); > } > > +void free_frozen_pages(struct page *page, unsigned int order) > +{ > + if (pcp_allowed_order(order)) /* Via pcp? */ > + free_unref_page(page, order); > + else > + __free_pages_ok(page, order, FPI_NONE); > +} > + > /* > * Free a list of 0-order pages > */ > diff --git a/mm/swap.c b/mm/swap.c > index f3922a96b2e9..c474bdf838e3 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -103,7 +103,7 @@ static void __put_single_page(struct page *page) > { > __page_cache_release(page); > mem_cgroup_uncharge(page_folio(page)); > - free_unref_page(page, 0); > + free_frozen_pages(page, 0); > } > > static void __put_compound_page(struct page *page) IIUC, the net change is 0, because we'll always take the pcp_allowed_order() path due to order==0, correct? Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb