From: David Hildenbrand <david@redhat.com>
To: Qi Zheng <zhengqi.arch@bytedance.com>,
akpm@linux-foundation.org, rppt@kernel.org, vbabka@suse.cz,
mhocko@suse.com
Cc: willy@infradead.org, mgorman@techsingularity.net,
mingo@kernel.org, aneesh.kumar@linux.ibm.com,
ying.huang@intel.com, hannes@cmpxchg.org, osalvador@suse.de,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 0/2] handle memoryless nodes more appropriately
Date: Thu, 19 Oct 2023 09:56:58 +0200 [thread overview]
Message-ID: <2a3bd858-5464-4569-be1e-2a1867d90c15@redhat.com> (raw)
In-Reply-To: <cover.1697687357.git.zhengqi.arch@bytedance.com>
On 19.10.23 09:36, Qi Zheng wrote:
> Hi all,
>
> Currently, in the process of initialization or offline memory, memoryless
> nodes will still be built into the fallback list of itself or other nodes.
>
> This is not what we expected, so this patch series removes memoryless
> nodes from the fallback list entirely.
What's the end result of this change -- IOW why do we care? Patch #1
mentions "which will reduce runtime overhead." and patch #2 mentions
"This will incur some runtime overhead.". IIUC the comment in patch #1
correctly, these changes don't fix anything, correct?
Did you look into showing a performance gain?
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-10-19 7:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 7:36 Qi Zheng
2023-10-19 7:36 ` [PATCH v2 1/2] mm: page_alloc: skip memoryless nodes entirely Qi Zheng
2023-10-19 8:07 ` David Hildenbrand
2023-10-19 8:21 ` Qi Zheng
2023-10-19 7:36 ` [PATCH v2 2/2] mm: memory_hotplug: drop memoryless node from fallback lists Qi Zheng
2023-10-19 8:11 ` David Hildenbrand
2023-10-19 8:22 ` Qi Zheng
2023-10-19 7:56 ` David Hildenbrand [this message]
2023-10-19 8:17 ` [PATCH v2 0/2] handle memoryless nodes more appropriately Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a3bd858-5464-4569-be1e-2a1867d90c15@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox