From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, david@kernel.org
Subject: Re: [PATCH] mm/khugepaged: make khugepaged_collapse_control static
Date: Tue, 13 Jan 2026 09:26:37 +0000 [thread overview]
Message-ID: <2a289c18-b5b7-497c-bd6d-a25602706b23@codethink.co.uk> (raw)
In-Reply-To: <49229782-acf5-4e33-b317-63399deb6f6d@lucifer.local>
On 12/01/2026 16:33, Lorenzo Stoakes wrote:
> On Mon, Jan 12, 2026 at 04:18:20PM +0000, Ben Dooks wrote:
>> Make khugepaged_collapse_control as it is not exported.
>> Fixes the following sparse warning:
>>
>> mm/khugepaged.c:829:25: warning: symbol 'khugepaged_collapse_control' was not declared. Should it be static?
>
> Thanks for the patch, but sorry to say that this has already been addressed in
> [0].
>
> [0]: https://lore.kernel.org/all/20251224111351.41042-14-shivankg@amd.com/
>
>>
>> Fixes: 34d6b470ab9cf ("mm/khugepaged: add struct collapse_control")
>
> (Small note: for something like this that isn't fixing an actual bug we don't
> use a fixes like this).
Is this a subsystem preference because I was told I needed it for other
patches.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
next prev parent reply other threads:[~2026-01-13 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 16:18 Ben Dooks
2026-01-12 16:22 ` Ben Dooks
2026-01-12 16:33 ` Lorenzo Stoakes
2026-01-13 9:26 ` Ben Dooks [this message]
2026-01-13 9:50 ` Lorenzo Stoakes
-- strict thread matches above, loose matches on Subject: below --
2026-01-12 16:18 Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a289c18-b5b7-497c-bd6d-a25602706b23@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox