linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Peng Zhang <zhangpeng362@huawei.com>, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, wangkefeng.wang@huawei.com,
	sunnanyong@huawei.com
Subject: Re: [PATCH 7/7] mm/hugetlb.c: use helper macro K()
Date: Mon, 7 Aug 2023 17:20:03 +0200	[thread overview]
Message-ID: <2a17ed12-3753-dd6f-afc7-07579bab5bb2@redhat.com> (raw)
In-Reply-To: <20230804012559.2617515-8-zhangpeng362@huawei.com>

On 04.08.23 03:25, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@huawei.com>
> 
> Use helper macro K() to improve code readability. No functional
> modification involved.
> 
> Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>
> ---
>   mm/hugetlb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index e327a5a7602c..941d1d497b65 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -4775,7 +4775,7 @@ void hugetlb_show_meminfo_node(int nid)
>   void hugetlb_report_usage(struct seq_file *m, struct mm_struct *mm)
>   {
>   	seq_printf(m, "HugetlbPages:\t%8lu kB\n",
> -		   atomic_long_read(&mm->hugetlb_usage) << (PAGE_SHIFT - 10));
> +		   K(atomic_long_read(&mm->hugetlb_usage)));
>   }
>   
>   /* Return the number pages of memory we physically have, in PAGE_SIZE units. */

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb



  reply	other threads:[~2023-08-07 15:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04  1:25 [PATCH 0/7] cleanup with " Peng Zhang
2023-08-04  1:25 ` [PATCH 1/7] mm: remove redundant K() macro definition Peng Zhang
2023-08-07  8:31   ` Kefeng Wang
2023-08-07 15:20     ` David Hildenbrand
2023-08-08 10:44     ` zhangpeng (AS)
2023-08-04  1:25 ` [PATCH 2/7] mm/swapfile.c: use helper macro K() Peng Zhang
2023-08-07 15:18   ` David Hildenbrand
2023-08-04  1:25 ` [PATCH 3/7] mm/swap_state.c: " Peng Zhang
2023-08-07 15:19   ` David Hildenbrand
2023-08-04  1:25 ` [PATCH 4/7] mm/shmem.c: " Peng Zhang
2023-08-07 15:19   ` David Hildenbrand
2023-08-04  1:25 ` [PATCH 5/7] mm/nommu.c: " Peng Zhang
2023-08-07 15:19   ` David Hildenbrand
2023-08-04  1:25 ` [PATCH 6/7] mm/mmap.c: " Peng Zhang
2023-08-07 15:19   ` David Hildenbrand
2023-08-04  1:25 ` [PATCH 7/7] mm/hugetlb.c: " Peng Zhang
2023-08-07 15:20   ` David Hildenbrand [this message]
2023-08-04  3:39 ` [PATCH 0/7] cleanup with " Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a17ed12-3753-dd6f-afc7-07579bab5bb2@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=sunnanyong@huawei.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=zhangpeng362@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox