From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07135C433B4 for ; Fri, 23 Apr 2021 08:11:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8835161360 for ; Fri, 23 Apr 2021 08:11:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8835161360 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E20F26B00D0; Fri, 23 Apr 2021 04:11:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCFE86B00D1; Fri, 23 Apr 2021 04:11:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C71846B00D2; Fri, 23 Apr 2021 04:11:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id A1CF96B00D0 for ; Fri, 23 Apr 2021 04:11:27 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 48BD24DDD for ; Fri, 23 Apr 2021 08:11:27 +0000 (UTC) X-FDA: 78062912214.38.BA8DBF5 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf21.hostedemail.com (Postfix) with ESMTP id 6D2B8E000113 for ; Fri, 23 Apr 2021 08:11:23 +0000 (UTC) Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FRRlQ6dgTzlZ9n; Fri, 23 Apr 2021 16:09:22 +0800 (CST) Received: from [10.174.177.244] (10.174.177.244) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Fri, 23 Apr 2021 16:11:17 +0800 Subject: Re: [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid() From: Kefeng Wang To: Mike Rapoport CC: , Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , "Mark Rutland" , Mike Rapoport , "Will Deacon" , , , References: <20210421065108.1987-1-rppt@kernel.org> <9aa68d26-d736-3b75-4828-f148964eb7f0@huawei.com> <33fa74c2-f32d-f224-eb30-acdb717179ff@huawei.com> Message-ID: <2a1592ad-bc9d-4664-fd19-f7448a37edc0@huawei.com> Date: Fri, 23 Apr 2021 16:11:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <33fa74c2-f32d-f224-eb30-acdb717179ff@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US X-Originating-IP: [10.174.177.244] X-CFilter-Loop: Reflected X-Stat-Signature: yei6h6btpq3p7eyuewnohe639z9op4iz X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6D2B8E000113 Received-SPF: none (huawei.com>: No applicable sender policy available) receiver=imf21; identity=mailfrom; envelope-from=""; helo=szxga06-in.huawei.com; client-ip=45.249.212.32 X-HE-DKIM-Result: none/none X-HE-Tag: 1619165483-412203 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/4/22 23:28, Kefeng Wang wrote: > > On 2021/4/22 15:29, Mike Rapoport wrote: >> On Thu, Apr 22, 2021 at 03:00:20PM +0800, Kefeng Wang wrote: >>> On 2021/4/21 14:51, Mike Rapoport wrote: >>>> From: Mike Rapoport >>>> >>>> Hi, >>>> >>>> These patches aim to remove CONFIG_HOLES_IN_ZONE and essentially=20 >>>> hardwire >>>> pfn_valid_within() to 1. >>>> >>>> The idea is to mark NOMAP pages as reserved in the memory map and=20 >>>> restore >>>> the intended semantics of pfn_valid() to designate availability of=20 >>>> struct >>>> page for a pfn. >>>> >>>> With this the core mm will be able to cope with the fact that it=20 >>>> cannot use >>>> NOMAP pages and the holes created by NOMAP ranges within MAX_ORDER=20 >>>> blocks >>>> will be treated correctly even without the need for pfn_valid_within= . >>>> >>>> The patches are only boot tested on qemu-system-aarch64 so I'd reall= y >>>> appreciate memory stress tests on real hardware. >>>> >>>> If this actually works we'll be one step closer to drop custom=20 >>>> pfn_valid() >>>> on arm64 altogether. ... > > Ok, thanks, we met a same panic like the link on arm32(without=20 > HOLES_IN_ZONE), > > the scheme for arm64 could be suit for arm32, right?=C2=A0 I will try t= he=20 > patchset with > > some changes on arm32 and give some feedback. I tested this patchset(plus arm32 change, like arm64 does) based on lts=20 5.10=EF=BC=8Cadd some debug log, the useful info shows below, if we enable HOLES_IN_ZONE,=20 no panic, any idea, thanks. Zone ranges: =C2=A0 Normal=C2=A0=C2=A0 [mem 0x0000000080a00000-0x00000000b01fffff] =C2=A0 HighMem=C2=A0 [mem 0x00000000b0200000-0x00000000ffffefff] Movable zone start for each node Early memory node ranges =C2=A0 node=C2=A0=C2=A0 0: [mem 0x0000000080a00000-0x00000000855fffff] =C2=A0 node=C2=A0=C2=A0 0: [mem 0x0000000086a00000-0x0000000087dfffff] =C2=A0 node=C2=A0=C2=A0 0: [mem 0x000000008bd00000-0x000000008c4fffff] =C2=A0 node=C2=A0=C2=A0 0: [mem 0x000000008e300000-0x000000008ecfffff] =C2=A0 node=C2=A0=C2=A0 0: [mem 0x0000000090d00000-0x00000000bfffffff] =C2=A0 node=C2=A0=C2=A0 0: [mem 0x00000000cc000000-0x00000000dc9fffff] =C2=A0 node=C2=A0=C2=A0 0: [mem 0x00000000de700000-0x00000000de9fffff] =C2=A0 node=C2=A0=C2=A0 0: [mem 0x00000000e0800000-0x00000000e0bfffff] =C2=A0 node=C2=A0=C2=A0 0: [mem 0x00000000f4b00000-0x00000000f6ffffff] =C2=A0 node=C2=A0=C2=A0 0: [mem 0x00000000fda00000-0x00000000ffffefff] ----> free_memmap, start_pfn =3D 85800,=C2=A0 85800000 end_pfn =3D 86a00,= 86a00000 ----> free_memmap, start_pfn =3D 8c800,=C2=A0 8c800000 end_pfn =3D 8e300,= 8e300000 ----> free_memmap, start_pfn =3D 8f000,=C2=A0 8f000000 end_pfn =3D 90000,= 90000000 ----> free_memmap, start_pfn =3D dcc00,=C2=A0 dcc00000 end_pfn =3D de700,= de700000 ----> free_memmap, start_pfn =3D dec00,=C2=A0 dec00000 end_pfn =3D e0000,= e0000000 ----> free_memmap, start_pfn =3D e0c00,=C2=A0 e0c00000 end_pfn =3D e4000,= e4000000 ----> free_memmap, start_pfn =3D f7000,=C2=A0 f7000000 end_pfn =3D f8000,= f8000000 =3D=3D=3D >move_freepages: start_pfn/end_pfn [de600, de7ff], [de600000,=20 de7ff000] :=C2=A0 pfn =3Dde600 pfn2phy =3D de600000 , page =3D ef3cc000, = page-flags=20 =3D ffffffff 8<--- cut here --- Unable to handle kernel paging request at virtual address fffffffe pgd =3D 5dd50df5 [fffffffe] *pgd=3Daffff861, *pte=3D00000000, *ppte=3D00000000 Internal error: Oops: 37 [#1] SMP ARM Modules linked in: gmac(O) CPU: 2 PID: 635 Comm: test-oom Tainted: G=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 O=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 5.10.0+ #31 Hardware name: Hisilicon A9 PC is at move_freepages_block+0x150/0x278 LR is at move_freepages_block+0x150/0x278 pc : []=C2=A0=C2=A0=C2=A0 lr : []=C2=A0=C2=A0=C2=A0 p= sr: 200e0393 sp : c4179cf8=C2=A0 ip : 00000000=C2=A0 fp : 00000001 r10: c4179d58=C2=A0 r9 : 000de7ff=C2=A0 r8 : 00000000 r7 : c0863280=C2=A0 r6 : 000de600=C2=A0 r5 : 000de600=C2=A0 r4 : ef3cc000 r3 : ffffffff=C2=A0 r2 : 00000000=C2=A0 r1 : ef5d069c=C2=A0 r0 : fffffffe Flags: nzCv=C2=A0 IRQs off=C2=A0 FIQs on=C2=A0 Mode SVC_32=C2=A0 ISA ARM=C2= =A0 Segment user Control: 1ac5387d=C2=A0 Table: 83b0c04a=C2=A0 DAC: 55555555 Process test-oom (pid: 635, stack limit =3D 0x25d667df)