From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E93C27C43 for ; Thu, 30 May 2024 13:50:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CA216B0082; Thu, 30 May 2024 09:50:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57A586B0085; Thu, 30 May 2024 09:50:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41B626B0092; Thu, 30 May 2024 09:50:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2466F6B0082 for ; Thu, 30 May 2024 09:50:56 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A3ADF816DE for ; Thu, 30 May 2024 13:50:55 +0000 (UTC) X-FDA: 82175198070.05.6646F7B Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf18.hostedemail.com (Postfix) with ESMTP id 2C3B31C000A for ; Thu, 30 May 2024 13:50:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VAfVNrjh; spf=pass (imf18.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717077053; a=rsa-sha256; cv=none; b=BJSVgZiCZ8lLPcPt+q4AMsoc9ar/kPkqYjgjovUP9fjdohRCwwY81iphazj5KqKtqpXeEX NL6XQqMEDVomfHFyQ/G7B7JMipF7VFCbBHSDvaFPnWHtUq769F+wXq9BKUJ/b9l4cPyboJ 4YKFBJO8dBDB3lIo+qFp3FUI4K1ghpU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VAfVNrjh; spf=pass (imf18.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717077053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5J5ytoOnRmdbW4ewNk37oM5DW7MYdNtsw1vUpRPqPSs=; b=vEUtgSstRc28of/MixrirC3h1rD0QxrGYRR6v1va4q6gIs6/Zigd9I0DULk/v9rrsDb9ga cT09sE3AAjKEcR6XHNlacNvsHiWBAU8LVXakKMnJzMAi+rlDdfTJZztx3QypjJvMVFrtMw 9on2u3HcYcIyg4bYOcrU803Z7hG4YY4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717077052; x=1748613052; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=KgyvEHbIGvssi6wa/01jqr/+mopRD7sfcZW3OdAMwmY=; b=VAfVNrjhkmKWYZ25kDII4aU3150WYSQkaBVpNzuPWHwe9ltw5jxe+Caw 6aBnMgiV8JIEm1VEXz4vY0XWhAk3tafQbXgCdOyYUW41cYbhDttacgYmz oDBee4NEtUCUIge+2qAoa7VL2fGQXWkKh/xyygtsZeNbzeSwni/SgkyOd MW55Toxb0M50olDKrW3C7JOaTyg5oyMz6p0kyeUu84nSo8x/a+rOH4IRV oqRGU1nFtpbiVFtdGyAhqAbN4STx4FxYqN140tuTu2dLF8RfxxTYlTf6r f7osdV7N52Ox4oHaUZAC7a0gs+HC2OAQPqoG5Sv6npzuAJmn0uMzGHYsK Q==; X-CSE-ConnectionGUID: ufH/rC+dQ12FUEN/P/n+Pg== X-CSE-MsgGUID: /mpwqpH1RY+I0oqF+JitJA== X-IronPort-AV: E=McAfee;i="6600,9927,11088"; a="24173142" X-IronPort-AV: E=Sophos;i="6.08,201,1712646000"; d="scan'208";a="24173142" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2024 06:50:49 -0700 X-CSE-ConnectionGUID: z41EsDgCR8uiPNQaCCb33g== X-CSE-MsgGUID: e0kVWSzwQe+g0OS56Halmw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,201,1712646000"; d="scan'208";a="66676010" Received: from kinlongk-desk.amr.corp.intel.com (HELO [10.125.111.178]) ([10.125.111.178]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2024 06:50:49 -0700 Message-ID: <2a0f8cc9-a061-45cd-81df-b65d4b454b77@intel.com> Date: Thu, 30 May 2024 06:50:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 00/12] LUF(Lazy Unmap Flush) reducing tlb numbers over 90% To: Byungchul Park , "Huang, Ying" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org, vernhao@tencent.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, rjgolo@gmail.com References: <982317c0-7faa-45f0-82a1-29978c3c9f4d@intel.com> <20240527015732.GA61604@system.software.com> <8734q46jc8.fsf@yhuang6-desk2.ccr.corp.intel.com> <44e4f2fd-e76e-445d-b618-17a6ec692812@intel.com> <20240529050046.GB20307@system.software.com> <961f9533-1e0c-416c-b6b0-d46b97127de2@intel.com> <20240530005026.GA47476@system.software.com> <87a5k814tq.fsf@yhuang6-desk2.ccr.corp.intel.com> <20240530071847.GA15344@system.software.com> <871q5j1zdf.fsf@yhuang6-desk2.ccr.corp.intel.com> <20240530084120.GA12940@system.software.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240530084120.GA12940@system.software.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2C3B31C000A X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: ks3nkaptu436i4fszeqb18if6t5stb7w X-HE-Tag: 1717077051-765457 X-HE-Meta: U2FsdGVkX19pIleZyF7/8LC+Rb8l8vODFDnr50vkAeLc4igp8OWRBSzItnixXMjBZYSJPCSKTY1G+hfj7IRkFsfYJ/Pe6esHaiHUXblvxeazkDXR/KQKfeNxCBdXS68wmApRjRcBV20np55E+Jv0RuOZx16KcUqTgWZznEglpF1qF9B03Z+jrb8egAVj/kGnbujGlfCD7xygptTK84l7TuyR8aFuG0oVtGqxamVPVqdiLcdurNo0eS0GcOSnZtNEhre/Nzv19RJejwmzAiPIZYTzeScdErGkOFLamEBUebssc75LCOogmrg5xpp5lrkdoVf7TMGFIkmvLxf/wYy95hZ1lRxV4tPsywY+Ar5C4Iifzm0I+g6/1hOjMkwwGysQ79IFE41KQo48R5+dVvXCumprKNRiynOcqFs8DhoBccPtFy0wk7fnPo0u3fa6U1QpIqrJns11AZ18nx62EuMDATKQ3zeq+JzFuB2HSTgMM0oVYGGlZOh8CUitfwA8lpEW/xR/OMJoM+/+OMi5O2+3PhYQ0TkMFh/PB30xG/be9+RHKoBYde6y9Tz0BZFyx2i6MEPXy57SUenuJ2ThfhCrA5N2f0rK+zfhIW4F97+xhiG+EMW9A1m3kC6t9s02Nyofiftmr1CS/LkLhiySPZGr2EMWLRw10kCAQX58nYo9ToJ1XKVIyc5M2COXzGai3T0UpgMMHpv8bgSZI7eOGEOtIaHQgUIRCxG8sxi3+mbIFaGn9Sz40knRnw943lk1ME1uSF554C1OeIqfDipZ4f44ofRKEvav2OxGXe+2eSKgFpYJ3RfnvlIhHZ9kcfNhugOFQ0z5NTD8hLFJX8osWEleKPcmBDSr+fCQ2YsjFUSRExiXocr5Onw2EtAV1dFed1pVcYXm8uBpJ4tReh4fD+qRA+/1P9lkC+F0Jrxic7s4jzYsC8sAGwhvlvdI14JBAH99snyP7B6krm2DpCOmx5y XnnYu6i6 Z7iuJFlgyhlZatmHJIosuUe3cTjinAMNGQMRCqNzzOMs03ht1vhZAHqbZm1e6X8ftg0POKqRxRikgjm/sQWSSJcOKPxBUjvIaxQNdCmjPzOi/LRRF4Qr1DWfeWVd4wQjalcRHD0PUDEewuy7Gc3yjOUyyJzBGlXZj+rSCRprt0nadxSepE9bT8spikw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/30/24 01:41, Byungchul Park wrote: > LUF should not optimize tlb flushes for mappings that users explicitly > change e.g. through mmap() and munmap(). We are thoroughly going around in circles at this point. I'm not quite sure what to do. Ying and I see a problem that we've tried to explain a couple of times. We've tried to show the connection between a LUF-elided TLB flush and how that could affect a later munmap() or mmap(MAP_FIXED). But these responses seem to keep going back to the fact that LUF doesn't directly affect munmap(), which is true, but quite irrelevant to the problem being described. So we're at an impasse. Byungchul, perhaps you should spin another series and maybe Ying and I have to write up a test case to show the bug that we see. Or perhaps someone else can jump into the thread and bridge the communication gap.