From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5321C27C77 for ; Mon, 17 Jun 2024 08:33:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39CDE6B0158; Mon, 17 Jun 2024 04:33:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34C7E6B0159; Mon, 17 Jun 2024 04:33:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C6B26B015A; Mon, 17 Jun 2024 04:33:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F08616B0158 for ; Mon, 17 Jun 2024 04:33:40 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8EF6BA0806 for ; Mon, 17 Jun 2024 08:33:40 +0000 (UTC) X-FDA: 82239717000.25.1711F1D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id 0E1D3C0002 for ; Mon, 17 Jun 2024 08:33:37 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="iOJAs/jH"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ga4gS9sf; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="iOJAs/jH"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ga4gS9sf; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718613216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eD010l12qC0rhE0+9N+n78K8hdqaazXxO+kOgw2ibII=; b=zdIJ0KQSR+t67Ijzbl3wsZLpIas8yDsZA0cbr8UNbmODZl2tPPlcu2Lql2mPhnN/uSHEBF lbcBGfrKiPHMQl/oFPMyQnxRBtO1dBJjHw+OJZvoWytCjXarOXAghICetJj6+4n7U4cNOl VkW8XKsx9nRgXMVdR/G8pzbNiCY3lFM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="iOJAs/jH"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ga4gS9sf; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="iOJAs/jH"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ga4gS9sf; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718613216; a=rsa-sha256; cv=none; b=fpshv9R0d24G08FPa2WoRGiVLz6iHz1wtAbk/zJFug2UkcM4zvJKQtCxtCrE75w8mnLuqE O/vWvXUBOkd/8Y3Goez6tQcjr2iNvxx2F22lfl6dndwgy99L9eMEaek1HkRWqj3+L9kjP9 fe0TFo+MIxXqdLb0jdmCYJ2IO1TU31w= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6FBFA5FD1B; Mon, 17 Jun 2024 08:33:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718613216; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eD010l12qC0rhE0+9N+n78K8hdqaazXxO+kOgw2ibII=; b=iOJAs/jHemGtnrNIBI6U3o1M+3VZpaN1ZpPzy1BiIU/VYvs3rtTYYj/Sit7gSuBJ7TDJcC iC8D0Gm96YoskUPzKwKvmfJeVrLfbYCpTQytIGSOkXp+PH9O8CwOavGXjb7ocjEiUkRrJF Y+njfuoogBCl9Lonu6byxJLUWS3860E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718613216; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eD010l12qC0rhE0+9N+n78K8hdqaazXxO+kOgw2ibII=; b=ga4gS9sfchmuqlh08dh83ER87+PRQCXsucJlrebOWUWG1wjQTHH5YzxIFXhUveyIlFQELu x9y+S/ciHMyXzVAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718613216; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eD010l12qC0rhE0+9N+n78K8hdqaazXxO+kOgw2ibII=; b=iOJAs/jHemGtnrNIBI6U3o1M+3VZpaN1ZpPzy1BiIU/VYvs3rtTYYj/Sit7gSuBJ7TDJcC iC8D0Gm96YoskUPzKwKvmfJeVrLfbYCpTQytIGSOkXp+PH9O8CwOavGXjb7ocjEiUkRrJF Y+njfuoogBCl9Lonu6byxJLUWS3860E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718613216; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eD010l12qC0rhE0+9N+n78K8hdqaazXxO+kOgw2ibII=; b=ga4gS9sfchmuqlh08dh83ER87+PRQCXsucJlrebOWUWG1wjQTHH5YzxIFXhUveyIlFQELu x9y+S/ciHMyXzVAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5B192139AB; Mon, 17 Jun 2024 08:33:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YKzqFeD0b2aWYwAAD6G6ig (envelope-from ); Mon, 17 Jun 2024 08:33:36 +0000 Message-ID: <2a0ee369-12f9-401a-9179-82bd659ae201@suse.cz> Date: Mon, 17 Jun 2024 10:33:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm: handle profiling for fake memory allocations during compaction To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240614230504.3849136-1-surenb@google.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240614230504.3849136-1-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0E1D3C0002 X-Stat-Signature: ujhtb3mku9a8eoqy4wpcgdogpjiawzp9 X-HE-Tag: 1718613217-813758 X-HE-Meta: U2FsdGVkX1+X9FnLMjttPPjUrKicRfQi5Iw0ar6S+z2Nb5V/tpCdtJOj01eifHrQeOIVSqtlUDdOoL2lnLbHYpTOuYgS7lM02ilz1JcEVr20Dj3nb97q+92ghbLFh2o0Spv+LVY0X+4Sd+eXeeiW+5XDWxAZTw2Ad9roSAQN5rYshdw9ylqqZlzbUKV3l4pzP7kEXaxKg4VdwleP+Z3y9b4NYT3u0JegGgfDuQ+DQ1RlUe7GI3U9+7QSbOJW1blThLDXC33MBl9TdysETVLm+xd6ClyuEM0xNmp3f5JRfmoituSxPTTK+LOqwicy0mypAWu499fFXUPqktyRgjvY3nhSXIyf0UDQ7puGSrNkv9wELfGZg0AdvySVzjWGiCr02yxJG5QcuAJylccLdMDkExs23Bhzr114ExWqQfgKRaVtu34NpvP3fFTlXhiiml9mcaupE2Etnfei7Eg3ed6ZISb6NcLIsMFVn/80COm3+J2/gM1Y1sgNH9B2cmERCTe4Zp1+o5jkRVy7XzjuR+cKaKiLdN3+1gp+ZoQnHAEzQz+Upykhz5mx9nuceVmV+lopmZwIZ1/W81Hw5327kgAAKjL3SXHftNYALiUmCRheyQQPW6Wzbe7iAH3mgJAH+ytbFFhl/yGV0+F6sLBMF4W1EokFQq5TtngP4N2NU8qdZc4mzs0YjxZiOaEByybXu6Wh1T2SAATdyjTjLeMYbpP6B1pBrli5nLRCOltcWUA+ksZ7l1mnScAZs31ybGQUwqRJQTjIpnfUf7GJlTQBUj+F2fsXY4VKTCSG01Xm+WD4v50fLOfB8oQXiM6JJGIbAhFUI2A1X7wXrwkn+P+IPfOOzhpTHrirBwR38aeXPDge1BcHL8PQ+vg3mKtKUeWtinMu4ShVWhZJLMBNUbsNx3HxvEWaISRw6Hs9Ii6hOqVWDf5W0bZsYX+/UZVMrr5CugFcsuxP76sjxAgvqfVRUJC Mdqlt4cs RwqguU8CsdgVUX5+DAdBTRI1xPsbg8+Rd5NB3R35VlURxrjX+5iva81niU7WOZg7Zw5wndvukuh5NXZPZKv35WQPrs9dqavIuLb0eDfwmC461993fcl63xmTQ+pnTcSCzRrRxSEg1AmmMwbhlSkxd4Xo1zFTxvvlDf6pT/dXbS3O85Sg+RT50c8fFfMH34rPkGg6oMMHWlNqUl5HYsoFWE8YR8BnYVaiyw24Qq7UG3H+MjoNoio9xYEWa1MMMTsT1BCSgjO1NpeSmPZFzGM7YMjtLncroyJSG67tn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/15/24 1:05 AM, Suren Baghdasaryan wrote: > During compaction isolated free pages are marked allocated so that they > can be split and/or freed. For that, post_alloc_hook() is used inside > split_map_pages() and release_free_list(). split_map_pages() marks free > pages allocated, splits the pages and then lets alloc_contig_range_noprof() > free those pages. release_free_list() marks free pages and immediately Well in case of split_map_pages() only some of them end up freed, but most should be used as migration targets. But we move the tags from the source page during migration and unaccount the ones from the target (i.e. from the instrumented post_alloc_hook() after this patch), right? So it should be ok, just the description here is incomplete. > frees them. This usage of post_alloc_hook() affect memory allocation > profiling because these functions might not be called from an instrumented > allocator, therefore current->alloc_tag is NULL and when debugging is > enabled (CONFIG_MEM_ALLOC_PROFILING_DEBUG=y) that causes warnings. > To avoid that, wrap such post_alloc_hook() calls into an instrumented > function which acts as an allocator which will be charged for these > fake allocations. Note that these allocations are very short lived until > they are freed, therefore the associated counters should usually read 0. > > Signed-off-by: Suren Baghdasaryan Acked-by: Vlastimil Babka > --- > mm/compaction.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index e731d45befc7..739b1bf3d637 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -79,6 +79,13 @@ static inline bool is_via_compact_memory(int order) { return false; } > #define COMPACTION_HPAGE_ORDER (PMD_SHIFT - PAGE_SHIFT) > #endif > > +static struct page *mark_allocated_noprof(struct page *page, unsigned int order, gfp_t gfp_flags) > +{ > + post_alloc_hook(page, order, __GFP_MOVABLE); > + return page; > +} > +#define mark_allocated(...) alloc_hooks(mark_allocated_noprof(__VA_ARGS__)) > + > static void split_map_pages(struct list_head *freepages) > { > unsigned int i, order; > @@ -93,7 +100,7 @@ static void split_map_pages(struct list_head *freepages) > > nr_pages = 1 << order; > > - post_alloc_hook(page, order, __GFP_MOVABLE); > + mark_allocated(page, order, __GFP_MOVABLE); > if (order) > split_page(page, order); > > @@ -122,7 +129,7 @@ static unsigned long release_free_list(struct list_head *freepages) > * Convert free pages into post allocation pages, so > * that we can free them via __free_page. > */ > - post_alloc_hook(page, order, __GFP_MOVABLE); > + mark_allocated(page, order, __GFP_MOVABLE); > __free_pages(page, order); > if (pfn > high_pfn) > high_pfn = pfn; > > base-commit: c286c21ff94252f778515b21b6bebe749454a852