From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F15C3C6FD1F for ; Wed, 20 Mar 2024 16:25:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71EBD6B0089; Wed, 20 Mar 2024 12:25:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CE826B008C; Wed, 20 Mar 2024 12:25:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5702E6B0092; Wed, 20 Mar 2024 12:25:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 455C46B0089 for ; Wed, 20 Mar 2024 12:25:00 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 08C98C134C for ; Wed, 20 Mar 2024 16:25:00 +0000 (UTC) X-FDA: 81917941560.01.1664BC1 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by imf30.hostedemail.com (Postfix) with ESMTP id 4CC3A80024 for ; Wed, 20 Mar 2024 16:24:55 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ADfMT5GJ; spf=pass (imf30.hostedemail.com: domain of ziy@nvidia.com designates 40.107.236.41 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710951896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NvskVY2Hke0bUzLx+I9GIqfbD3O/4mepOJrhxn24RmE=; b=oD2dNW8uzYb7KmDxdPxsk90mVSRbY0qN1n5Xfi0fjX9NtJJfAw/RtWqyFsBb9ZDMXNp4ZT 9FraFB5nOoSwaSZTlCClb/oCQepfN7X536tKs0LN6X1CK7I+YwkmqI3NhlySiKwgeC7t+Q dpdBXb1AQ6DFUPsFTUMmxkhup5Ah2/o= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1710951896; a=rsa-sha256; cv=pass; b=Hjzd5DYyV3yEqJK4ff9xI2hSDdjsOa2os8MSPO0zCIWbm/WUW8nbUyS0t1ejHE3NYMY+M1 Ks8wwE+KuwtCr0hE6lMo+h8yYCAmlizzc4ivqXEcNw+8m+BvCExEP8OG6ZRrEghSUYB2Q7 zYIbjmA1VB1UjrFme3LKvBz5L24yQjE= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ADfMT5GJ; spf=pass (imf30.hostedemail.com: domain of ziy@nvidia.com designates 40.107.236.41 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A/lVuVuHt9sTwvSA5K00cDdqhaVOtFletBeDyk8XnhxBjQvMAVE4uRn06j5HUS497imsI+AnLwowtY6zecDHDOWFgjvuW1cs5v3gaMqdhm+KHZUnvHFI8fFjLRwdb2us0TDWJKF5dH06HfpeaQpf3qK94HEA/v7xIWr4K1DsEXaR2DLhrr2bC+wRsjVjnSO3pdywvhJnG5fCXI4EIjjkEm+bW+bF+aIefghnhutHDNcoDXlSromBWmoPqS//jUqv3dz2qNaEVOsBIJmgdQv8edwhKt3H9mS6p4JG/K2UOsdt+A8SKko/WSXSBXHZ6OVZAnhMqC/JVGhHETcHV/chpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NvskVY2Hke0bUzLx+I9GIqfbD3O/4mepOJrhxn24RmE=; b=MWi0YOprpBjueG6PUFnnBMSrfTeSzvni1JjPiAyziK1+nHsaatX/wugRlTFhNHYGPGkt3WW+BAfaImuA35uYvXad4lqMGrM0lCd+ih5hz589Y0tzE9oWbtoYLhY/xOaMLHMimdv89PKWQ5eLvppOmaoDIPj5aViXSGbpMOEG3W2Ex1iOXWzZIFrER2xTqbWwxj4VK3EI7CMBxXAy9NTFB5DkV8LhLw/44bF4Dq7jemroa8P7gI26wKMdSfCMdDqj2EdMtvi8C1S4IfNl1OU0/uZPYCRdCpTaTj4KkqRw8yijiMCmdt3JhEaQrKZ4T0MwFZhHcMkTm4Pa1GXH6yTWyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NvskVY2Hke0bUzLx+I9GIqfbD3O/4mepOJrhxn24RmE=; b=ADfMT5GJWjbSDpRuPAlOD/z9q31ids0zC7UeuDuOSVIhWirBzg/IYPWYgfujBnGd1HuMc4hf1lhB9zxDqyxdio9t3vRBNlsb8Xtdd15U9S8aJNBPRtEeo53Omwf1BmQYyF/uaQqDR/AJ5I228wHsF8lzzHwIpmR/s/nAz5Lupe9H+rY4KjwUwGTo2Gg8+gPs01Ilu2h2vlQzDo1nP00vcJRL2j2vcQGE05NxgbTt1GOhWzq/65VZg1M04Obh1OFkHzPNEeibceXF1cC+pPJCfQoFIHXVb36IwPtn7BatThxgWImSMtQj4IX+rELZt9WWJcORttavmuUbpxd+jzbtZA== Received: from DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) by MN0PR12MB5881.namprd12.prod.outlook.com (2603:10b6:208:379::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.28; Wed, 20 Mar 2024 16:24:52 +0000 Received: from DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::dc5c:2cf1:d5f5:9753]) by DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::dc5c:2cf1:d5f5:9753%6]) with mapi id 15.20.7386.031; Wed, 20 Mar 2024 16:24:52 +0000 From: Zi Yan To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , Yang Shi , Huang Ying , "\"Kirill A . Shutemov\"" , Ryan Roberts , Baolin Wang , "\"Yin, Fengwei\"" , SeongJae Park , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] mm/migrate: split source folio if it is on deferred split list Date: Wed, 20 Mar 2024 12:24:46 -0400 X-Mailer: MailMate (1.14r6018) Message-ID: <2FA90B72-60FA-4D5E-A66D-D135B64C7C5E@nvidia.com> In-Reply-To: References: <20240320014511.306128-1-zi.yan@sent.com> Content-Type: multipart/signed; boundary="=_MailMate_9C819F3A-5E2A-4F05-ABF9-0B5F9C715F21_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: MN2PR15CA0037.namprd15.prod.outlook.com (2603:10b6:208:237::6) To DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5744:EE_|MN0PR12MB5881:EE_ X-MS-Office365-Filtering-Correlation-Id: 92ffb4b7-7af2-479b-9b53-08dc48fa4518 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6HjKa4nl61BbCxDGyqfbRuEk8FvjSjWaQBGmtFQFB8RPTqDX1EWdWuFo/5KfFEBzEo+DXH4UnHE2ipFPNZzD4SmJfG2dARaMIln0M+5BVXrgM1J2X1L0IJG73bktfZZ4Lt38fKffQ1VZ9/2r+8W7QuPJggdXa0z3WPMOf7g4ij4NVdjAo+76iyxblyP8aAUjw1CpH+Mpg8DkirJvTClGR0reSDVYEdiW/QBf6GC80UDZ61JAK+PuV2mLbQCoAWMljtJwK7Y7TXscZIqxMdzIkQ6spcDGhqGyFVTwW8AXnfARXaJsO8WankTVYAjFVoIS7lyM5XtrvZrQWATdtbxfkIrqihiMeUm3LfB6IXiPo4BEOiCW/TXzoR9kpteRdbWQkC4pqM7yMBLkUk3W8pit9HTiy8UjpGtvK3uFloeiRc+ahgotcK0+ceeDz9RAVHyk5h8k/rheEUhl0SUT1YKScBkAqkriUC4iNuCY3tUZGXsFFnvx3y1PyoxpJbVIgVNVrkvXjCSh8n0RrAkkZu5zYyfm6cXqNwGoM2hhTXhM+HNfLiks8KfDMSocw+/jREFquLsccSMH7VGlAJP0PJDgks2FkX9WrwvGnzRlJ5A/3K8tjRfoeJocCt4CVkXevn6Elecl0MgA/O1DwNw4CH2e0KKKASiqfKpe87hnoAdf9BQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB5744.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7416005)(1800799015)(376005)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FFmH1Rgun0JuYI6IRl6HHGHVfYIiIIEjvYx9VUwco8g6wkmU+JSFVubtA2vN?= =?us-ascii?Q?kM3/C2UX9EpVedE2R4hevrk8dF/jbO2q4nsRRKsoednSoyr8y4F4WZ+u3KFO?= =?us-ascii?Q?F+7qWfyG5jJeg38KtxtZnbpzN7SPiZgzOAyLrrvJ0LEubXinOGJavMBLo6fG?= =?us-ascii?Q?vbXrs6/fCYgyMw3c8rjzfkyFkJuWeJgFJemGlKJAhziqD49638ro1CBBcFqL?= =?us-ascii?Q?PdQK7slsc2TmkOdV9X5wElaGsEUjUyAjZMoXiCBwkWAUK0QS1g4P7BW5iDPm?= =?us-ascii?Q?W4R8kOY2zg/8ypLneW6Iw4lKoBh8ZZNooeMpbSIMFHEq+RWxdNWup5SOPXyZ?= =?us-ascii?Q?x+i4SRJvVRyZ8IbJHLIdYc5Kg9fr/tvlTQZvsbHODXmi2nB+2yNui8GHOQY1?= =?us-ascii?Q?u1pwtgjmKsvmJbh2l3dqqac4zaYSN7lQRqu6eLiI6yDSCicoVmrzqWoKQ8NS?= =?us-ascii?Q?vjdU2l4HlZ6l/vD6vx13veqtufxpq31FzYbQbcSxdpWEHbrZN6G5+/mbV42K?= =?us-ascii?Q?+jZwb72FTtpMfkfFspTmLqF7VPphye7tqqotxKhwtfG3c9yO+mY4d6w2f91B?= =?us-ascii?Q?pC6wgbMvC92c9oTVNdQ22wrW3V1ZjisvpZ/YXKQPQoJBRBPsy2xuswmsAcOH?= =?us-ascii?Q?seAns/ZHDKl4ym/W/KeKc0lSHO/NqJr7DaxzOLNy/VzNRGdRLgzlLjmN+wqy?= =?us-ascii?Q?XmNOtxp5wX691xClCsgxxwtKKZtWSFUG7wFYb7tpdMAngdbuhdRgMH287UUj?= =?us-ascii?Q?UrR29j2FTRfiY7lZPNYHa+ZdwDzW2WwjXS+JMkXJfle/+2aJ/K6X6DkyuwQ+?= =?us-ascii?Q?AHNOa0fCdBEFp8SDQNpE266WZPJiUMWPaZs3KAnnroDDS0KwiHRFyvDvvhJM?= =?us-ascii?Q?PqoNCEFENEmQKC3mOiudqxUrf/8Oi6gWq9uDP/3WLIec/X54UemQn48XCZzN?= =?us-ascii?Q?xlggysz5axbCO7tVZN3F6AyiYMMReE84V1D/q4D8tjkItzKv1JRJFA5UVQ23?= =?us-ascii?Q?ptNmzgFbz9edwPHI53WIGGwb9KlSszrFEbw40Wu+pTpcSekmH2x/cLXzYMbQ?= =?us-ascii?Q?ZhDh9YexUGwJ/nm6jDURrnFzmGWyjPr0htpqOu6Hh/7iFURlhCchBE8IXpoP?= =?us-ascii?Q?TeboJ66Yyk7Ielg7y+fiqbbS+AgW8NKu7J8KzT7rkBeut6GeUm+DFQRT/iNb?= =?us-ascii?Q?EcMbG443FJTH3wVr9i5rMClmNbI5l0tt8MxYY95GvMCoThYU+nZ9g6gH4rgh?= =?us-ascii?Q?ybDUVslL08KPvZ12nVkB1F2NWfwRQkagnSqAtEdcgmfR+o6tgRCAUL8sYG78?= =?us-ascii?Q?MPg/sGJ4zr8j2zxKCvwLkZqwYuTfJ5r6+f23z52ziI0UjEgfnTCobKWInXD8?= =?us-ascii?Q?VTj75vJwgeNXwQIPiYzH2tltx3yoeEEUxQjodsSWk19m7sihvglEADHeINLw?= =?us-ascii?Q?f3RmRWwQU26o4fB5Gxe8arGpdDuzUw2DRsS4m7thhAfuOaXy0CxC2SRgApu5?= =?us-ascii?Q?T9jmmhJnYZ6zwxT7JwkP1XX+pwXcB2W0LNcmOcx8GDE2M5slyREaFrUH7shb?= =?us-ascii?Q?jRTqSwoXXl4hTJE91NE=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92ffb4b7-7af2-479b-9b53-08dc48fa4518 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 16:24:51.9432 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +WFFFfMNfaZnQSIX+EXmFc8txrwIDFXyRTyeV+ayjzjiFYdXQn0M50IXMPTktofW X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5881 X-Rspamd-Queue-Id: 4CC3A80024 X-Rspam-User: X-Stat-Signature: ztk1cpqcfmh7srmyfpo8f4ji8k6bt1dn X-Rspamd-Server: rspam03 X-HE-Tag: 1710951895-648676 X-HE-Meta: U2FsdGVkX18FXcBYab8up8kit80tqCll+Q4cOpt69BxoTZFN7FpvK8j94H0zS5s4awO0H3v/P4ufBKwdOajYu8BUul5FDUARv4J7PdIlpDE9r/i9S/kJJ8WVNbnVAy0yV/XHOWZG5tYfmCY4tgCZLjiE1Bf1UZ/T5FHqb+DIKZw5ynEVpmBuyG/Ny3JyMmeUMirFz3WeReiNdcqYDVj4MO3a9O2z3fdtTYkdXbveXq2Zq9PsbeyIjS/YLB49DuWxlhXGLyo3PWeeTaulTbb4+2wu8nWoOT2qMNsdVo0fScg0WbCCHIjN+60JYizHIBnFnK8SpHYb3Tw+VWm7dLeKQaYsEn7uzfx//1Uxp3ShP2AlEMkLFjEKsSByLKO2f2vGVtFeOC6C7SOQCz8eJAjkBWVmCXkpFsODDGbTj2BbY/gRMw7EsDbX1zxAhD/Ac8vkgHyutr56DvFl0hMkYcjw276fErxijRzCFtzo+1/gQhRIUX6+CIyeSACNXWSrm1gtpw4RjW8OKfLIpF6hFOKR0OwkjyBGg5CKHJNz0ZSjvoWifnr6EtRG5fE4u22CDmCzyRD1Zpnlqr8AiDAGHcKsDd1arqgecQMro55in6MsjsD0skA2ABXrv2mWylx2ttnLR0I4KBqV2eZWyn+tjw/s+3kPdBHmAHiK5y51cXKDswGiZdVTGGTa5rPXG7ccNtmnlXlJV4hprN38mTDpUkBfjdlrlSmU5BHk/Sx/Fg/Ni7PRgRIBVkNBU10r+HIvRv+ZINHVxDdUv1GarhddJ5TKZ7odRJqP7l+qurc7cieSCLBwgEPyh8zxaoIw/yzBz+guDafBtot0ZzXjsAG93rBcQvjAA2UdesKymme/dRsVqmNNnnTJZcOrhcHn7I2VwU0DhwYn4h41eWDCnLxWyxXOstE9QyClQUByrCO491qZ10BXn6CsJa+u5PhoMlF58p7fhUYDvc28HSjzRtKNN8j +FENk0D4 kMPsVrm3uqUco0Mxb/jlPNM4oJGGtXG3tiAi0zdq9aySndFYlxGeKYgjRLZXVXpYiEgsgNn1Npaet3wI2Di/L/HLk0NX02sd63LQSNL5TIbf6aNXtrCytg+KIOjbalj1gg7e0Ri2iW5d7mvwDl6fckMV3iLP2v7vQUEDByXmw5RrbpUHPWZ2UpXsuA2OV4tX2YY5VgL/TU2Ts+8od1pozFkbmFsoDs2t0VYIr83JKlAYLbQbYinXpaklff6LuiUYPJ5udGJ3ExvKkQJ9q1ZoA/CuLJtSouZYrKJR6tp3vlx1ZMOs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --=_MailMate_9C819F3A-5E2A-4F05-ABF9-0B5F9C715F21_= Content-Type: text/plain On 20 Mar 2024, at 12:02, Matthew Wilcox wrote: > On Tue, Mar 19, 2024 at 09:45:11PM -0400, Zi Yan wrote: >> +++ b/mm/migrate.c >> @@ -1654,25 +1654,65 @@ static int migrate_pages_batch(struct list_head *from, >> >> /* >> * Large folio migration might be unsupported or >> - * the allocation might be failed so we should retry >> - * on the same folio with the large folio split >> + * the folio is on deferred split list so we should >> + * retry on the same folio with the large folio split >> * to normal folios. >> * >> * Split folios are put in split_folios, and >> * we will migrate them after the rest of the >> * list is processed. >> */ >> - if (!thp_migration_supported() && is_thp) { >> - nr_failed++; >> - stats->nr_thp_failed++; >> - if (!try_split_folio(folio, split_folios)) { >> - stats->nr_thp_split++; >> - stats->nr_split++; >> + if (is_thp) { >> + bool is_on_deferred_list = false; >> + >> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE >> + /* >> + * Check without taking split_queue_lock to >> + * reduce locking overheads. The worst case is >> + * that if the folio is put on the deferred >> + * split list after the check, it will be >> + * migrated and not put back on the list. >> + * The migrated folio will not be split >> + * via shrinker during memory pressure. >> + */ >> + if (!data_race(list_empty(&folio->_deferred_list))) { >> + struct deferred_split *ds_queue; >> + unsigned long flags; >> + >> + ds_queue = >> + get_deferred_split_queue(folio); >> + spin_lock_irqsave(&ds_queue->split_queue_lock, >> + flags); >> + /* >> + * Only check if the folio is on >> + * deferred split list without removing >> + * it. Since the folio can be on >> + * deferred_split_scan() local list and >> + * removing it can cause the local list >> + * corruption. Folio split process >> + * below can handle it with the help of >> + * folio_ref_freeze(). >> + */ >> + is_on_deferred_list = >> + !list_empty(&folio->_deferred_list); >> + spin_unlock_irqrestore(&ds_queue->split_queue_lock, >> + flags); >> + } >> +#endif >> + if (!thp_migration_supported() || >> + is_on_deferred_list) { >> + nr_failed++; >> + stats->nr_thp_failed++; >> + if (!try_split_folio(folio, >> + split_folios)) { >> + stats->nr_thp_split++; >> + stats->nr_split++; >> + continue; >> + } >> + stats->nr_failed_pages += nr_pages; >> + list_move_tail(&folio->lru, ret_folios); >> continue; >> } >> - stats->nr_failed_pages += nr_pages; >> - list_move_tail(&folio->lru, ret_folios); >> - continue; >> } > > I don't think we need to try quite this hard. I don't think we need > to take the lock to be certain if it's on the deferred list -- is > there anything preventing the folio being added to the deferred list > after we drop the lock? No. OK, I will use the less hard version. > > I also don't think we should account this as a thp split since those > are treated by callers as failures. So maybe this? I think we need to match the stats with code behavior, otherwise userspace caller can get confused by the results, where only a subset of a folio is migrated and split stats and failure stats are not bumped accordingly. > > +++ b/mm/migrate.c > @@ -1652,6 +1652,17 @@ static int migrate_pages_batch(struct list_head *from, > > cond_resched(); > > + /* > + * The rare folio on the deferred split list should > + * be split now. It should not count as a failure. > + */ > + if (nr_pages > 2 && > + !list_empty(&folio->_deferred_list)) { > + if (try_split_folio(folio, from) == 0) { > + is_large = is_thp = false; > + nr_pages = 1; > + } > + } > /* > * Large folio migration might be unsupported or > * the allocation might be failed so we should retry -- Best Regards, Yan, Zi --=_MailMate_9C819F3A-5E2A-4F05-ABF9-0B5F9C715F21_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmX7Dc4PHHppeUBudmlk aWEuY29tAAoJEOJ/noEUByhUW+YP/jh7W7lho5upV/0bVRYb3nWq1V+K7QC9PrGh epZEMOPa7qXebfB3xmMFTMtjSB07JAuaj+YRxhi+i7e1nxfknlYA815fHE7Mn57k L2X/UogkRdHxN+FmFrKT0x9J36euHdLYVf5oQx3e5TpW9U0abTwmq188J99ETTu2 6V0FrGC28SU7ZCIfgqbg6jPWRvwTAYjUWjLWHmqrtVpiMvGcE6zxUANbmb503viN UQZrI1Y6fcAfthSfZTbvhgjOAQ2vJn9e0Fznx0Dcp8amEsIriTmJjlyw+5ImmzD8 t7za1mg4Em6zM/95LbhkY9NYk5IkurvsuLJQUAjbh4qDHjrqufuElGoZDBQWaulO VJwMCta04ssZawnXzcHkan8nvzwWC9UOpe003nuwhRX10xmORuiRJ44isPs+WTgI kKJB1eg0CtKuzq5mSdO7sXvmJx3gis7Arpsun6SCFXmFp5+1mpYhdGiRlCEpyZ1w snCQ5zdtQP7XxwMXY+3LeHmSXq5pJo5S0iFwSsVw7j6ZGdNO9DnEsqSggi66t+8D msyjLhjm6IJGrr0W5QhOPIPP9ay2cAJ0mOU1fIdxQ3QMpXKXY3of13WBoGSizcLW egNwtDg/ohe4wVHBawnYFMSqGc95zyERmR0FUB8vmOZXoVxKPgK18ywr5S2dZ4Te zXSRBT5m =KwRb -----END PGP SIGNATURE----- --=_MailMate_9C819F3A-5E2A-4F05-ABF9-0B5F9C715F21_=--