From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F3B3C3DA7F for ; Mon, 12 Aug 2024 19:09:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D41F86B00BE; Mon, 12 Aug 2024 15:09:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF2546B00BF; Mon, 12 Aug 2024 15:09:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B925A6B00C4; Mon, 12 Aug 2024 15:09:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 98A796B00BE for ; Mon, 12 Aug 2024 15:09:18 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4DABA1A0361 for ; Mon, 12 Aug 2024 19:09:18 +0000 (UTC) X-FDA: 82444531596.20.3717724 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf15.hostedemail.com (Postfix) with ESMTP id 72B20A002C for ; Mon, 12 Aug 2024 19:09:16 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xafpg3dv; spf=pass (imf15.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723489686; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bkXHg/pBTxMP39Q++aBgkiez1mlXNsid7wQXSGrgxwk=; b=LBOFebFQAIvCB9oIS4PQd2PDjHNi27tXkO37yns9QrAlFTbJpZBRuZEj0huFfJbwrnV8ne CRv7bJRcKTcQ9oAnUf69L7YnLJScjlGjFZxYUZd0VpzL2Yrp5itMZl7biE0Q5QHURqrxon swshi/NBLNKgyMvdlveYuZqE60ABu7c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723489686; a=rsa-sha256; cv=none; b=ErmYqK58sXU3dqbisAsGB1JCfnXY5Z5CxOcauP08aCvv7EaKhSLq3a1Ex8VuLqn+1km/a4 xnGybiIXoSitDHGNa3nl8kABHqhGLqHH6iDaXdqOagGMdnG5rGsm5TFLwrhNx6CS7Z9BXX ZkxPseuf6wv1pP+9o7DE8J6aVFXhVME= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xafpg3dv; spf=pass (imf15.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5b8c2a61386so5438392a12.2 for ; Mon, 12 Aug 2024 12:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723489755; x=1724094555; darn=kvack.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bkXHg/pBTxMP39Q++aBgkiez1mlXNsid7wQXSGrgxwk=; b=Xafpg3dv1FkMEo6XCLc0yDiiBHlAtL+fa5XMoLF+OaAkTptcNJTgqu/NK+5zJ8yZ/z bk2HMljAKJ6CrVJsrDZZGt8bIXOilAsRXBxbLwuWGIeKMQUWWxSMibX4zzgVSyXmjWE5 iCvq5A0EHxRrKfT2b/s6GvT5Mm4VIZVb2INzV9wR8CT9OGCEF5E6+ZY3o6RO16WdWfhw g/lJZYVrxR7P8t+UScnenyZ0P5DnjXD7DHtDaziFSm1NR/NL61G/Ke9GEv2WKA0fIIQY uI9lWrNE7yiECd8fpgbL06Q052jqcBiYv5CkBtjlVK6bY2qR0IuJ27ElMialuieh4ZCn jynw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723489755; x=1724094555; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bkXHg/pBTxMP39Q++aBgkiez1mlXNsid7wQXSGrgxwk=; b=DwrU5I2Q1NtyNvFh4XjeQjRVhK/nASiZgV1LtFXnA7wCj5hEjPVunJtF7p3pYkwuXM TBIcM5umfzenZjXo1CViYqkjzGloDEEgB3qsE4CKSTLMkm6GaEtk9va1/dWy9/oK99rz VNmDiTJ41CI2/Duo+c2ZmOKd5XNaC2TtnpMFvWGyICeXwS/6oCIK4E1mQPe/P5tFvmL5 mFxeDcaS8ChSsDGfhvHfnLGoHQG4ARzwIrenn6cbwKhv6Mgtb00hDlnlHCY3vbBRpaAe NgZGlZqHvakQ+m4xPXPN1D6e7ZnWddYdaNJyhaJY8VMRXjbY4IjWBj5jeKkwefEDOJCe 6HnQ== X-Gm-Message-State: AOJu0YzWGwvjV8B/sMblRmwBDuZriDej9E05YwZW9BdMmu3SN/1Kk46I 8j5lNGCcyxFrh71MYpQ6x/YCqtcczHyWvFX105Kv9clDC/PAUZOU X-Google-Smtp-Source: AGHT+IF0aL2sV7fWpzA0EKx+TXDHqWWnJ8VWgTzpRVweZBkiQQXgT60/GxErjheVWLBeOPJwn0ehwg== X-Received: by 2002:a05:6402:5505:b0:5a3:5218:5d80 with SMTP id 4fb4d7f45d1cf-5bd44c409c1mr700223a12.21.1723489754238; Mon, 12 Aug 2024 12:09:14 -0700 (PDT) Received: from smtpclient.apple ([132.68.46.55]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bd1a602da2sm2511882a12.93.2024.08.12.12.09.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2024 12:09:13 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: [RFC PATCH v2 2/4] percpu: Assorted fixes found by strict percpu address space checks From: Nadav Amit In-Reply-To: <20240812115945.484051-3-ubizjak@gmail.com> Date: Mon, 12 Aug 2024 22:09:01 +0300 Cc: "open list:MEMORY MANAGEMENT" , Linux Kernel Mailing List , Dennis Zhou , Tejun Heo , Christoph Lameter , Andy Lutomirski , Ingo Molnar , Brian Gerst , Denys Vlasenko , "H. Peter Anvin" , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , Luc Van Oostenryck Content-Transfer-Encoding: quoted-printable Message-Id: <2EF46123-30B0-4A7E-9414-EE25CBCF255E@gmail.com> References: <20240812115945.484051-1-ubizjak@gmail.com> <20240812115945.484051-3-ubizjak@gmail.com> To: Uros Bizjak X-Mailer: Apple Mail (2.3776.700.51) X-Stat-Signature: dgohhktgjkrfug5jbr5yqo7uuc5obofo X-Rspamd-Queue-Id: 72B20A002C X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1723489756-499114 X-HE-Meta: U2FsdGVkX189qPEXrZAzkOYSRXb7xlNmmR9txATBlRaNB3tiJ1/eYpYctJL/OCWGrB+qjWaB36h4R8/Y9RqpMfYTYj77mUER0RQx6sMxrolxphfvYMPe50MysI48+59v0bs4zAvmL3pzb4uDYzM0iQJ+BKaPTIRd5/rOvzQoFxwQaaNBXlq+fwHSo7EpF7SKAbacsTAqA4rYajyPqUAC2+Hpvmzu5etUzBgz7xhTCPESznHVhI6jh4Bocu9SvWNZvM+u4mnLuNt80QWUPS513rjmFW+VgUU+X7z3ZxrGRUgp1rKUfyrz7YvjFpI3wCPWdXNP30Hxk4kOg+RQvIdZ3izX2HRAXP04ABjYbnczMkmy2HeeXlytO/JXWXfLH0mofVXis2bZHWzyNv8017sjEL+kOn3ipioCBANeSv7+JvFwNJ7Q0FtpWb51cZBCcyVVO8EsVY+qbpw3VktEAFqdN7lu25qRHJR0swg8r7sRG4WHIEeDKIGgegGjyZ5Xdt61mxtkWKeezBYw/72/0IQWdk5BV5619RhPF9JioqgPuKHTwoORoDgnBidPx9+RgFMZ7LjQrZj/VnNX9nLXNA7i7CJQ5u5igeulXCl0TjZTineT45zlHwi5RhcwIAIUfw1oY4D+odJ0Yjk38oSNDdHjIThwApyzdieT1epKSJ6SJrOXfurj8NWyaR2CnVex3QpkesZq3qd0hyhJ4Uvh++ZIhh8WSR5BnbxUcrTzyfLMInDrjLuO3Lay3gNYM8IdZwIH0Rl3Lfn20iPKo0aWcAACFGvBu0m5X6YG3ktCTVkQy0LNAOY09fioBzelkft4XD55Q1VnnPSV4vF/H2oFnxeMesAdW7iDWVYfb8W/mUKsYQi2iU8fWMze9m5/HqRCuadtm70G1puAeUv7+89alTaVm2gRR51AO5QEd3I8EiEEEmkGXETamCb/kXLh4JU2wc39zseG/q0SlqmH41ZKU+c ANLIxABD 8kutMt+8Jv4YdudNT9q3mYjg1qC1NrTPGBMx4pfPbVDVP9k4HExs1aFE5dySLkEq8pOm38X7bC3IVff3HMw/Qq09yjtSCMXhNsRGh/KPE/VyEnSjrpvfdpm77UyCKX6XVjl6NDsuxdS3ERIBqQcGsJ2SPtK2W/YM3Ca5UmoMFjMEf9WRI1E9dGH35RLcUz2uCHFVpjIL+BdNK25rToQ4F0sq1SFQ/+K4v7UkKCoMX8PaiFvklJ/2DewGgfXi7UcoKh/wMwAHsLi5oqwXuMeAzrBJl2S1VQetLFyVv5/LGJd6UbN5JD/3YL8DzIUmbT7pSMYk6ZKRUgDwknDqJc1d2KHKCP9Xy3iIYnB/yN5oSe1lHL1iMdhuVGQzpCqf8GlsWG0F+qRcRQrk648pppSUVFNssL/u4wcNX2MPc2Vmd++18sL9toGuMGUlkc6gDupxynyQ4vvOaLFFw2CmpnU4N0tfuC5ohVdSui9N/1X/ME2cOlLu8Nbkyk4QGTUpYgVqjp+kMr/4GGB1X0dbaboIZDE0VAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On 12 Aug 2024, at 14:57, Uros Bizjak wrote: > Assorted fixes to prevent defconfig build failures when > strict percpu address space checks will be enabled. >=20 > These show effeciveness of strict percpu address space checks. [snip] > --- a/drivers/base/devres.c > +++ b/drivers/base/devres.c > @@ -1231,6 +1231,6 @@ void devm_free_percpu(struct device *dev, void = __percpu *pdata) > * devm_free_pages() does. > */ > WARN_ON(devres_release(dev, devm_percpu_release, = devm_percpu_match, > - (__force void *)pdata)); > + (__force void *)(uintptr_t)pdata)); >=20 Since this pattern of casting appears multiple times (sometimes slightly different), I think it would be best to give a name for this operation and put it behind a macro. This would allow both to audit the cases developers move data between address-spaces, and also make them think whether what they do makes sense.