From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A62FECCF9E9 for ; Thu, 26 Sep 2024 07:09:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38C9B6B00BF; Thu, 26 Sep 2024 03:09:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 318AA6B00C0; Thu, 26 Sep 2024 03:09:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DD116B00C1; Thu, 26 Sep 2024 03:09:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F01786B00BF for ; Thu, 26 Sep 2024 03:09:46 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AAB79A159C for ; Thu, 26 Sep 2024 07:09:46 +0000 (UTC) X-FDA: 82606014372.18.8806A29 Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) by imf25.hostedemail.com (Postfix) with ESMTP id CD61FA000B for ; Thu, 26 Sep 2024 07:09:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FzQRxgPk; spf=pass (imf25.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727334464; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wu2H9oCzBNDNFygmuv4LIUDixIi3SoCczsdVGINmQ6s=; b=6upYP48VH2IKoE3WzrSxNgwRTwPbE6IcsjH3VosWysce/7Eu/aPuK68TiySPo8Rr7y9DuV Ogqid80P+rUIaI0rvfhnCQV0nNfWtBu4SAyA4LNITFzHagnvzix9SJTbOwJVdAK/Jgp4Cq bkCpH/lySJmezPWljDioL86OOWate50= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727334464; a=rsa-sha256; cv=none; b=N+NyjyBfgRGzIGSZ5+nZNwFMoKzJAWxUcq0ILc3lp5gcgS9pr72tVP5/Pe2bVvq5WvqVMk rhCCGZpx0hwHksmM40YGbgItD0M5WE9teUsdUge62Ps+TBqe1+Ix8xwFMrMXhCXWEdsDtb KfN8JeNkFHZYJUN08j4s3i1PkB4MVA8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=FzQRxgPk; spf=pass (imf25.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727334582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wu2H9oCzBNDNFygmuv4LIUDixIi3SoCczsdVGINmQ6s=; b=FzQRxgPkVajfTnEaxLqPfGqDVOfaRFQk/aaj96WnwiNRuSD6XzWL6p+fBCgWivm8eRCkW+ p5VdhJ9DuZIiQ6LAYVdc5Eil/kT1FnKsE46cPPHRIyLEslkFmE/OSJN4y44g6o3jboFkj8 nWiW64JSBFfY1euJ7276ockRhHozJQg= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Subject: Re: [PATCH v5 10/13] mm: page_vma_mapped_walk: map_pte() use pte_offset_map_rw_nolock() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <2620a48f34c9f19864ab0169cdbf253d31a8fcaa.1727332572.git.zhengqi.arch@bytedance.com> Date: Thu, 26 Sep 2024 15:08:38 +0800 Cc: david@redhat.com, hughd@google.com, willy@infradead.org, vbabka@kernel.org, akpm@linux-foundation.org, rppt@kernel.org, vishal.moola@gmail.com, peterx@redhat.com, ryan.roberts@arm.com, christophe.leroy2@cs-soprasteria.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Message-Id: <2C926DC1-AE51-42CD-8351-62A130D0BC4A@linux.dev> References: <2620a48f34c9f19864ab0169cdbf253d31a8fcaa.1727332572.git.zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: CD61FA000B X-Stat-Signature: mcg6ixx8k3ekjsm76w6cf3s641iyoeqo X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727334584-669076 X-HE-Meta: U2FsdGVkX1/KkLjz+TJJKAJuo8Wpb/1ZM5shj50h0vV3i9HXnDo9MkNsBP7gslYYBVkBkpbUE7G+1IJ0J6i70+jW2V0jczik+06T8W/6XDfiO4PAiILYdrb2atRd7lzk6UQJbmn22RC6u74kT90NV2K5BENGUcXL6VlMnjDsABrKXA6G0dEkn54NvpRfrnyxLqXGsmnQ0uZcFWL/dqHS59R+Az11BF/rqEtAGrqMjiVsOW4U4DdjsOx0wWRZxMCMSZvDUenITP3e6nq+6rUhlxCMVK1WY2581iTI/TiiKxGpHHB73lthvFzmj268We1UJBzvf2L5/wZMhe/NS4G06hOQFgwpYzMOkC9lxrP2yiihtSUyR4GsU2L3fTUoCMLHmIlPwbUtoXx3GpDgxcm4C9A/jRxutgLCrXheb4gyxbfmAwKUKaPGU0n8yLqHk1ggoV7/9uyRK8r3ZyePIVyFPGjAWtX6jMsNZpiHuEaJ+0fz5UUzoge1VFnBeku5OHTQ76kvWQSfleVkXZw5GYZ3hw0+OaOjBnprdWK53Noeuvsml79BfJMvpMTfStcL8sQrP75zrn4N9npEHqofS1/mJkYlkHdkPGc/IL+0QzlP4/hvxUgl4pTbX2pu92fGMjorQctrlg5aaGIRds/GXljev/pqTJjjNxw+18FVFGerIBYztT2m2rTqpyjWyJYZzBJ/mJOWgivwBSz1a33cMZHCuy5uESpKJNecMGnfwQwheL4yN/9lwKUpT31BvhnNzRUCfb8J8t5fyAWGVxUrt2ayEYXxw0oVNGRBIJba2pGEERTHll7ONef4GF66KsV+wuTPA0KqYvh5zXpF1IgfbLIm1aVGfqwiAYXahW+8WMJdtG16Q655svJet385P0CEFKsbhHccRF0uRS/ParpiS94uL9NbNWWPob7B87Zx/xgDCORF4FWp6o4geZkq44Ma8k0HICS6jnCaFxaujf4J18B mva4ftS/ Fe9C2okx9dQK5C3Vxrsh6m7B83ecGsltS3X5DoacvXs8AqIrYlKI46iBoDNt5Ge3MkdsCLaN0GDbIqpcYgXV6xOJkfFnuaf1BSCRhJtmLxNwf3L0tZ3MRr8aFLloKG4B2Y497IzYFXmIA5DZNGDzKHJ2+HdIawXR4aEq2eDlw6AOBfVXmUsSRixJil7Ao1wJtG4MkyCfSymK1/A9eN0tFBArczl07zrBLTADk4/sb30Y0Asw94BJpAyJ8rLLAdOmHWGwYEbrtRgvsSrfkTIuEnGYVWv4DCRj11RQkdHKLbcTWEOaeDY+SqPHoZKf1NWCs+hRse49Z4nWhQW5W+70z3BbPtz0Up0470shx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Sep 26, 2024, at 14:46, Qi Zheng wrote: > > In the caller of map_pte(), we may modify the pvmw->pte after acquiring > the pvmw->ptl, so convert it to using pte_offset_map_rw_nolock(). At > this time, the pte_same() check is not performed after the pvmw->ptl held, > so we should get pmdval and do pmd_same() check to ensure the stability of > pvmw->pmd. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Thanks.