From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44970C369C2 for ; Fri, 18 Apr 2025 02:52:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A392D6B02A1; Thu, 17 Apr 2025 22:52:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E87A6B02A2; Thu, 17 Apr 2025 22:52:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B17B6B02A3; Thu, 17 Apr 2025 22:52:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6ACD26B02A1 for ; Thu, 17 Apr 2025 22:52:18 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 14C251A0D8D for ; Fri, 18 Apr 2025 02:52:19 +0000 (UTC) X-FDA: 83345640798.23.3D3AC97 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) by imf16.hostedemail.com (Postfix) with ESMTP id 3EC10180005 for ; Fri, 18 Apr 2025 02:52:17 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="PHGHuE/w"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf16.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744944737; a=rsa-sha256; cv=none; b=25e/C76+uVTjxpsXHy3XJSm+b0gYvl9Pt4XAyFlLNKlmQh5oU6HqbAaVvSPnSdvTNFPhEs fDR1AlXknpOwL+jcIYeB4T6SsWdpfx9qAlpNcu95KPiMRw4ENlb4/AmbVyZFxI1l0h3iui AQbSWFn6gJIPYx0szkHydhDcPxXO6mw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="PHGHuE/w"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf16.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744944737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QYuRFpIGZRKFiumOuz1DK5II6Pi52mdASZrA/kHQn9c=; b=gpk13UPhOJSEFKBFX88heNN0VQ40mQMcEcyrQg+JaonFZMByhT1Lz7oWcg+cb12fBPwJRa fMcN1venozHXzXOYJy/A3l+/D+G2MePUpoU7vn6JuAfbLNdmWQnfRLsJF42KWJMrYUbT6J qPX8yz9hB4lQ2TpVdsqWAnSFmXpemzg= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744944735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QYuRFpIGZRKFiumOuz1DK5II6Pi52mdASZrA/kHQn9c=; b=PHGHuE/wgCx55r5ahZ7et33BsE+aJ+qvfm6VFupAb2TwEJgfUorWGiLbJwYjmAvYiBkvVK BUgMolpOTYMgT0ORxWiK4Zc9iuPVCzFwiXrkmx2X4Rj5l21LMXmiES0Xx6MMhp2ZmMPr+M tWKA+0OACqxS3Efo17CjfPSRHXa4Inc= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: [PATCH 2/3] mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of page X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20250417155530.124073-2-nifan.cxl@gmail.com> Date: Fri, 18 Apr 2025 10:51:42 +0800 Cc: willy@infradead.org, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fan Ni Content-Transfer-Encoding: 7bit Message-Id: <2C55C2BA-667E-4253-8A8C-FB21AC8D6775@linux.dev> References: <20250417155530.124073-1-nifan.cxl@gmail.com> <20250417155530.124073-2-nifan.cxl@gmail.com> To: nifan.cxl@gmail.com X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 3EC10180005 X-Rspamd-Server: rspam04 X-Stat-Signature: 87quns765f9ank5xknyz5j48q6jzhpkj X-HE-Tag: 1744944737-917917 X-HE-Meta: U2FsdGVkX1/ftUSAjhFTUEJiaCoueI5qsMgZ0rbBqcRbmPlfK8h1Cc6GnF2v4RiVMjsBZjgQz6ixLPQ+KuZFG1vjo4czR1LPjUY+oqUzcNSluzSqcQCsdzpQXfKi2kZFEJFCyXR3bJ2eXVNiDTRqVBB/wZvmaaYf8bSw6NOppvuubqZcBoTPvmCBIyH0pDezdA7EnrAl3p6GpC6OVppcz5uhKK3S9S7yCzklw1KS71zbtic8QftDyoOuXt5CP5ioAaV0/eDFs0nDkYW6Q28PylZT9mKHH46ul5vQI0gkiG9E55L6xC1fSUcM7LJOveaEI62yawtNvchlPLqeBthsg/jLFPQCGGTsO+VQgFXF6lx2UvFJh/Htsd25nxOsjljPhvNkkLFmzcmGTb5N+BE636QHJ8TsEnGcZiy5IGEEAo+jLVi4l/m0DWYspXkT0s4NRSGBCc5wzymUjbC6OhcqdWw/NiiOmDddGI7EnuSXwJFEsvlYj4YkWcuFKwnlPhwOTqWZDxi0B3B9Ozgryy2owuNhZ8DBJjiK9MfIepEDVbRlya2citrvRSfBSF9Uu79Q7caIX4/CYAWp0QDK1Mvx+enYyk7JV7RNxDxenG+xvwfsTaLBsDz2tl9Rpa0VJveBO3oSNXyX/Ghyg86v3UF0y3qTx1kGKwKaiPrz7chYtclz8lRyPdISwqLsZ3igUHxYWRPo5chY/0Mq7CuLfa8VnHtuBt5121n044ZbTZPND7nHfwaNcD9ejuLU2WBVcNRGgLNC82GScALS5ndl8cCko2UYWlN6MwAc5octg2+7nW8TyN0F9bANWvZxK9eAEdNSPLymOUH+6fZhmvr3+CI8a/jNTtkyfdrVZWFfslNf2bvAhrKvZMDrivKsHaKRPlEEQNi72X9UJbU8BFmh4JCPwMfue/7+P+dwEhg/IQqjTbJ/2y3cw/z+3IH00BWGCSWClcIkqB9okbH+pGpZPEq 3QubbkN8 SBdwAKzaFI3/W2bb0wb+n1kehIhwU4AJkCw/xXDx24334lquafUNJXvxcYa7zH+Q1x1kDt88AHBvH6yszfRzYBtsc4E0PMdups689qnJb5IzifM+74ZBjI0ecy1ztDee6jAK4kMd63U+bhNOX8KuSfMsu/q9h0Rcp7Zqt4Xuhk0B+3mHT3x4Yq+SLu7lb/cq+RE+lzYfx1gcjHRmoi9U2FJPC5tWFiyIgQNPXpb4T10Z16mSXqIYEAf/Y5cxi4DK0EBrzD7v9cetUPJQ6zU/hA8JFzQx9J+oGg7gDwi4bh6Lb77iNRyJE7MFnG8x6FKR/Flg0dUblZv117LG9acs7ByQXCu0IkNiW98iubwV81hv5sDffqBWRa17yLw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Apr 17, 2025, at 23:43, nifan.cxl@gmail.com wrote: > > From: Fan Ni > > The function unmap_hugepage_range() has two kinds of users: > 1) unmap_ref_private(), which passes in the head page of a folio. Since > unmap_ref_private() already takes folio and there are no other uses > of the folio struct in the function, it is natural for > unmap_hugepage_range() to take folio also. > 2) All other uses, which pass in NULL pointer. > > In both cases, we can pass in folio. Refactor unmap_hugepage_range() to > take folio. > > Signed-off-by: Fan Ni Reviewed-by: Muchun Song Thanks.