From: Muchun Song <muchun.song@linux.dev>
To: nifan.cxl@gmail.com
Cc: willy@infradead.org, mcgrof@kernel.org, a.manzanares@samsung.com,
dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Fan Ni <fan.ni@samsung.com>
Subject: Re: [PATCH 2/3] mm/hugetlb: Refactor unmap_hugepage_range() to take folio instead of page
Date: Fri, 18 Apr 2025 10:51:42 +0800 [thread overview]
Message-ID: <2C55C2BA-667E-4253-8A8C-FB21AC8D6775@linux.dev> (raw)
In-Reply-To: <20250417155530.124073-2-nifan.cxl@gmail.com>
> On Apr 17, 2025, at 23:43, nifan.cxl@gmail.com wrote:
>
> From: Fan Ni <fan.ni@samsung.com>
>
> The function unmap_hugepage_range() has two kinds of users:
> 1) unmap_ref_private(), which passes in the head page of a folio. Since
> unmap_ref_private() already takes folio and there are no other uses
> of the folio struct in the function, it is natural for
> unmap_hugepage_range() to take folio also.
> 2) All other uses, which pass in NULL pointer.
>
> In both cases, we can pass in folio. Refactor unmap_hugepage_range() to
> take folio.
>
> Signed-off-by: Fan Ni <fan.ni@samsung.com>
Reviewed-by: Muchun Song <muchun.song@linux.dev>
Thanks.
next prev parent reply other threads:[~2025-04-18 2:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 15:43 [PATCH 1/3] mm/hugetlb: Refactor unmap_ref_private() " nifan.cxl
2025-04-17 15:43 ` [PATCH 2/3] mm/hugetlb: Refactor unmap_hugepage_range() " nifan.cxl
2025-04-17 16:13 ` Sidhartha Kumar
2025-04-18 2:51 ` Muchun Song [this message]
2025-04-17 15:43 ` [PATCH 3/3] mm/hugetlb: Refactor __unmap_hugepage_range() " nifan.cxl
2025-04-17 16:21 ` Sidhartha Kumar
2025-04-17 16:34 ` Fan Ni
2025-04-18 3:03 ` Muchun Song
2025-04-18 4:27 ` Fan Ni
2025-04-17 16:11 ` [PATCH 1/3] mm/hugetlb: Refactor unmap_ref_private() " Sidhartha Kumar
2025-04-18 2:51 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2C55C2BA-667E-4253-8A8C-FB21AC8D6775@linux.dev \
--to=muchun.song@linux.dev \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=fan.ni@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=nifan.cxl@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox