From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E7DCCFB43C for ; Mon, 7 Oct 2024 04:38:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1693F6B0103; Mon, 7 Oct 2024 00:38:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 119B16B0104; Mon, 7 Oct 2024 00:38:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0081B6B0105; Mon, 7 Oct 2024 00:38:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D6E716B0103 for ; Mon, 7 Oct 2024 00:38:25 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 705894055E for ; Mon, 7 Oct 2024 04:38:25 +0000 (UTC) X-FDA: 82645549770.11.0F335FE Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 7801A1C0003 for ; Mon, 7 Oct 2024 04:38:23 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728275756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UL7Q8DULQnp9XYdVs7aMYmEv5PJ5+4/29Ejgs+9RQXc=; b=GYe1uVALZRIsN/kI+tJgVLHX/C2Yv8rKoSVo8Yauk5is0+bk+PnpCsj8bySU0u8NF2PF5X L7dAZt4CbW58cYIBVZZOdY9cDvZVThLF6EMY7xDproZ79VjgUfDbEIG5Xy9htgGQ6zXEVA 7V2fTAAUUSMBp7ywqFZclkKDAxsajVA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728275756; a=rsa-sha256; cv=none; b=pHYn9J53P/9qgA/PFaJj9ECCkT5n+txvfII/KeEVDx2swB7L4Ie3TVwR8chiCityWhByxt tPe68QphT1xcKtpx2RNFl+pwh4q2RfuwM1aJRVcd9sIzP6j1+z7c/tjQroThwrEqM/Z6Pn 0bTU64cIi3EFeLwrkEPgOmvdk8YYPYY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05090FEC; Sun, 6 Oct 2024 21:38:52 -0700 (PDT) Received: from [10.162.40.20] (e116581.arm.com [10.162.40.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D5AD13F640; Sun, 6 Oct 2024 21:38:13 -0700 (PDT) Message-ID: <29f94c69-ca62-48cf-a69b-797e89284540@arm.com> Date: Mon, 7 Oct 2024 10:08:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Dev Jain Subject: Re: [PATCH v6 1/2] mm: Abstract THP allocation To: David Hildenbrand , akpm@linux-foundation.org, willy@infradead.org, kirill.shutemov@linux.intel.com Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, mark.rutland@arm.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, jglisse@google.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240930052812.2627395-1-dev.jain@arm.com> <20240930052812.2627395-2-dev.jain@arm.com> <7c563924-47ea-42d1-82dc-3597151998a3@redhat.com> Content-Language: en-US In-Reply-To: <7c563924-47ea-42d1-82dc-3597151998a3@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7801A1C0003 X-Stat-Signature: z3cr31eb8ipgmkr9de6ty4cm757ofh43 X-Rspam-User: X-HE-Tag: 1728275903-915558 X-HE-Meta: U2FsdGVkX1+M/ci63ZMODWOFasHtO7cAu7DPiWxoiShY9i0GJ2jBJGlZKytZf8s0kBr/X5VkQrxhcgXr3fiP3x75QNJVWon8unjv/cNZUbqmLjqxXF1RDlINl5HKwDg29Mn8ktcTQpvdMfrYmdtSNZFZWq0DKS5WLz5uSMki2IH1VZ5X/1r0fIuQ62v/yQOy2Wzi5YqJVXIiB30A51gD5f4y9sbIZyD50ZVa+2dYBmco/yYsLNkvITShN1vH17hpSFNNGoWzaOt/kIPL7jBg7lvXBkTKLmtCY2MimJrwXr0p8PTZ5y+iZyRbDbmxA0nyQj9yAgTG+9ehwa61qvB6Xu3OzqBbhzeDZtizoTUjLEjIj7wBjmjXOsaZUDU+UNloxWH+MB0Qh7dwhIEX+CFpSTFMbWL7HgN9cI9sGswb8RnJKwKyK050ARo71z9WmKS9YUhpEpOZA1wTqj8/S1BR4Jdgm2c+hZQgY6FOCTxOuXKpswv8sDYNyzPxbUtOzanKldLLsGPp/wItoZ3jVC0jmY0Z0otkYIrieF7I+yxS5PLg+qv5s65GMNb6dHjF0cpMzrvP/0x7oFwfyG79rvD9UQOU0o347hgR4dmhim3DZdncPt7YdjxRnNI5E8z4iG6+8hK41Uhoceuicn+/2OXh34ig1dqYpt51DHYH9rw7H4CeEReG/nxXpFCq5wGGVfdgLC56KdYRxY21MTGMpjVZ+z/DdQ8G4vKPlJByuc7KkfqT2/whB4QVvsZ6kmMV4lVn4iNY/Yb8Zc9ENP0p2fq8rNKAUz3kSngE6rjwh3JR0wO2px9sgsCIcKhMNVV3R0DzOvAvyjmefFooplKX7YAlIoHxKo0lHjlZ+J4MVWqhPfyk36R4DRKXSuXR9erMwm/mW+zyYE/H9Aym4BILtMIK4IylBFG58tbBkTQZCqC8pu7as+OFIyjKmlGHK7kxypKFEIfBDEvw0oWJCYDhC4F EXFE00DC 8HzCGLnb5ft3l+6Kj6C3TI4Cs3GnUoz68kOiXDYrz54Db0Tfry2Hx1rCxDEl1eTq53aibpb3B5aq4NcUeTLoCry6zayaF7GG8FusOLUcmzH8hvyaNQbylDaf6UNhWtaeb9q07XGOwVCPYnrdpuMdYZdl2JKmqeUwyoZI9mPHonB+oW/t9ZgdafvqOtAlMLOBIVhrUVCIwnjAqsisj0thv7HxwxMzXdU14RjOsS5SL8LZ/5/T3UxBark6JcHozaDkj3oNSS4nk+7+vwrYkfpwAozWkVqQM7+3rqsKRsZqIwyrGp2E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/30/24 14:15, David Hildenbrand wrote: > On 30.09.24 07:28, Dev Jain wrote: >> In preparation for the second patch, abstract away the THP allocation >> logic present in the create_huge_pmd() path, which corresponds to the >> faulting case when no page is present. >> >> There should be no functional change as a result of applying this patch, >> except that, as David notes at [1], a PMD-aligned address should >> be passed to update_mmu_cache_pmd(). >> >> [1]: >> https://lore.kernel.org/all/ddd3fcd2-48b3-4170-bcaa-2fe66e093f43@redhat.com/ >> >> Acked-by: David Hildenbrand >> Reviewed-by: Kefeng Wang >> Signed-off-by: Dev Jain >> --- >>   mm/huge_memory.c | 98 ++++++++++++++++++++++++++++-------------------- >>   1 file changed, 57 insertions(+), 41 deletions(-) >> >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index 4e34b7f89daf..e3bcdbc9baa2 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -1148,47 +1148,81 @@ unsigned long thp_get_unmapped_area(struct >> file *filp, unsigned long addr, >>   } >>   EXPORT_SYMBOL_GPL(thp_get_unmapped_area); >>   -static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf, >> -            struct page *page, gfp_t gfp) >> +static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct >> *vma, >> +                          unsigned long addr) > > Just a nit as I am skimming over this once more: > > We try to make any new code / code we touch to use a 2-tab > indentation for the second parameter line. > > E.g., > > static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, >         unsigned long addr) > { Ah sorry, didn't know about this. I used to align it with the function parameter opening bracket. > >