From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B207C02187 for ; Sat, 18 Jan 2025 17:49:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75D846B0082; Sat, 18 Jan 2025 12:49:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 70DC76B0083; Sat, 18 Jan 2025 12:49:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D5126B0085; Sat, 18 Jan 2025 12:49:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3AD5A6B0082 for ; Sat, 18 Jan 2025 12:49:27 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CC2B21A1E0B for ; Sat, 18 Jan 2025 17:49:26 +0000 (UTC) X-FDA: 83021309532.07.41E062C Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf17.hostedemail.com (Postfix) with ESMTP id CACDA40015 for ; Sat, 18 Jan 2025 17:49:24 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Dv6VWvLa; dmarc=none; spf=pass (imf17.hostedemail.com: domain of groeck7@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737222564; a=rsa-sha256; cv=none; b=W3JdVJO7E6+A7hT1SPzHqvKgerx8B8176b2GuwTPrLK519aSRLfBgTgbt0Pl/VJndfQ1xo fCah5mrJ67thcHNUVXJDuS1VRQbN7POySxRqGxMrB882nMRrwp4QVdB52HDMF8sH3aU+I/ 7nSFwdqUM8EbhFQxLABW7pluCkNRZW8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Dv6VWvLa; dmarc=none; spf=pass (imf17.hostedemail.com: domain of groeck7@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737222564; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GU7FE91Y7VKzW3O3qn7y+qTA2pSkAbO4RD6j4nKnL+c=; b=uwPKSbDrrrF55udAfh/ugOJ5qSvhor/UlglIpcNPVsCyBk/QMdAlcBmdJjnwnmcFILi3F/ q/4fEHFcWHcLJ8HaAy1MigJWh9SKoUybkrztZrxmCRCVcPzZkF6OTYQFD0d16v5vV7bU1d xd7VWhAb+MYDrBYq84DjnaT3xJ+wtng= Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2f43da61ba9so4303257a91.2 for ; Sat, 18 Jan 2025 09:49:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737222563; x=1737827363; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=GU7FE91Y7VKzW3O3qn7y+qTA2pSkAbO4RD6j4nKnL+c=; b=Dv6VWvLa7BP/w6DFJry7cQLni7v8X5qR7sccBLD5deACRHiSByaIVRhF+C035Yvsy8 VQ8r9V8y7zToJPeD+O19D7pDX+8bWCmpaxEqS43VlIs0FvZ5hlB4YhUknqRpIdOwWEgD k9Og7OZRhCmqhoNkBkNbnFA7tznxpemAqc1bJFocAiarPat+eI4XIyoPY72j6IBCqQSl ytWwJgrJf42dfQpzoQm7C1eGkC6VucLHDKdjBJorQXY7FrwmkemDSToCSFOqGmBPUjDK hsNZnncmwhiV2zInOHLs806FHt9RYpPq89erkaAEGK6lE17MZxCh/I1ZXpbWSNZkSO6l NGgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737222563; x=1737827363; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GU7FE91Y7VKzW3O3qn7y+qTA2pSkAbO4RD6j4nKnL+c=; b=Fg9Cqfsfk0QrfHeYSHj/u06ADrG6ai+MQ1aZXy0ycFe6ShWnHnQ1kCAMkWfDWOzpYN i6b5BFc1JYAaepoo+vtR9FYxy2Haah4FJ3W83mXtVVCvVzTVYgWMXtqv9Yoqx2iVpMbG GmMekbwkY7N+LWWVocgqDaqpZJ4/p831ZylW3VsCw47DFGtovTvGWrNPcCbZ3sHNY4jF mZgVjgeGHSY2fl9C/r0IGi8b/giwgoI6Gq7zlEUnESuSP7JXeC2vk1MT8WNNQ882+Vwh sTgss/kVZm0t+sur3u6yi+vUdfO7Z7iqekTjU12sEBX435zhNsdumHJqsbE1rmJdnm5f tHxA== X-Forwarded-Encrypted: i=1; AJvYcCV1iexf8lrmsyhWba8phXOmjzA/RPntCNd3PKWMvpjrgeFyMglBjlQiyQny5ej8FdsR4zePIwR7PQ==@kvack.org X-Gm-Message-State: AOJu0YxEBdMvGGSomBm7IHaaOgt0DxYvi/Lrd8p9X8c6dIhP8WNVuR/z MqGcMyP3G7eg/BEmZZaiahNocNUw2rKf6x6Oi4zegHWY+3qqSBpQ X-Gm-Gg: ASbGncsuLUIgwsLGHb93MD8lwr+vqaFoDoSxHrqn918lBqZtjUk+uqPk5Go4t8sG8VX xHRHR/Kgc1MNf9xgEoHiGKjTCQ+PDf8k2YZMHDj4ig0xhUHeyPA6ma9LimUBXyl6lcwRArdStev RZTB9gGPwpzHAwh4NcWCdGli3G2AI+dKJw2jwZ5Pvo85KLxzLr4bm4xun8VOnYLjuJ45sGeTNRw YmDVghwqloMoOiKWSls1uykWS0LS88WDgPNF6UrI0o7VJU3lvhk9n01GXL4ZzMJEQsAS24nsSti STToW9Q= X-Google-Smtp-Source: AGHT+IHLAeXlO3hV4T4enIEVaprWMG6iSEGmCJjenAgTvawMCOMVSwu8lq2Sie7M0ZZb8hK7wtsTZA== X-Received: by 2002:a17:90a:c2ce:b0:2ee:a76a:820 with SMTP id 98e67ed59e1d1-2f782cbfa62mr11473228a91.18.1737222563329; Sat, 18 Jan 2025 09:49:23 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f7762b37b1sm4358427a91.42.2025.01.18.09.49.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jan 2025 09:49:22 -0800 (PST) Date: Sat, 18 Jan 2025 09:49:21 -0800 From: Guenter Roeck To: David Laight Cc: David Laight , Linus Torvalds , 'Arnd Bergmann' , "'linux-kernel@vger.kernel.org'" , 'Jens Axboe' , 'Matthew Wilcox' , 'Christoph Hellwig' , 'Andrew Morton' , 'Andy Shevchenko' , 'Dan Carpenter' , "'Jason A . Donenfeld'" , "'pedro.falcato@gmail.com'" , 'Mateusz Guzik' , "'linux-mm@kvack.org'" , 'Lorenzo Stoakes' , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , Simona Vetter , Jani Nikula , Rodrigo Vivi Subject: Re: Buiild error in i915/xe (was: [PATCH next 4/7] minmax.h: Use BUILD_BUG_ON_MSG() for the lo < hi test in clamp()) Message-ID: <29ef57a1-e4dd-4d5d-8726-f1f79c698b66@roeck-us.net> References: <34d53778977747f19cce2abb287bb3e6@AcuMS.aculab.com> <20250118170959.3aa56f4d@pumpkin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250118170959.3aa56f4d@pumpkin> X-Rspam-User: X-Rspamd-Queue-Id: CACDA40015 X-Rspamd-Server: rspam10 X-Stat-Signature: 3z3188dc5bepd1ibada7cmofpcj7iif3 X-HE-Tag: 1737222564-357255 X-HE-Meta: U2FsdGVkX1+yrA9/8/G7p289e31Lqgn2AOLlyvEOZmVWOrVvSdwoJSNbpU4XrGoZZdvaZ//Js8TvCXXMNBk8kiWWJLBV4shF70FQnZRvODEYSdcaJWJ0m0O6AcbsFyhZTxJx0Ft+x6JA+DYh8Z0qQSQdMkmP4fvd/v8+D5+SEy22esoSn+1TxATS+8pONDwt7TTmHgO0R9AWXtLWC0Pfz6PngwA3TDPILT+DExiJLR3fWHVIKtAaBdY45zqtm7R1hxtTxgvzaJkO/pGRLtYuFdcHjmkTar7Ac53boWR5M5Lc5m/I9k9mEgU42+OTwZalsc+hx30TwK/Sxo1FLf4aKqwXorhON5X33Ew07v+bIJYtZdhcy/Q3yQrIL4k2MeSZ8JKe9lKbYYnBWdQulpcRUJBxsHMrXIWOtotqI/MdEaUu+zrpwpbbq+xBO/Q2SOCTRhRyZSzRjeSYcwrKE/6Fq3u7oi9qB0+umx5DuVWMahGo+xGOtjuunGPCN6+rD7Z4VQ6oQwKRhL+FKsJ6wl/EzSs8RaqI/7F0bhPI7sOvZ4IUy5rpXy60A3yx6Vkg3uiZi2YHfT7yv5yyx2EBbsYmB5jNrAySubTfzYH0HlpuAR6khsKwlwS5oxLaZfc5xJL4b00fSRJTRBrwPmWi/w1fzz44xAOF/rMQM1fRqv58zrzHRYCKYQ6mGr7xuoujmwsEb5GOqpeqFj5bB7OWpD5zeyHRZI6yX+bj95Um7PsGMkt4lp2iGRjnmYTsmgM+7ZW+Udh/EE11XSoMkOer1FrnpR2efFJWEnsrFxBYaqcxeGd+h2nJU4Q15FUNKvWSZk0vEGXeHRdopyVrjTaOKbwum42r1uBVMMLdxuNj0t5xeXW/Ktia7+sILw/F2hhXb377SzWxieKzOobiCRmRbCCFVaBHjs5pBuq0NBTjiugJlwxgBfMHarXElUHLSMKvdhz8kThCmSnrR8pffMLmPjv cZ7L/7ej phjXkx4/yx7gwgdcwtOD7iOt7gnzea9mJtlHt1SSP/dJaoTUKT2O4XhnvtGPin7p1Wkk33OaYAviNbnBICwnSdy0Wy+hYwllM2iTcJdUMUWvUD/TFgX7ZH1D6CPqD9VZ81u2YaZ5rQ0l1H4dsS+61O+POTkTMMq2AkG2goLSyVgRpXhFw1I5TidriB6FGW9hD1j+3HY4heiINj3CRt8MAZjdwTJn3utkrT6NUWkh6VDnoAuK+n1v09mmYJznm94hDkGhC1krPeit2tgwT5/3mpmX/DirTADBJsNss9kzx4K10K98RggbhCFPaF4b9ZZ73MZWHNMEjGAYniAtgr0UTw8MbYLpSa11tByU4ZnfdQ/C3rus+vqetPkzHDzMoQ+Smm9x+G/v2wW2VNE8jPoZJflqk2GCtnjkoxoFFYAcuXGQ5unLY9K+OBm4hDQSNTZcTBSCVcSe37fGcvtyiH3hhiGS2RM6mcjJCNC7iTCQ+vg/XFHUYpLq1RaJrc1YrG8+PKCrXn6ZgAG/mceOAbfWrTT8eEgNoch3C/m8A2vX0boIvD38xp7xmSuilBjXAKRAIaF2hGH4cj4xTrLDC4UfR4ID/1iDDGqPNZJLxcim+LtdOeGhDcK/+EhGQonVGf9OE/6SAzkzNBdiENUs23as4z4XHxsD+EIMReVQD4IQv4QQ2mwCC8K6xGIWExfqu2LAhfHBpjFoAD4i/T/Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jan 18, 2025 at 05:09:59PM +0000, David Laight wrote: > On Sat, 18 Jan 2025 08:13:06 -0800 > Guenter Roeck wrote: > > > Hi, > > > > On Mon, Nov 18, 2024 at 07:13:31PM +0000, David Laight wrote: > > > Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity > > > check of the bounds in clamp(). > > > Gives better error coverage and one less expansion of the arguments. > > > > > > Signed-off-by: David Laight > > > > This patch triggers a build error when trying to build parisc:allmodconfig. > > See error message and bisect log below. > > > > I don't think there is anything wrong with the patch. The underlying > > problem seems to be that parisc:allmodconfig enables CONFIG_DRM_XE which > > tries to build the affected file even though CONFIG_DRM_I915 is not > > enabled/supported on parisc. > > This has appeared before. > Any idea which inlined copy of scale() is causing the problem. > On the face of it they all look ok. > > If you can reproduce it maybe try commenting out some of the calls. > See diff below. All three changes are needed. No idea why the compiler would know that the values are invalid. Guenter --- diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c index fc1e517e074a..3b2c8bdfcf8d 100644 --- a/drivers/gpu/drm/i915/display/intel_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_backlight.c @@ -76,10 +76,14 @@ static u32 clamp_user_to_hw(struct intel_connector *connector, static u32 scale_hw_to_user(struct intel_connector *connector, u32 hw_level, u32 user_max) { +#if 0 struct intel_panel *panel = &connector->panel; return scale(hw_level, panel->backlight.min, panel->backlight.max, 0, user_max); +#else + return 0; +#endif } u32 intel_backlight_invert_pwm_level(struct intel_connector *connector, u32 val) @@ -119,8 +123,10 @@ u32 intel_backlight_level_to_pwm(struct intel_connector *connector, u32 val) drm_WARN_ON_ONCE(&i915->drm, panel->backlight.max == 0 || panel->backlight.pwm_level_max == 0); +#if 0 val = scale(val, panel->backlight.min, panel->backlight.max, panel->backlight.pwm_level_min, panel->backlight.pwm_level_max); +#endif return intel_backlight_invert_pwm_level(connector, val); } @@ -138,8 +144,12 @@ u32 intel_backlight_level_from_pwm(struct intel_connector *connector, u32 val) intel_has_quirk(display, QUIRK_INVERT_BRIGHTNESS))) val = panel->backlight.pwm_level_max - (val - panel->backlight.pwm_level_min); +#if 0 return scale(val, panel->backlight.pwm_level_min, panel->backlight.pwm_level_max, panel->backlight.min, panel->backlight.max); +#else + return 0; +#endif } static u32 lpt_get_backlight(struct intel_connector *connector, enum pipe unused)