From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andrey Konovalov <andreyknvl@google.com>
Subject: [PATCH mmotm] sparc64: pgtable_64.h: fix mismatched parens
Date: Mon, 30 Sep 2019 17:23:14 -0700 [thread overview]
Message-ID: <29dd42d5-52e3-e2a2-679f-f0e8648f2b40@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
Fix lib-untag-user-pointers-in-strn_user.patch unmatched left paren.
Fixes many of these build errors:
../mm/gup.c: In function '__get_user_pages':
../mm/gup.c:791:30: error: expected ')' before ';' token
start = untagged_addr(start);
^
In file included from ../arch/sparc/include/asm/pgtable.h:5,
from ../include/linux/mm.h:99,
from ../mm/gup.c:7:
../arch/sparc/include/asm/pgtable_64.h:1102:2: note: to match this '('
((__typeof__(addr))(__untagged_addr((unsigned long)(addr)))
^
../mm/gup.c:791:10: note: in expansion of macro 'untagged_addr'
start = untagged_addr(start);
^~~~~~~~~~~~~
../mm/gup.c:892:21: error: expected ';' before '}' token
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrey Konovalov <andreyknvl@google.com>
---
Is this already fixed???
arch/sparc/include/asm/pgtable_64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- mmotm-2019-0925-1810.orig/arch/sparc/include/asm/pgtable_64.h
+++ mmotm-2019-0925-1810/arch/sparc/include/asm/pgtable_64.h
@@ -1099,7 +1099,7 @@ static inline unsigned long __untagged_a
return start;
}
#define untagged_addr(addr) \
- ((__typeof__(addr))(__untagged_addr((unsigned long)(addr)))
+ ((__typeof__(addr))(__untagged_addr((unsigned long)(addr))))
static inline bool pte_access_permitted(pte_t pte, bool write)
{
next reply other threads:[~2019-10-01 0:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 0:23 Randy Dunlap [this message]
2019-10-01 11:53 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29dd42d5-52e3-e2a2-679f-f0e8648f2b40@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox