From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E548E77183 for ; Tue, 17 Dec 2024 01:40:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B030F6B009E; Mon, 16 Dec 2024 20:40:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB26A6B00A0; Mon, 16 Dec 2024 20:40:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9547C6B00A1; Mon, 16 Dec 2024 20:40:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 773226B009E for ; Mon, 16 Dec 2024 20:40:43 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D39E441EDA for ; Tue, 17 Dec 2024 01:40:42 +0000 (UTC) X-FDA: 82902745800.10.5AA88CF Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf23.hostedemail.com (Postfix) with ESMTP id D7933140007 for ; Tue, 17 Dec 2024 01:40:19 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=X8UoPFqV; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf23.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734399612; a=rsa-sha256; cv=none; b=YfOElY+35TyUloRbZNzw3KV+p/vAkdQy/z9OF2KcKuGSna1tY4oH8JFNMvWYg4+JXsRKv8 spVHkIqzwmyqGpqAyrZu3QFsIy3H8ttcEZ4e2dtonNKIRrnZ2tAeJHqK6NHb9SIKCYVbax DIzcGdoga+wg5mC15B/6ZEKak8n9EZg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=X8UoPFqV; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf23.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734399612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kp5bgamgQnxWfuok8ilXwYLyCWVqZ0QAZHqUfBvdgPA=; b=FIgxQpoB4xlXfMiIbpT1zwFvvPlgAYEKqze5yfVZi1+aQVD4qmG3Hq8ronoNnIs3oS5ulD 12pyIQAlv3KJGpPWQHgjdB9dicd17Wpt/pdjlxhrNH7b1zDtOsUxtpc0QtWX31J0NvOzg/ S6o7pGfKalmTwlZaoVM6zE3V0aPZCZg= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1734399636; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=kp5bgamgQnxWfuok8ilXwYLyCWVqZ0QAZHqUfBvdgPA=; b=X8UoPFqVcK5Zx6QPBWAfokgOKh+Bcn1XLS2hjg4I3s8UIIWcJZP689gwh1J7wvYINhLC20JgH3j8YP5Oa+Q8vV9mBpJ8okGtahaLlcSXU+k0qn24bIU1c5WJQRkQDZlP/ykuJcc9BVZIterdWwA+rJcAQ4ZyG69IngzEtLuzL2w= Received: from 30.246.161.240(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WLgi-44_1734399632 cluster:ay36) by smtp.aliyun-inc.com; Tue, 17 Dec 2024 09:40:34 +0800 Message-ID: <29d80fff-f33f-4470-a345-3f8f1a46f1af@linux.alibaba.com> Date: Tue, 17 Dec 2024 09:40:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 1/3] ACPI: APEI: send SIGBUS to current task if synchronous memory error not recovered To: jane.chu@oracle.com, yazen.ghannam@amd.com, mark.rutland@arm.com, catalin.marinas@arm.com, mingo@redhat.com, robin.murphy@arm.com, Jonathan.Cameron@Huawei.com, bp@alien8.de, rafael@kernel.org, linux-arm-kernel@lists.infradead.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, tongtiangen@huawei.com, gregkh@linuxfoundation.org, will@kernel.org, jarkko@kernel.org Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20241202030527.20586-1-xueshuai@linux.alibaba.com> <20241202030527.20586-2-xueshuai@linux.alibaba.com> <2fb8b1e5-d606-47be-a79e-a4e37a3b8f7f@oracle.com> From: Shuai Xue In-Reply-To: <2fb8b1e5-d606-47be-a79e-a4e37a3b8f7f@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 5jkj5pqgg1of7bmhu69o3c68u8qj8jw6 X-Rspam-User: X-Rspamd-Queue-Id: D7933140007 X-Rspamd-Server: rspam08 X-HE-Tag: 1734399619-242236 X-HE-Meta: U2FsdGVkX1+gP7oKMHTMtO+59awtMXaGOt9tEYe2qp6Ik0PCmYvO4AvUDQzuVDnfoRSHDyMjTkJ+qPoHZHlPgF05nW4MABAbKDDpI47O3Xx4opxxK6DzeF8bWvJ8Jh+V11og4BVVZcyKIw9Wm6y4H7Nwl0qjpr0N7D9wXkrVn7DbHfXuUCuBaxjeIDcxXb7iAgOEQl2BNpUIgl+bs50NzT34B7teYnEtcjpXETfwjNjR2dON+3M3YmO8MNltqCRlOWB5pkCdUOa82qmgQVDkrM6v5S0KAPwuBP3kaVWZuWd9xfzXJogw47FtlKAs+xVue0WZWW0I+/uuEVRwOZ1bRdptEO0URSLdCHUb5VvYqBNUaKlGHfZxqgNhIeQO5mSVWhmJxzfkFpTTRHoyZaa74NN4c6p/o8wcmMZ5rW2ZZa85IVIlWYQhTEGuRECwvmzCbVGIvJOeQTnHIQqx51oIJVluz4648yfOoYTcEpJGmvYoJ4TzvNv1y3mVGON5lmhrOB2ibpMMAxgaj0wdiu0CzuvU38WNau/YO0H+U/8pY+ZquiCpCpOhg6s6ZE2eAw+cTEvqLfGnP4DZ0ugo2mzCR3t3TRZZZRTZBKFirL8KoM0m0HkXtGK31SaENzJ9Cw2AFQdBdvMpwltZXIOAowOU3cekhy/XAmQswBpi6k3JOJo6WBFaRFVAeqKEo2J0E/rV1KWfTH79aeR+rC8zDKUlPOIGAFI9/Dy0dVEOqNFKt+7bhZDtyMW2OM2V+7+SgL2kqPEAJ43UtJkrRyrwkTmEQB6byY9680YZWaBMEd7xr4gxxNQAfArAs5Bo8p2ErsBZPCY871Q+G3ykv88oDstSm+NwHA6C64p9FU5yebbZZXnnHuvdPdIIt+YIskECSf/i4cTDRTrqofAMPQ4005tE92pPmEBfZT7LhE53C8gvaHNud0qoMZBFiXN0eGcqoKf0aqeIAZGuEgUiqYn2Eqf 33HQTZ+B QShy6zFOJ4UnOOU809pO4fMcdZq8gE+Mc5EY2RgHX7ypWaGrm3PmmH7WmWBwyeP8tI4OFviuvIygamk+XHYXh18L0c5KOiRTfP8uC4RQNKQr77G2ZYKqGwczdu7JMB5PYphiIQGPRVnwck4sfVJXT8vUkfJr4sTiJdCewR3cbKncXuhtxkTrVWkr5ldA7Nt3Drs6+M00PHxPb4CrjDchw45c9C8QqulDlERLoXRj/QxBnnkKhTcs10O0ILnnVkUtihpoJglixhe5kFSF8sOCsOkbrQXskqTUHP5iZxs7xIrdxIBPMReGv27e7E6A2FVlYlfnkbbKoZuVn+IRsIxKtYxpSUDvnuPePoGmwlsDW5s3kepL+ipaHfs027e6/tYBUw8enDQHYvndsf7bprMEvvgJp8/SN3+ShP7nzt3NftYCrHmA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/12/17 07:37, jane.chu@oracle.com 写道: > > On 12/1/2024 7:05 PM, Shuai Xue wrote: >> Synchronous error was detected as a result of user-space process accessing >> a 2-bit uncorrected error. The CPU will take a synchronous error exception >> such as Synchronous External Abort (SEA) on Arm64. The kernel will queue a >> memory_failure() work which poisons the related page, unmaps the page, and >> then sends a SIGBUS to the process, so that a system wide panic can be >> avoided. >> >> However, no memory_failure() work will be queued when abnormal synchronous >> errors occur. These errors can include situations such as invalid PA, >> unexpected severity, no memory failure config support, invalid GUID >> section, etc. In such case, the user-space process will trigger SEA again. >> This loop can potentially exceed the platform firmware threshold or even >> trigger a kernel hard lockup, leading to a system reboot. >> >> Fix it by performing a force kill if no memory_failure() work is queued >> for synchronous errors. >> >> Signed-off-by: Shuai Xue >> Reviewed-by: Jarkko Sakkinen >> Reviewed-by: Jonathan Cameron >> Reviewed-by: Yazen Ghannam >> --- >>   drivers/acpi/apei/ghes.c | 11 +++++++++++ >>   1 file changed, 11 insertions(+) >> >> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c >> index a2491905f165..106486bdfefc 100644 >> --- a/drivers/acpi/apei/ghes.c >> +++ b/drivers/acpi/apei/ghes.c >> @@ -801,6 +801,17 @@ static bool ghes_do_proc(struct ghes *ghes, >>           } >>       } >> +    /* >> +     * If no memory failure work is queued for abnormal synchronous >> +     * errors, do a force kill. >> +     */ >> +    if (sync && !queued) { >> +        dev_err(ghes->dev, >> +            HW_ERR GHES_PFX "%s:%d: synchronous unrecoverable error (SIGBUS)\n", >> +            current->comm, task_pid_nr(current)); >> +        force_sig(SIGBUS); >> +    } >> + >>       return queued; >>   } > > Looks good. > > Reviewed-by: Jane Chu > > -jane Thanks. Best Regards, Shuai