From: "Yin, Fengwei" <fengwei.yin@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Yin Fengwei <fengwei.yin@intel.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>, <willy@infradead.org>,
<vishal.moola@gmail.com>, <wangkefeng.wang@huawei.com>,
<minchan@kernel.org>, <yuzhao@google.com>, <david@redhat.com>,
<ryan.roberts@arm.com>, <shy828301@gmail.com>
Subject: Re: [PATCH 0/2] don't use mapcount() to check large folio sharing
Date: Wed, 2 Aug 2023 20:39:21 +0800 [thread overview]
Message-ID: <29cd58c4-08d3-c03c-7232-15f85878934d@intel.com> (raw)
In-Reply-To: <20230728102405.7b456eb87fb46042fbce5e4b@linux-foundation.org>
Hi Andrew,
On 7/29/2023 1:24 AM, Andrew Morton wrote:
> On Sat, 29 Jul 2023 00:13:54 +0800 Yin Fengwei <fengwei.yin@intel.com> wrote:
>
>> In madvise_cold_or_pageout_pte_range() and madvise_free_pte_range(),
>> folio_mapcount() is used to check whether the folio is shared. But it's
>> not correct as folio_mapcount() returns total mapcount of large folio.
>>
>> Use folio_estimated_sharers() here as the estimated number is enough.
>
> What are the user-visible runtime effects of these changes?
>
> (and please try to avoid using the same Subject: for different patches)
>
Can you hold on these patches to mm-unstable? I think we need to wait for
David's work on folio_maybe_mapped_shared() and redo the fix base on that.
Thanks and sorry for the noise.
Regards
Yin, Fengwei
next prev parent reply other threads:[~2023-08-02 12:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 16:13 Yin Fengwei
2023-07-28 16:13 ` [PATCH 1/2] madvise: don't use mapcount() against large folio for sharing check Yin Fengwei
2023-07-28 16:13 ` [PATCH 2/2] " Yin Fengwei
2023-07-28 17:41 ` Andrew Morton
2023-07-29 13:53 ` Yin, Fengwei
2023-07-28 17:24 ` [PATCH 0/2] don't use mapcount() to check large folio sharing Andrew Morton
2023-08-02 12:39 ` Yin, Fengwei [this message]
2023-08-04 7:14 ` Yin, Fengwei
2023-08-07 16:43 ` Andrew Morton
2023-08-08 0:02 ` Yin, Fengwei
2023-08-02 10:27 ` Ryan Roberts
2023-08-02 10:48 ` David Hildenbrand
2023-08-02 11:20 ` Ryan Roberts
2023-08-02 11:36 ` David Hildenbrand
2023-08-02 11:51 ` Ryan Roberts
2023-08-02 11:52 ` David Hildenbrand
2023-08-02 12:35 ` Yin, Fengwei
2023-08-02 12:40 ` Ryan Roberts
2023-08-02 12:42 ` Yin, Fengwei
2023-08-02 12:49 ` Ryan Roberts
2023-08-02 12:55 ` Yin, Fengwei
2023-08-03 20:46 ` Yu Zhao
2023-08-03 23:27 ` Yin, Fengwei
2023-08-03 23:38 ` Yu Zhao
2023-08-04 0:17 ` Yin, Fengwei
2023-08-04 7:31 ` David Hildenbrand
2023-08-04 7:36 ` Yin, Fengwei
2023-08-04 8:11 ` Yin, Fengwei
2023-08-02 12:43 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29cd58c4-08d3-c03c-7232-15f85878934d@intel.com \
--to=fengwei.yin@intel.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vishal.moola@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox