From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 847B0E7716D for ; Wed, 4 Dec 2024 09:55:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F203E6B007B; Wed, 4 Dec 2024 04:55:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ED06E6B0082; Wed, 4 Dec 2024 04:55:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBF6F6B0083; Wed, 4 Dec 2024 04:55:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BF7486B007B for ; Wed, 4 Dec 2024 04:55:56 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 68A2180D64 for ; Wed, 4 Dec 2024 09:55:56 +0000 (UTC) X-FDA: 82856819850.21.C301005 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 9AA3A14000D for ; Wed, 4 Dec 2024 09:55:44 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KYc+ZWbt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ImdceHYs; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j4if+dsT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XsMkPPEV; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733306147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mr1usVlG4rO1P8IBAlzc4MyE/8qLmyhmkaPBsQ7d1CE=; b=gtG+u2UBwQPG5ex328tOSCpTQoydIgr9+cAWiPizIoG32HoClNmxC178az8UlDBEpoyqZq GGRPTzvfAlA12q8CHoBvFfaRxwyAD/6uXZZGIQ5Q9Kqa1zI7Lr5w1+VJeWJrfT2GZbI/tx w/w7KoJudo4oFZ9b6ZplLVG91iaSw7w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733306147; a=rsa-sha256; cv=none; b=fvF6YuWgoJ2hRcFH15NOSwq+tjXD3UeBy9DsZl3wOxw6wU38yYyoVDJnuCKOpspreAoERi NoQwhgaIbHPQ3Wdp2U5Z/8kwl7Juvm150ubEAc/5/ltft8iFBSEzW6HGF+1VR+IK1YnVZW E2ia8w5cWItyLauHRuh9K7Rdq99vjRs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KYc+ZWbt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ImdceHYs; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=j4if+dsT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XsMkPPEV; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 15FAA1F38E; Wed, 4 Dec 2024 09:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733306152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mr1usVlG4rO1P8IBAlzc4MyE/8qLmyhmkaPBsQ7d1CE=; b=KYc+ZWbtbMuGtlW+WjurTSJyDTc+e4+JObCinGJizMOXOaRX5knC4D/CfMIkXzkLWygcGs w0oDM56KihkwiK+rGCbj9XPZwAlOPg88uLlx2WDn+2zxeaC7srPEtkQi0GpL7JhOfr1Lnv c8xr1BzWviEvYtBMH8mzvErKk+n8ePU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733306152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mr1usVlG4rO1P8IBAlzc4MyE/8qLmyhmkaPBsQ7d1CE=; b=ImdceHYsfD4gNecniH5aUw3gLcFDc+kNjFQ2m92iOfEJjaa91oYuFUJfBz1a+8UxjiDGnC k501WnGwWmtc7ACA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733306151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mr1usVlG4rO1P8IBAlzc4MyE/8qLmyhmkaPBsQ7d1CE=; b=j4if+dsTtGUu61h1TE7iKiXznmwWA2wc0ADnop1DgR0RHwX229nuiOKZkbqdjBqUQOPxV2 wl8l+AexPmmygwu+3w8sokN8vLnVXTN6NmBYWSYU0UMy3uqjuEg+WyJvOvOJNhy2bEU/N2 e5R5PVReIfyTwK+uCl8UYlKrnk1aWZw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733306151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mr1usVlG4rO1P8IBAlzc4MyE/8qLmyhmkaPBsQ7d1CE=; b=XsMkPPEVqxVjQaJV1DVJ+I5bp/REN1i+zuBOQG5DLhL7f3tMOxQtUO8okMQPJ+LXpwRgR1 Pol/KjMXtpfthaCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0631F1396E; Wed, 4 Dec 2024 09:55:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vycZAScnUGf5dAAAD6G6ig (envelope-from ); Wed, 04 Dec 2024 09:55:51 +0000 Message-ID: <29c9eb53-c2d2-4b21-98fe-7a129c830b2d@suse.cz> Date: Wed, 4 Dec 2024 10:55:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/15] mm/page_alloc: Move set_page_refcounted() to callers of prep_new_page() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, David Hildenbrand , Zi Yan References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-6-willy@infradead.org> From: Vlastimil Babka In-Reply-To: <20241125210149.2976098-6-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9AA3A14000D X-Stat-Signature: 4yy5bnd59krfnrbzm3q1e7wxqjspgymq X-Rspam-User: X-HE-Tag: 1733306144-268232 X-HE-Meta: U2FsdGVkX1+SD6SME+oEN+dRTHY9b6ki2u9c/2uBk3LZYQgzfKwuysxmLbbXG3b5hOnsIQfq8N8JJAXQpKAlWH5zDDlxLzlEbMFAKWXee8jLnfhTgUjj2ACX/dfrSEHH8b0IGr5Kx858OICKYBN+kvMe9/zSm7jE1PknZmd4vpkniWXn+okyd5ewXvoDD/mx8ShLnsBcauZYWV5oe+0yagSzdwpJm5RTuk4PLno7cW4ep5xYX6F448IV9EGVoQC1655NqJg4zhMUahqEWlBvF/l/hkdwzD6A0yIKvGX4izVI9CvEGxGwoGw5PtZx9CyX2kl51jLV9iuBjfql98Wi3SSo2MtOKftksKp+IenE/xN+fgJEy9NcrNCmaYuZ7Mui4Xe7FOyLLjF16V7NfR6eTk3rv6+8BwZnzXyuFIFgLMWwK18ZMzD6AWX7+SPVSQn2WrlSr9YSjKfMuN2untw5ddulog4+EhD9prsAMxX0S2x8QDi6PV3A0lkrdTQA8trvGTC5V3PjF5OmArKib64It79YhO9paOOwxhKWK7jx+9PlfHWn6ysEsrJkQx6iDH6hrZIIkIWtOHMO4vf91V2uTgUVIL6j1d6oKZaawghZQiMpy8YedszY+AJ7AdoY7+i8g7Yz9vAU26ehGa3B6Q0eMJbSjmfjGmLCmmO3KnTARFCdjDCKw7GgoTdKw8q0HNiaewnSAX8QfCnV/a46+XMtA0KszXLx/1ZTcjO/d2GcaxqIm7f06N5+zsAcsengy+tiapSeaLazQkG/rndNTVATLatwnz6uFKDOEOKaeHnbqve5tsCbqhpR9afRjDHlniKzfOsJX5H7lRDoIY4p/S7CclXpYfZQgN5vwWyINH17aYo6ZQRiM0q50NnPkwsZwXs1SOdyhG6qIfmlAcKlVkgt/ni45OJkaZ3X3cBcVXSy2FePoWwgFUc1hkaQsAu37s4bXfCWLXbvrpynh1FTN8f soKK/IRS FDEk0njJB9i+JkMds+WA3BeKusgHUcjHOnYv8QnQrQSI2KHZ9K306l3DfWLbaqKmqsKeLiSX0uBa2//oHijn8cEzc34tcnS4g5arWHcvYTB7AKEZdsH5zkc6q+fCg0BOvjc6u/gOdeITO5EsMMZcNzI5o7Az8GW9HZwQi21iGVC1/7sTnNDds6iaNtSiAlEegkH6CVl6QX9B0qAXGtWVZLfSTGTSxU9nURtfcHeb009zI4nkJVWPkDhq0ZzrOn3aDI2t75cFEoAynwATFk3shuUtsZ0g6eauAE2vLZpgqKIXB7ILDNmTx5cFZd3d3chqDORGNM5dqxQLZ/+naqVWoV+L7lzbnyFmmmfUVZSoTKxZtwslGrDZ1F1HiMqk+z31kn7dvVuC4O87L0zc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/25/24 22:01, Matthew Wilcox (Oracle) wrote: > In preparation for allocating frozen pages, stop initialising the page > refcount in prep_new_page(). > > Signed-off-by: Matthew Wilcox (Oracle) Can't hurt to only set refcount on a compound page after it's fully initialized. But we do it without any memory barriers so it's probably the same, and hopefully no speculative sanner is tricked by that before nor after. Anyway, Reviewed-by: Vlastimil Babka