From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA80EB64DC for ; Fri, 21 Jul 2023 15:42:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CE218D0003; Fri, 21 Jul 2023 11:42:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3564F8D0001; Fri, 21 Jul 2023 11:42:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F7568D0003; Fri, 21 Jul 2023 11:42:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0C2BE8D0001 for ; Fri, 21 Jul 2023 11:42:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D4171B1477 for ; Fri, 21 Jul 2023 15:42:24 +0000 (UTC) X-FDA: 81036035808.22.658C1C6 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf19.hostedemail.com (Postfix) with ESMTP id 0376A1A0003 for ; Fri, 21 Jul 2023 15:42:20 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Iwry773Y; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of xiaoyao.li@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689954141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nwd61PHEoroNvWfwA0YfCCwXlvtNgCfLCXWmosCWze8=; b=WqrnkQ/ffgJIc8BK0uWxpDAlxgJdW1Uror3Pjizi4lHynBoYdRiKYIajSEb0C3bqQL1od3 hbB/EejaURkBzif/c0++RZnsmREYtQSkxpKnBFbrw/r7QWpCC5oucvAuH3gliwnfNSFTch PtQXvo30Ss5G2NDIqj8WpHcR7YOcFUg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Iwry773Y; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of xiaoyao.li@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689954141; a=rsa-sha256; cv=none; b=c/65HirL+Y0cedOodr0S24aPyKNeOByL9EJ9KFwBOpsiBJ1mfzoJSjBVOg7UMmT2V4zFBL j3UahaCQ8/BImVCb+5g3EzdnRUS0tNYQLny5+vBvJmXngWUYvHVx8xjFTCKMa5BajYdsk4 3z7iWLm1muwKvAlHrJAra6lME9rj+rY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689954141; x=1721490141; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=dgWqCDpNSWuzZvJih5GvRdqDtkxO0fYOrqXInsikkp8=; b=Iwry773Y0OXjnEMx/Czaqj8aDBfrgmIa1DGd5mthjnvCCwTgbKMFUQZc h1CDXJJcCOB3Qoe9v8y9AIu171N7m1bBMxRWWkACWcFzPn0RdQWGwVqIZ kyardh5KVVAH6ghaHHUS5fWYv4jgBzLeLiPBIgWbuukNpLHC9LCLmd+n+ AXypV/NE2lJUh181mpD6z+FuCVsclPlYnV9g4pIYW7CPlQaPr9HdQ7sEZ +v4ZDe49/eQWF6Dp2SaKageXV+BYxt+btpasvGlsrDDeGOsvkXmLcW7CL lqeelBg2G3DtU++mP8WgoFn2bFobgUfFyTyJzvBn3XiGAS7EWwDFgw7cc w==; X-IronPort-AV: E=McAfee;i="6600,9927,10778"; a="367087053" X-IronPort-AV: E=Sophos;i="6.01,222,1684825200"; d="scan'208";a="367087053" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 08:42:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="868274880" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.93.6.77]) ([10.93.6.77]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2023 08:42:09 -0700 Message-ID: <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Date: Fri, 21 Jul 2023 23:42:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory Content-Language: en-US From: Xiaoyao Li To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-13-seanjc@google.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0376A1A0003 X-Stat-Signature: 548g7seeyico6oh4ptg4a6hiu1k585br X-HE-Tag: 1689954140-275015 X-HE-Meta: U2FsdGVkX1/UqSWH46IJsJeH5Xy/829If3Oubq3gj+w4IccxhdWX4HMoM0iFIF9atUo6aMce9gjhuqTCZg5FuIipoijDkFXd4cxFcI4Uh+H+OWrpYL8KVdiX5G8Esk2tagzlWPi0+YvIv4ZLzBxCmPgU5ggOEMlL5Tf9S4uwGCVb2U70kr3u2P9ItyuvIdEt75ud4+rZnQu/+dUEwvGa8fkVkLS/ttV7oiaeXDAoZiS6yHBXQ8Kterkgn+z0hvKgOaDKdLua+Edj/YCDHdlV98sXo1aXODMg3CcDx05CjK/pppXyH09TIa3fMtncev6+i712hNn5hzEURUvfb2jiBEXMQs0zD/Ca2dCIZNkyNKi3mhk+HMQVtwHkxQEk7nusRGFkVyVI3XCKKpNFUjQjoHqvQEuFZ5s8zIoh9Gy0oaaNN4Ah1de7+QtyCgQ8D6Gg75HF98hnrv3feBmf4loukNF6MOeRMSyUK7Jiygqi9zwwNd9AOwrAll93rIguzbL1F1MXU7xSK5KG1rh4bcN/k3w9Vs/b3XqpBH1uIxqQlGSfukvJhXtTuRiee2zLJUNflOFa3EFFaSbQZvtOnQjraJ1EsOoP6Ru04TH4lgxaRwKlg5Nbq5PzOXOVIKzFEa3IBJ9FEMYn3ks9NNi8wCTo0B1iF4yeTOuzT8aqkSRe3dnO2p2gdnfH5ZhC0YspT3YKp9lmNF76Hw4QRn39+F9fSioz00Sp9ZthrOw8ufgJpqYWM+OvmOGnouCisivHFq1AvNyh46l5ONqDnhu9f+1gBS5tAKd7RTr8HSgHhyCtWvOZCeJpGNdl6oH9RubEku812oyK+6Oo2Ibo1ZbTNnTiRbkZPXlmogz67YCryKHMQ79MjPU6SuJ8Hn9+wzV0csYD06+2bg8Cc0UqRsydyMXf9uUkr8Yq5VF7D7m+677gPGW/5i311ytPxgqTQA3pjRVDwZ40oBuXLEV+hbhgO5d e48yjMoK wqLEgtnh/xoYn70jKrDxhLoneNa+/xoT6dzZ/WAZm4JIvuyqdoaEyrwrj40CVrxRklhuTYEiE5fCjpenMT1z3ifRSgI9vZt7oszaoK5Xyjsv4ud9s9Jiy37XvKrqa1aqEqcyU7zEiS+MtsHBixTzHr0cfNoppyrYwAVWqvjfaXnqRlCuTh2h56qh7F+hRKhCs4VT/4wKDnLJ7h5wJFaBJ8xvybieWwYIx0mvlRacItVyn719qWfhT6dzhv2sZj1Uft9c7lJBOnK5fwGk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/21/2023 11:05 PM, Xiaoyao Li wrote: > On 7/19/2023 7:44 AM, Sean Christopherson wrote: >> @@ -6255,12 +6298,17 @@ int kvm_init(unsigned vcpu_size, unsigned >> vcpu_align, struct module *module) >>       if (r) >>           goto err_async_pf; >> +    r = kvm_gmem_init(); >> +    if (r) >> +        goto err_gmem; >> + >>       kvm_chardev_ops.owner = module; >>       kvm_preempt_ops.sched_in = kvm_sched_in; >>       kvm_preempt_ops.sched_out = kvm_sched_out; >>       kvm_init_debug(); >> +    kvm_gmem_init(); > > why kvm_gmem_init() needs to be called again? by mistake? I'm sure it's a mistake. I'm testing the gmem QEMU with this series. SW_PROTECTED_VM gets stuck in a loop in early OVMF code due to two shared page of OVMF get zapped and re-mapped infinitely. Removing the second call of kvm_gmem_init() can solve the issue, though I'm not sure about the reason.