From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980DACD11C2 for ; Wed, 10 Apr 2024 15:51:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE0266B007B; Wed, 10 Apr 2024 11:51:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8F576B0087; Wed, 10 Apr 2024 11:51:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E1926B0088; Wed, 10 Apr 2024 11:51:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7D00E6B007B for ; Wed, 10 Apr 2024 11:51:37 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C388912083B for ; Wed, 10 Apr 2024 15:51:36 +0000 (UTC) X-FDA: 81994062192.23.7D4CB67 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 712EA2000C for ; Wed, 10 Apr 2024 15:51:34 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZU7KLDgS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712764294; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hSdS2v/hATr4/3u4hgjd9nxCs++wDV//OUkrAd628Is=; b=wUucU45CxxCXDs0BCNqjH0G9ox9M4/FfheoyE5jmDNPCbRnAALWbLD9ZTx5P+0xxyhJdvg DBRb5bbG8BKs6kTh3zIS9MpjyTHW09tNt7OZkqtmjj4giIWZTytLWGCX7zFnvRV/xZoxiv 5uiud307PHzZBQxb3ydfiHv1Qd3l8EQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZU7KLDgS; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712764294; a=rsa-sha256; cv=none; b=NNH263+Z3pzF8OGkrnLMTrBrOugZaq9+lSaapqHUUB5b64AU7fhfnNIw4z3s0pXowCcIvo vm3FEFwxQt2OwVcQM1mTAlcXeO9/xxl6ATznBXRMcngeShkD08/4zYpJq4lkfHMkoWevDY i1HpSVyz+NDb8sX3NfNMp7Ska5kefHw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712764293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hSdS2v/hATr4/3u4hgjd9nxCs++wDV//OUkrAd628Is=; b=ZU7KLDgS4uZGuinhT263xgQqWmFfVx7oz0BflLzJDNEM/DThxoVYADRodVmUhid69wSkcq f7//kcRBJAY0g8jTjOXjXinmfFbDLQKpA2Z6brpI6cq+Sys5AKmo2/xkXltPFSjLy6UTuB ufFXZj5A/i+4iPpw14GfTKKhV0RKWEw= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-331-tCh0em36OAuky-0Zkn01gg-1; Wed, 10 Apr 2024 11:51:32 -0400 X-MC-Unique: tCh0em36OAuky-0Zkn01gg-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d88bc8e8a4so31505711fa.2 for ; Wed, 10 Apr 2024 08:51:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712764291; x=1713369091; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hSdS2v/hATr4/3u4hgjd9nxCs++wDV//OUkrAd628Is=; b=fEatOqIdxwdU2u044qFTq79WznFvYHSVgpuNOCRQgMSvD8CfqkTpsuN6TdbppKvmPP hw2L7X4wCNFw/k4UkA5Bi5DzXhmar6GpiekzNsCMEi52rNoY8viDPxlpnH3f2unUf54r 1mcJm5Nib6pssXqHet5PqI1du62wb3BRDS2AF80L3PYN6hUkUqqZQJ5IGGnC0ZAPzuYV MNW2iie37x55TWn00Ufjay+4fUzDRXgwKcs7l51uvVagJyxpMXf2QdzQl2qqIqZ9Epux OoxM4VBVqO4+4ehwOodT2PhJtEumogFtiK/6baGjNOGV6+75auJ7zy8g05+qBP0x4/5s u5nw== X-Forwarded-Encrypted: i=1; AJvYcCWY2+Vg2DZcyd2YfIduNx4CYcRySJ3nBqYc+ZgR00Qg2t+QG/9FMjs80gZiM78kK48FWU2SborJzTni9C8IF8v2LOs= X-Gm-Message-State: AOJu0Yz2bJ4nO5bmh0jv0gyf2M8AeQrTcfZ82ftIcx8vLWvujUEWipBs zH7uCWm/M4mB/YH/piowXbzyJ7jA3DgED1g9X6rbqYz3dGpsj3nqwYmd0JEGq/2aaKzuybBGbrQ FqbNAWVyk2+11XJVEJiaMM9QimmbZ8QwVzlnCX7E5aMavvvKK X-Received: by 2002:a2e:3801:0:b0:2d7:a1c8:71bd with SMTP id f1-20020a2e3801000000b002d7a1c871bdmr2141642lja.0.1712764290801; Wed, 10 Apr 2024 08:51:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHSjjubjr0hC6WCig/jKnUEjp2ObInIt7086mDXKnWdThyKegr3q1EgiBE1PYHCGd1bpUdZ8g== X-Received: by 2002:a2e:3801:0:b0:2d7:a1c8:71bd with SMTP id f1-20020a2e3801000000b002d7a1c871bdmr2141622lja.0.1712764290359; Wed, 10 Apr 2024 08:51:30 -0700 (PDT) Received: from ?IPV6:2003:cb:c712:fa00:38eb:93ad:be38:d469? (p200300cbc712fa0038eb93adbe38d469.dip0.t-ipconnect.de. [2003:cb:c712:fa00:38eb:93ad:be38:d469]) by smtp.gmail.com with ESMTPSA id iv11-20020a05600c548b00b0041665b6e111sm2645572wmb.12.2024.04.10.08.51.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 08:51:29 -0700 (PDT) Message-ID: <29b613a8-f0d5-4f5f-adbc-d64ed8908044@redhat.com> Date: Wed, 10 Apr 2024 17:51:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/shmem: Inline shmem_is_huge() for disabled transparent hugepages To: Sumanth Korikkar Cc: akpm@linux-foundation.org, linux-mm@kvack.org, hughd@google.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, iii@linux.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240409155407.2322714-1-sumanthk@linux.ibm.com> <594dbec7-b560-44e5-a684-93dcb8ba85df@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: k9zhkyyxhm711j96u1gt37df7kwu8xg4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 712EA2000C X-HE-Tag: 1712764294-203044 X-HE-Meta: U2FsdGVkX1+A2puzxTWD/RV711k2E3rXuJjIP5pb+aERBe/MmEzhmeeiAxIjMAwE7mDXbXaYyWyICrrlSRdWZHLDwO/NqwLixni6IJK4dKK+rrjZCbSUlss6gxbo6Rowq9vmy1rFvXr6j7svaflElLFbFqyX0rDl/VKkRSwPohtaBgkXsUkTXHmaA0NjxsMx9ma92ql6AU1NvtoczMNIWallXsao3OJao/7YRN+Q4hv7Dd+EfqRqP9tfF8GAiwTuIkmKUMrmjGB31aLIC44Yy6GJLPUEF5I+kqav+QLUAdbiPJM7QzBXPteFwE/WgFRFajkztdJqDoOElFHveZITkG8ZEguwEspDAnrfmhXcr5uPQE4qShF0RCRRqj7tdtRojQxvGJ0MUR1eML2wEuYDSd3NKPZlqGew/p/1l6oa11TIeWjRS8WqDNu7MTm3+ImB48MT+BiRXGgjEdVySb/0NLgdHheFB+d4Lj2ljVIaKfkBKfpu7xyKqPOsSaPOTHajWUH+suKG5VdnJBhKBVEwXmaVAgWKZvIh/k3HJezFNU4/PNCpUIRsTEt6ADeCd6/C6KxtTAg1aeCkONS7LSkR23EuUNpqonVkNN6N9f2QXgz+CK1rkHGDklftdE3SEEpDxVKYh7tJN7bjswC+rvDDuth1GLd8YP1ztiSf0814tMme5rev9T96uoIZhI5qRwFe4HuNNNCF4q4l9qvxZZV9uu2kai1WalrJG+weNDCOuFxoxKvCl7dId5BtSgR3Cx81eWk7VN32UCGY7uAKMcndFzYBy3EdWcfs2xAYh1fHn3mIaPeRdoyCtDiroqVn3T3124Nk5ZAzEG+nu0Mm99TOqwj3xKlY4+20PAha8J0WYlU69WunXSt92OrlMqcx51f9iFDj9AlsXjWzgwPyCVeKnxU7zN1Ipt/X1FE4wovQzO6kOGaq98za1spG1m+aBV6kk9gKJem2GeqKyZpo8EZ Y9iU3kbV U6hs2WgMIbx2JsX4DtnftUr/IfWs7SDOYNdkLWXp3Wrs5UbmujPxKdgJQihq/V9F2wvUj3zfSv6sW1mqxvMRXBUMbpA0IUOjSbgZnBUyFjX7Qt65W0NxwAb/7BvYLk1Wh7emM7BS6F3j5RfTr/k602H3gxMoHKEusaP3qewqTwEXprTJ3hjyUuXgclSIxMsDzVcH3QuyBziqbPW1/aO9QTqn9XGqANdok/zBmxXROMTxV6dBZhQlOdSUSjbl11bb9fNJ53L0wu+QAetf4Ok/B//Km3VwW/wxExxpmK2abZ0utsVLJoXkqHlhmzZAaG0YaKQ1Ddka1ZQem18XgSDWmdoc4nVdI5hGd3/ufQlvbi7NLtObpZLYcnTb2MC97LmCrWiI4EUMIJBpEon80ru+bshZbgp8CDRvPeFm+f6ojNHpCaweUARevP+faAT9DHHwVM7o/bX/WHTaoro9KAN0Rkzkt/sEkirRLDqCpMKdEgkljbdhzB196GOIzszI+bEstaVYMpBUzQMwbcPo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000055, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.04.24 17:26, Sumanth Korikkar wrote: > On Wed, Apr 10, 2024 at 02:34:35PM +0200, David Hildenbrand wrote: >> On 09.04.24 17:54, Sumanth Korikkar wrote: >>> In order to minimize code size (CONFIG_CC_OPTIMIZE_FOR_SIZE=y), >>> compiler might choose to make a regular function call (out-of-line) for >>> shmem_is_huge() instead of inlining it. When transparent hugepages are >>> disabled (CONFIG_TRANSPARENT_HUGEPAGE=n), it can cause compilation >>> error. >>> >>> mm/shmem.c: In function ‘shmem_getattr’: >>> ./include/linux/huge_mm.h:383:27: note: in expansion of macro ‘BUILD_BUG’ >>> 383 | #define HPAGE_PMD_SIZE ({ BUILD_BUG(); 0; }) >>> | ^~~~~~~~~ >>> mm/shmem.c:1148:33: note: in expansion of macro ‘HPAGE_PMD_SIZE’ >>> 1148 | stat->blksize = HPAGE_PMD_SIZE; >>> >>> To prevent the possible error, always inline shmem_is_huge() when >>> transparent hugepages are disabled. >>> >> >> Do you know which commit introduced that? > Hi David, > > Currently with CONFIG_CC_OPTIMIZE_FOR_SIZE=y and expirementing with > -fPIC kernel compiler option, I could see this error on s390. Got it. I assume on Linus' tree, not mm/unstable? > > However, default kernel compiler options doesnt end up with the above > pattern right now. Okay, just asking if this is related to recent HPAGE_PMD_SIZE changes: commit c1a1e497a3d5711dbf8fa6d7432d6b83ec18c26f Author: Peter Xu Date: Wed Mar 27 11:23:22 2024 -0400 mm: make HPAGE_PXD_* macros even if !THP Which is still in mm-unstable and not upstream. -- Cheers, David / dhildenb